diff mbox

scsi_dh_rdac: Retry for Quiescence in Progress in rdac device handler

Message ID 0D1E8821739E724A86F4D16902CE275C13FF9AFFD6@inbmail01.lsi.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Chauhan, Vijay Jan. 26, 2009, 3:59 p.m. UTC
During device discovery read capacity fails with 0x068b02 and sets the device size to 0. As a reason any I/O submitted to this path gets killed at sd_prep_fn with BLKPREP_KILL. This patch is to retry for 0x068b02. Please apply.

From: Vijay Chauhan<vijay.chauhan@lsi.com>

This patch adds retry for Quiescence in Progress in rdac device handler.

Signed-off-by: Vijay Chauhan <vijay.chauhan@lsi.com>

---
--

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Comments

Chandra Seetharaman Jan. 26, 2009, 9:04 p.m. UTC | #1
On Mon, 2009-01-26 at 21:29 +0530, Chauhan, Vijay wrote:
> During device discovery read capacity fails with 0x068b02 and sets the device size to 0. As a reason any I/O submitted to this path gets killed at sd_prep_fn with BLKPREP_KILL. This patch is to retry for 0x068b02. Please apply.
> 
> From: Vijay Chauhan<vijay.chauhan@lsi.com>
> 
> This patch adds retry for Quiescence in Progress in rdac device handler.
> 
> Signed-off-by: Vijay Chauhan <vijay.chauhan@lsi.com>

Acked-by: Chandra Seetharaman <sekharan@us.ibm.com>
> 
> ---
> --- linux-2.6.29-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c.orig    2009-01-26 20:46:05.000000000 +0530
> +++ linux-2.6.29-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-01-26 20:47:34.000000000 +0530
> @@ -579,6 +579,11 @@ static int rdac_check_sense(struct scsi_
>                          * Power On, Reset, or Bus Device Reset, just retry.
>                          */
>                         return ADD_TO_MLQUEUE;
> +               if (sense_hdr->asc == 0x8b && sense_hdr->ascq == 0x02)
> +                       /*
> +                        * Quiescence in progress , just retry.
> +                        */
> +                       return ADD_TO_MLQUEUE;
>                 break;
>         }
>         /* success just means we do not care what scsi-ml does */
> --

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
James Bottomley Feb. 10, 2009, 8:44 p.m. UTC | #2
On Mon, 2009-01-26 at 21:29 +0530, Chauhan, Vijay wrote:
> During device discovery read capacity fails with 0x068b02 and sets the device size to 0. As a reason any I/O submitted to this path gets killed at sd_prep_fn with BLKPREP_KILL. This patch is to retry for 0x068b02. Please apply.
> 
> From: Vijay Chauhan<vijay.chauhan@lsi.com>
> 
> This patch adds retry for Quiescence in Progress in rdac device handler.
> 
> Signed-off-by: Vijay Chauhan <vijay.chauhan@lsi.com>
> 
> ---
> --- linux-2.6.29-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c.orig    2009-01-26 20:46:05.000000000 +0530
> +++ linux-2.6.29-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-01-26 20:47:34.000000000 +0530
> @@ -579,6 +579,11 @@ static int rdac_check_sense(struct scsi_
>                          * Power On, Reset, or Bus Device Reset, just retry.
>                          */
>                         return ADD_TO_MLQUEUE;
> +               if (sense_hdr->asc == 0x8b && sense_hdr->ascq == 0x02)
> +                       /*
> +                        * Quiescence in progress , just retry.
> +                        */
> +                       return ADD_TO_MLQUEUE;
>                 break;
>         }
>         /* success just means we do not care what scsi-ml does */

This patch has all the tabs converted to spaces.  Please see 

Documentation/SubmittingPatches
Documentation/email-clients.txt

for preventing this in future.

James


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

--- linux-2.6.29-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c.orig    2009-01-26 20:46:05.000000000 +0530
+++ linux-2.6.29-rc2/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-01-26 20:47:34.000000000 +0530
@@ -579,6 +579,11 @@  static int rdac_check_sense(struct scsi_
                         * Power On, Reset, or Bus Device Reset, just retry.
                         */
                        return ADD_TO_MLQUEUE;
+               if (sense_hdr->asc == 0x8b && sense_hdr->ascq == 0x02)
+                       /*
+                        * Quiescence in progress , just retry.
+                        */
+                       return ADD_TO_MLQUEUE;
                break;
        }
        /* success just means we do not care what scsi-ml does */