From patchwork Tue Mar 17 13:21:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chauhan, Vijay" X-Patchwork-Id: 12599 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2HDMPHB015918 for ; Tue, 17 Mar 2009 13:22:26 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id B0F7E8E006E; Tue, 17 Mar 2009 09:22:25 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n2HDMMDb017688 for ; Tue, 17 Mar 2009 09:22:22 -0400 Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2HDMMqc004112 for ; Tue, 17 Mar 2009 09:22:22 -0400 Received: from exprod7og104.obsmtp.com (exprod7og104.obsmtp.com [64.18.2.161]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n2HDM4Tx022983 for ; Tue, 17 Mar 2009 09:22:05 -0400 Received: from source ([147.145.40.20]) by exprod7ob104.postini.com ([64.18.6.12]) with SMTP ID DSNKSb+j8yaaHo3OAdRIQUZSj59rOXni9/5v@postini.com; Tue, 17 Mar 2009 06:22:05 PDT Received: from milmhbs0.lsil.com (mhbs.lsil.com [147.145.1.30]) by mail0.lsil.com (8.12.11/8.12.11) with ESMTP id n2HDLmpd017758; Tue, 17 Mar 2009 06:21:49 -0700 (PDT) Received: from inbmail01.lsi.com (inbmail01.in.lsil.com [172.28.140.213]) by milmhbs0.lsil.com (8.12.11/8.12.11) with ESMTP id n2HDLigN016712; Tue, 17 Mar 2009 06:21:47 -0700 Received: from inbmail01.lsi.com ([172.28.140.213]) by inbmail01.lsi.com ([172.28.140.213]) with mapi; Tue, 17 Mar 2009 18:51:42 +0530 From: "Chauhan, Vijay" To: James Bottomley Date: Tue, 17 Mar 2009 18:51:40 +0530 Thread-Topic: [PATCH]scsi_dh_rdac: Retry for NOT_READY check condition (0x02A102, 0x020401, 0x020404 and 0x020407) in rdac_check_sense Thread-Index: Acmhl27TEX+Dubo8ToqGBLjZ6wfHGAFaTSMQ Message-ID: <0D1E8821739E724A86F4D16902CE275C1410DBBA51@inbmail01.lsi.com> In-Reply-To: <1236699991.14822.0.camel@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.31 X-Scanned-By: MIMEDefang 2.39 X-RedHat-Spam-Score: -4 X-MIME-Autoconverted: from quoted-printable to 8bit by listman.util.phx.redhat.com id n2HDMMDb017688 X-loop: dm-devel@redhat.com Cc: "'dm-devel@redhat.com'" , "linux-scsi@vger.kernel.org" Subject: [dm-devel] RE: [PATCH]scsi_dh_rdac: Retry for NOT_READY check condition (0x02A102, 0x020401, 0x020404 and 0x020407) in rdac_check_sense X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Hi James, Thanks for your comment. I have updated the patch with your comments. On Tues, 2009-03-10 21:17 +0530, James Bottomley wrote: > > + if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02) > > + /* LUN Not Ready - Quiescense in progress > > + * or has been achieved > > + * Just retry. > > + */ > > + return ADD_TO_MLQUEUE; > > This is fine, being vendor specific, we don't handle it at > the mid-layer > > + if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x07) > > + /* LUN Not Ready - Storage controller > cannot respond > > + * immediately to a PRIN or PROUT command. > > + * Just retry. > > + */ > > + return ADD_TO_MLQUEUE; > > For all of these ... along with a few other not ready types, > we already > do a delayed retry at the mid-layer (in scsi_io_completion). Is there > some problem that causes this to need to be handled here as well? > Yes, I do agree. Submitting patch for 0x02A102 only. Thanks, Vijay Acked-by: Chandra Seetharaman --- This patch adds retry for NOT_READY check condition - Quiescense in progress (02/A1/02) Signed-off-by: Vijay Chauhan --- -- -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel --- linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-03-10 17:42:27.000000000 +0530 +++ linux-2.6.29-rc7/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-03-17 18:18:07.000000000 +0530 @@ -562,6 +562,12 @@ static int rdac_check_sense(struct scsi_ * Just retry and wait. */ return ADD_TO_MLQUEUE; + if (sense_hdr->asc == 0xA1 && sense_hdr->ascq == 0x02) + /* LUN Not Ready - Quiescense in progress + * or has been achieved + * Just retry. + */ + return ADD_TO_MLQUEUE; break; case ILLEGAL_REQUEST: if (sense_hdr->asc == 0x94 && sense_hdr->ascq == 0x01) {