From patchwork Tue Jul 28 12:51:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chauhan, Vijay" X-Patchwork-Id: 37780 X-Patchwork-Delegate: christophe.varoqui@free.fr Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6SCpt48029090 for ; Tue, 28 Jul 2009 12:51:55 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id AF9A46190B9; Tue, 28 Jul 2009 08:51:41 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n6SCpe2o024435 for ; Tue, 28 Jul 2009 08:51:40 -0400 Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6SCpd1e015989 for ; Tue, 28 Jul 2009 08:51:39 -0400 Received: from exprod7og101.obsmtp.com (exprod7og101.obsmtp.com [64.18.2.155]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n6SCpJII009928 for ; Tue, 28 Jul 2009 08:51:19 -0400 Received: from source ([147.145.40.20]) by exprod7ob101.postini.com ([64.18.6.12]) with SMTP ID DSNKSm70Rj1eKIFxHx99zbs8A1ccCosiuFF+@postini.com; Tue, 28 Jul 2009 05:51:23 PDT Received: from milmhbs0.lsil.com (mhbs.lsil.com [147.145.1.30]) by mail0.lsil.com (8.12.11/8.12.11) with ESMTP id n6SCpFWe018000; Tue, 28 Jul 2009 05:51:15 -0700 (PDT) Received: from inbmail01.lsi.com (inbmail01.in.lsil.com [172.28.140.213]) by milmhbs0.lsil.com (8.12.11/8.12.11) with ESMTP id n6SCpG5Z024597; Tue, 28 Jul 2009 05:51:17 -0700 Received: from inbmail01.lsi.com ([172.28.140.213]) by inbmail01.lsi.com ([172.28.140.213]) with mapi; Tue, 28 Jul 2009 18:21:14 +0530 From: "Chauhan, Vijay" To: "'dm-devel@redhat.com'" Date: Tue, 28 Jul 2009 18:21:13 +0530 Thread-Topic: [PATCH]multipath-tools: no_path_retry for time based queuing is queuing I/O for ever Thread-Index: AcoPghZ6IhoHMCerQF+WKKAVANMUfw== Message-ID: <0D1E8821739E724A86F4D16902CE275C141A357072@inbmail01.lsi.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.31 X-Scanned-By: MIMEDefang 2.39 X-RedHat-Spam-Score: -4 X-MIME-Autoconverted: from quoted-printable to 8bit by listman.util.phx.redhat.com id n6SCpe2o024435 X-loop: dm-devel@redhat.com Cc: Subject: [dm-devel] [PATCH]multipath-tools: no_path_retry for time based queuing is queuing I/O for ever X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Even though no_path_retry is set for time based queuing(i.e no_path_retry ), I/O is getting queued for ever. During all path failure condition, setup_feature() resets no_path_retry of multipath structure to NO_PATH_RETRY_QUEUE which queues I/O for ever. This patch skips resetting no_path_retry until no_path_retry is set with queue. Signed-off-by: Vijay Chauhan --- -- -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel diff -uprN multipath-tools-orig/libmultipath/dmparser.c multipath-tools/libmultipath/dmparser.c --- multipath-tools-orig/libmultipath/dmparser.c 2009-07-28 10:06:46.000000000 +0530 +++ multipath-tools/libmultipath/dmparser.c 2009-07-28 10:18:38.000000000 +0530 @@ -145,7 +145,10 @@ disassemble_map (vector pathvec, char * FREE(word); return 1; } - setup_feature(mpp, word); + if ((mpp->no_path_retry == NO_PATH_RETRY_UNDEF) || + (mpp->no_path_retry == NO_PATH_RETRY_FAIL) || + (mpp->no_path_retry == NO_PATH_RETRY_QUEUE)) + setup_feature(mpp, word); FREE(word); }