From patchwork Tue Mar 29 17:19:32 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Milan Broz <mbroz@redhat.com>
X-Patchwork-Id: 671762
X-Patchwork-Delegate: agk@redhat.com
Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p2THMdIi012626
	for <patchwork-dm-devel@patchwork.kernel.org>;
	Tue, 29 Mar 2011 17:23:03 GMT
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
	(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
	by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2THJiev009525;
	Tue, 29 Mar 2011 13:19:45 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with
	ESMTP id p2THJgPX011258 for <dm-devel@listman.util.phx.redhat.com>;
	Tue, 29 Mar 2011 13:19:42 -0400
Received: from tawny.mazyland.cz (vpn2-10-204.ams2.redhat.com [10.36.10.204])
	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with
	ESMTP id p2THJZhi012683; Tue, 29 Mar 2011 13:19:36 -0400
From: Milan Broz <mbroz@redhat.com>
To: dm-devel@redhat.com
Date: Tue, 29 Mar 2011 19:19:32 +0200
Message-Id: <1301419172-10489-1-git-send-email-mbroz@redhat.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-loop: dm-devel@redhat.com
Cc: Milan Broz <mbroz@redhat.com>, zkabelac@redhat.com
Subject: [dm-devel] [PATCH] dm table: Reject unconfigured device
X-BeenThere: dm-devel@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
Reply-To: device-mapper development <dm-devel@redhat.com>
List-Id: device-mapper development <dm-devel.redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/dm-devel>
List-Post: <mailto:dm-devel@redhat.com>
List-Help: <mailto:dm-devel-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=subscribe>
MIME-Version: 1.0
Sender: dm-devel-bounces@redhat.com
Errors-To: dm-devel-bounces@redhat.com
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]);
	Tue, 29 Mar 2011 17:23:03 +0000 (UTC)


diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 38e4eb1..12caa66 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -361,6 +361,7 @@ static void close_dev(struct dm_dev_internal *d, struct mapped_device *md)
 static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
 				  sector_t start, sector_t len, void *data)
 {
+	struct request_queue *q;
 	struct queue_limits *limits = data;
 	struct block_device *bdev = dev->bdev;
 	sector_t dev_size =
@@ -369,6 +370,22 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
 		limits->logical_block_size >> SECTOR_SHIFT;
 	char b[BDEVNAME_SIZE];
 
+	/*
+	 * Some devices exist but have not yet request function defined
+	 * (e.g. loop with not bounded backing file)
+	 * Do not allow using such devices.
+	 */
+	q = bdev_get_queue(bdev);
+	if (!q || !q->make_request_fn) {
+		DMWARN("%s: %s is not yet initialised: "
+		       "start=%llu, len=%llu, dev_size=%llu",
+		       dm_device_name(ti->table->md), bdevname(bdev, b),
+		       (unsigned long long)start,
+		       (unsigned long long)len,
+		       (unsigned long long)dev_size);
+		return 1;
+	}
+
 	if (!dev_size)
 		return 0;