From patchwork Tue Aug 14 16:24:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 1322921 Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by patchwork1.kernel.org (Postfix) with ESMTP id CC9D640210 for ; Tue, 14 Aug 2012 18:31:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7EITBQ6013221; Tue, 14 Aug 2012 14:29:11 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7EGPl4F013361 for ; Tue, 14 Aug 2012 12:25:47 -0400 Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.16]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7EGPgw7003460; Tue, 14 Aug 2012 12:25:42 -0400 Received: from mail-bk0-f46.google.com (mail-bk0-f46.google.com [209.85.214.46]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7EGOqgo002535; Tue, 14 Aug 2012 12:25:39 -0400 Received: by mail-bk0-f46.google.com with SMTP id j10so238412bkw.33 for ; Tue, 14 Aug 2012 09:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=cC0FxFngzPFP7m/x0KmE3AKt+sioSRwbulaylPUlfyk=; b=bGvVgzeNv8WoNNIaiCRmRu3C9CkZhKQ6w5A1wAAwEu+vtejKrvp+vGWfiYICQ7wrQ+ wCVFtHWy+B1GJeCRFVy/CI0Bw2uxrM9GkrQhNu69RYHOk8ZTZqWPrWLeQyd1gPBA+2IQ AllWtnGEG2sD9sR5xLHUvVbJCwdW9LNguh0JsMbTrnyvUHweh3K7g4LNEH8Hp7HsZphd GEumzthqjT32nfKXFS0QsHALksqzegYUqeV7v6XjA2z2ZeOIdnmV95kLkpAOmnc3ckyw Bdt2+pbYpfea5V9h1cuIoITwlMjBn8bo+5CWP7Hj/2mABjJ/NGPEd15g/9W8w9wxT+ye 3Q6g== Received: by 10.205.118.138 with SMTP id fq10mr6748789bkc.58.1344961539433; Tue, 14 Aug 2012 09:25:39 -0700 (PDT) Received: from localhost.localdomain (95-89-78-76-dynip.superkabel.de. [95.89.78.76]) by mx.google.com with ESMTPS id t23sm1470660bks.4.2012.08.14.09.25.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 14 Aug 2012 09:25:36 -0700 (PDT) From: Sasha Levin To: torvalds@linux-foundation.org Date: Tue, 14 Aug 2012 18:24:41 +0200 Message-Id: <1344961490-4068-8-git-send-email-levinsasha928@gmail.com> In-Reply-To: <1344961490-4068-1-git-send-email-levinsasha928@gmail.com> References: <1344961490-4068-1-git-send-email-levinsasha928@gmail.com> X-RedHat-Spam-Score: -2.45 (BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.16 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Tue, 14 Aug 2012 14:21:01 -0400 Cc: snitzer@redhat.com, fweisbec@gmail.com, Trond.Myklebust@netapp.com, bfields@fieldses.org, paul.gortmaker@windriver.com, dm-devel@redhat.com, agk@redhat.com, aarcange@redhat.com, rds-devel@oss.oracle.com, eric.dumazet@gmail.com, venkat.x.venkatsubra@oracle.com, ccaulfie@redhat.com, mingo@elte.hu, dev@openvswitch.org, jesse@nicira.com, josh@joshtriplett.org, rostedt@goodmis.org, lw@cn.fujitsu.com, mathieu.desnoyers@efficios.com, Sasha Levin , axboe@kernel.dk, linux-nfs@vger.kernel.org, edumazet@google.com, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ejt@redhat.com, ebiederm@xmission.com, tj@kernel.org, teigland@redhat.com, akpm@linux-foundation.org, davem@davemloft.net Subject: [dm-devel] [PATCH 07/16] net,9p: use new hashtable implementation X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Switch 9p error table to use the new hashtable implementation. This reduces the amount of generic unrelated code in 9p. Signed-off-by: Sasha Levin --- net/9p/error.c | 21 ++++++++++----------- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/net/9p/error.c b/net/9p/error.c index 2ab2de7..a5cc7dd 100644 --- a/net/9p/error.c +++ b/net/9p/error.c @@ -34,7 +34,7 @@ #include #include #include - +#include /** * struct errormap - map string errors from Plan 9 to Linux numeric ids * @name: string sent over 9P @@ -50,8 +50,8 @@ struct errormap { struct hlist_node list; }; -#define ERRHASHSZ 32 -static struct hlist_head hash_errmap[ERRHASHSZ]; +#define ERR_HASH_BITS 5 +static DEFINE_HASHTABLE(hash_errmap, ERR_HASH_BITS); /* FixMe - reduce to a reasonable size */ static struct errormap errmap[] = { @@ -193,18 +193,17 @@ static struct errormap errmap[] = { int p9_error_init(void) { struct errormap *c; - int bucket; + u32 hash; /* initialize hash table */ - for (bucket = 0; bucket < ERRHASHSZ; bucket++) - INIT_HLIST_HEAD(&hash_errmap[bucket]); + hash_init(hash_errmap); /* load initial error map into hash table */ for (c = errmap; c->name != NULL; c++) { c->namelen = strlen(c->name); - bucket = jhash(c->name, c->namelen, 0) % ERRHASHSZ; + hash = jhash(c->name, c->namelen, 0); INIT_HLIST_NODE(&c->list); - hlist_add_head(&c->list, &hash_errmap[bucket]); + hash_add(hash_errmap, &c->list, hash); } return 1; @@ -223,13 +222,13 @@ int p9_errstr2errno(char *errstr, int len) int errno; struct hlist_node *p; struct errormap *c; - int bucket; + u32 hash; errno = 0; p = NULL; c = NULL; - bucket = jhash(errstr, len, 0) % ERRHASHSZ; - hlist_for_each_entry(c, p, &hash_errmap[bucket], list) { + hash = jhash(errstr, len, 0); + hash_for_each_possible(hash_errmap, c, p, list, hash) { if (c->namelen == len && !memcmp(c->name, errstr, len)) { errno = c->val; break;