From patchwork Mon Oct 15 20:08:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Overstreet X-Patchwork-Id: 1595741 Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by patchwork1.kernel.org (Postfix) with ESMTP id D5DB03FD86 for ; Mon, 15 Oct 2012 20:14:03 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKBFRI010302; Mon, 15 Oct 2012 16:11:16 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKAO5Z027028 for ; Mon, 15 Oct 2012 16:10:24 -0400 Received: from mx1.redhat.com (ext-mx15.extmail.prod.ext.phx2.redhat.com [10.5.110.20]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKADFJ008411 for ; Mon, 15 Oct 2012 16:10:19 -0400 Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FK9l1N021824 for ; Mon, 15 Oct 2012 16:10:13 -0400 Received: by mail-pb0-f46.google.com with SMTP id rr4so5284665pbb.33 for ; Mon, 15 Oct 2012 13:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=cLAcPPZ8JEj4MK+CJ/OII1IoaDwbG6qGUGXX9HCPdKI=; b=brHbK+34SPjMQUYERTCuJGGrNNVGGTYK/G50P4UC7vFY0SnwLAhdzUm8sZzZmKwquR HLpOF34GCvI6o7aRC1QzCZtWLhtJHW93IVGgADv0ZmZrSF8MZzOsxCYI6WujOgUpK3KJ sLd8ng5/foa4Jtv/etbEcBYlJTj/abJy7OsfZOM1PcJh/HRqsr8tSZQU660/5tjvL7Xe X17DIS91l4wnUyk4cWw5DxZN6aoyjN0MLeCBl8pEMSOMzAt7omXIa/AxhqSQWzLLozgc fVFnmhMSDkVT6iF2yJBf6geudNdyekDpN9wyqRLbH7V7eU1joXbHF5VSKXnZa4f51z9H U2Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=cLAcPPZ8JEj4MK+CJ/OII1IoaDwbG6qGUGXX9HCPdKI=; b=iyzHoBEKIOhbhMs6I/G99qQ4ziE5snFCJJFmj31rDQ69GM28AEJV3iHn8MeIt53kOY G58+Z6QYHIDZjXvbBXsBu4Wnl2DFaACBYwcLJebSmrYpHZV3JnuEvbDszxRV/PGZbjc2 yquH2AzzryQOy0jQdL4F94kA0cUEUk+ed0UgN4GfDqhV5Y3DkG06b0JOVeIn/6E4fvPv 5bYlwxQqHNg36sXj518c2abwEZvwegsSyH/0F7pF6DymfQuD7r+JX4GwjAb8ut1vfqpa kwwwO1ACOuxdbOf1cnYN4WFw+M9zq71Kd0n4vdkS2RznChN/V6CUmwqxZjBAZ0ndfbBU R5GQ== Received: by 10.66.77.199 with SMTP id u7mr35772899paw.7.1350331813004; Mon, 15 Oct 2012 13:10:13 -0700 (PDT) Received: from formenos.mtv.corp.google.com (formenos.mtv.corp.google.com [172.18.110.66]) by mx.google.com with ESMTPS id k9sm3021703paz.22.2012.10.15.13.10.11 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 13:10:12 -0700 (PDT) From: Kent Overstreet To: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com Date: Mon, 15 Oct 2012 13:08:51 -0700 Message-Id: <1350331769-14856-18-git-send-email-koverstreet@google.com> In-Reply-To: <1350331769-14856-1-git-send-email-koverstreet@google.com> References: <1350331769-14856-1-git-send-email-koverstreet@google.com> X-Gm-Message-State: ALoCoQlEdvGDMPuCkgrkz9yC+IOYWBWJlI/BHXqimQKdG+RdgFzdvDYVWxKwAO/U0YZ55KMkDNHiFEEob4uE7TeyUXMTwgYdVUFJikQVSkly9ulrDTxUz358cvjQyI45kMnwr2906PLvmYfs74AECyrQM0AkuVvEx5bcEnBuonjdsceiFcbc4J4j0Xlf83eSF2RyHKSsioFd X-RedHat-Spam-Score: -3.072 (BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.20 X-loop: dm-devel@redhat.com Cc: tj@kernel.org, axboe@kernel.dk, Kent Overstreet , vgoyal@redhat.com Subject: [dm-devel] [PATCH v4 17/24] raid1: use bio_copy_data() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com This doesn't really delete any code _yet_, but once immutable bvecs are done we can just delete the rest of the code in that loop. Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown --- drivers/md/raid1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index af39f74..1c40d90 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1895,10 +1895,9 @@ static int process_checks(struct r1bio *r1_bio) else bi->bv_len = size; size -= PAGE_SIZE; - memcpy(page_address(bi->bv_page), - page_address(pbio->bi_io_vec[j].bv_page), - PAGE_SIZE); } + + bio_copy_data(sbio, pbio); } return 0; }