From patchwork Mon Oct 15 20:09:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Overstreet X-Patchwork-Id: 1595991 Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) by patchwork1.kernel.org (Postfix) with ESMTP id 470AD3FD86 for ; Mon, 15 Oct 2012 20:14:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKBQ5b010423; Mon, 15 Oct 2012 16:11:26 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKAwfU027308 for ; Mon, 15 Oct 2012 16:10:58 -0400 Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKAqen008578 for ; Mon, 15 Oct 2012 16:10:52 -0400 Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FK9j4b018962 for ; Mon, 15 Oct 2012 16:10:52 -0400 Received: by mail-pa0-f46.google.com with SMTP id hz1so5214154pad.33 for ; Mon, 15 Oct 2012 13:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=O9p0s5Gq0YwX/XI1VDlR0FFqJd/2vIuJ1RYPTRGI24w=; b=LRHN2DfkWsmNm5wJSkTe5PnsWSs20vnkiMofnRLL+o9qvNXS2Et96KcpjqQgCw08sc 5UE0ODJhM93cFFvMkIWjZR3n35SA86keSiiAz2KM2EHLOgA7cE/4zhGD9eqUTj1Z1S0x +aCmYxO6NLUDYCSBvoe8u8cjfctjjLiguz+TcjmQi9oceWlmEaEIgc5q7cNQ4iqMxn5k S/hKnCG+2MdZCSfhDot58t3VjgO9Qk0n/u/tnLvfGcRi3+DiLCuXBIkE1itxHzfth5W6 IUjWm/qJwGYvc3Oa3mif9fkw/cKA74GJAlO3dNL1b4CPV6r1MmXi6AA0gtGUrYQzxD6/ HVvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=O9p0s5Gq0YwX/XI1VDlR0FFqJd/2vIuJ1RYPTRGI24w=; b=ASv9pcjooyENihMWmvYRwP4f9eNW6AFwwTP7UwBg7Z6LQx3u8QFNN787UdU/2yBUxp /NXtHx0sMmBBRu0daG0Xv/34buaVWFiQSxeUj8AFXWSOY8ZHWi9r/jidyAMXR8BTocvX kFkXIwV9/LU/PVtxhEAJC6okPud06YDPwLaQkNuNZ4WtW3QSvqnaG9/MdwCeGU8jK061 xR0qopa02ZZyFijV4oeeOVKzBxIw4DlIJoXLHQnKgndSi9Ykd/hYlsTOhhO4eqIexsy4 2UcoJZhmO5LIR4YnIzrQ47B+9w2VRA5UEpl3jHfnXai4TxzWQ/AUQFgDR+ZwayLuTg2O ysQQ== Received: by 10.68.224.161 with SMTP id rd1mr41088631pbc.49.1350331852069; Mon, 15 Oct 2012 13:10:52 -0700 (PDT) Received: from formenos.mtv.corp.google.com (formenos.mtv.corp.google.com [172.18.110.66]) by mx.google.com with ESMTPS id k9sm3021703paz.22.2012.10.15.13.10.50 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 13:10:51 -0700 (PDT) From: Kent Overstreet To: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com Date: Mon, 15 Oct 2012 13:09:21 -0700 Message-Id: <1350331769-14856-48-git-send-email-koverstreet@google.com> In-Reply-To: <1350331769-14856-1-git-send-email-koverstreet@google.com> References: <1350331769-14856-1-git-send-email-koverstreet@google.com> X-Gm-Message-State: ALoCoQnm+Se9U41DU9w4TQbvIVACCpo1qPTkQ79UvOUrkak+JMWLD0bXcJBjtgvmv7lpFCebWIFBucd3hH5cik/JoSra3gU0/I3PZqlLQOWUVtOAXxgrJsLqYJybrRKOtOjbfyiFvtJLmobUzFrbgx+Qw2L91Uskk0/Lv595I+OevFMiWGRw5SXyi92zYw/J3dcPpIuhfwDC X-RedHat-Spam-Score: -3.072 (BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.21 X-loop: dm-devel@redhat.com Cc: tj@kernel.org, axboe@kernel.dk, Kent Overstreet Subject: [dm-devel] [PATCH v2 18/26] raid1: use bio_copy_data() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com This doesn't really delete any code _yet_, but once immutable bvecs are done we can just delete the rest of the code in that loop. Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown --- drivers/md/raid1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index b1072da..6cd1fb2 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1895,10 +1895,9 @@ static int process_checks(struct r1bio *r1_bio) else bi->bv_len = size; size -= PAGE_SIZE; - memcpy(page_address(bi->bv_page), - page_address(pbio->bi_io_vec[j].bv_page), - PAGE_SIZE); } + + bio_copy_data(sbio, pbio); } return 0; }