From patchwork Mon Oct 15 20:09:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Overstreet X-Patchwork-Id: 1595901 Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by patchwork2.kernel.org (Postfix) with ESMTP id DDBF1DFB34 for ; Mon, 15 Oct 2012 20:14:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKBRwZ006966; Mon, 15 Oct 2012 16:11:27 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9FKB7Hx027377 for ; Mon, 15 Oct 2012 16:11:07 -0400 Received: from mx1.redhat.com (ext-mx14.extmail.prod.ext.phx2.redhat.com [10.5.110.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9FKB1SZ024079 for ; Mon, 15 Oct 2012 16:11:02 -0400 Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9FK9qeg013584 for ; Mon, 15 Oct 2012 16:11:01 -0400 Received: by mail-pa0-f46.google.com with SMTP id hz1so5214261pad.33 for ; Mon, 15 Oct 2012 13:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=SLv2DZEO/hcyD9ywEKdWprBAHEHDbj/1Og4sHripSQo=; b=cS0p5b5A7+z/ciZggj1zXJfdBPVOGwuOPrCYB49W6LtThBuytAwz2ZpPjEaagZbWGd C4JIJdtuMB9xZ9PeY5WWrDRtrDR1nprRYoUKrtmykJwPccPk15HYBNhygH5rJl7NsK96 pXmkqL78wym+z0ich0rbWEpasSmCph06jN3jBarSKSUn2nsTtIUyReomStlp/lAitaId lt13kRzz699iQb6cZeTLxQSEgnurfkFSz2UAyWpZ7Wp22Oj+KW+e6zkPFblcdME1eywl May4LbwGq10R4naRNUQiK6IFA5PABNd01sk6hJzxydEOG1dchGxKMtGdkrfYAeTSlGbF UTEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=SLv2DZEO/hcyD9ywEKdWprBAHEHDbj/1Og4sHripSQo=; b=IqnI7Wecn31PZzCMil/BOGwMJEwFOmFPXIeLNmQNUXsqzwBUh2NgxTiQACxZy58xeL NiRpwTiAmKZRj6cCx6ymcMa1EqKfOUUl2qjkIBd1OX4l6PPFN2BtKm7f4phW9UxD8qfH 8jWRdfObV0EemN5DyDu81j3dIzcUVr1+N/F6vfpF85HVEHxp6gozsy5K+CR4Use6EF1s kUvQYUtGytrdXM0x4rzva7zPZwB2TZazVkwcsaAOrZh9DgpbA6wOyNfFElk+hYaRSfPX Yjq1eIU4S6KQsuB/BavUeJecUWRf+X6yzcY0IjZd8e2WaXYIvbINWdEPNJKFEddvF1gH 4qFg== Received: by 10.68.130.198 with SMTP id og6mr40056590pbb.163.1350331861248; Mon, 15 Oct 2012 13:11:01 -0700 (PDT) Received: from formenos.mtv.corp.google.com (formenos.mtv.corp.google.com [172.18.110.66]) by mx.google.com with ESMTPS id k9sm3021703paz.22.2012.10.15.13.10.59 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Oct 2012 13:10:59 -0700 (PDT) From: Kent Overstreet To: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com Date: Mon, 15 Oct 2012 13:09:27 -0700 Message-Id: <1350331769-14856-54-git-send-email-koverstreet@google.com> In-Reply-To: <1350331769-14856-1-git-send-email-koverstreet@google.com> References: <1350331769-14856-1-git-send-email-koverstreet@google.com> X-Gm-Message-State: ALoCoQm6Uo5Wq9BtA9kxH82GDZKftL0OAFGZLq4lFyydw3mhIoO7M+pzDuTw59NeGxUIjSrTbHbmbVCyy0AXglo76H7jrtDhlxrDf69OhBezDK75AJMspuSf8WCSXnfu+fE/IHXOfmDIzfdm28508bkvBtgRgajBISsZQGRIfw+Qo6jlSpwK2bBVSMPxK1SL9RmJe7Lb0afW X-RedHat-Spam-Score: -3.072 (BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.19 X-loop: dm-devel@redhat.com Cc: tj@kernel.org, axboe@kernel.dk, Kent Overstreet Subject: [dm-devel] [PATCH v2 24/26] block: Add an explicit bio flag for bios that own their bvec X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com This is for the new bio splitting code. When we split a bio, if the split occured on a bvec boundry we reuse the bvec for the new bio. But that means bio_free() can't free it, hence the explicit flag. Signed-off-by: Kent Overstreet CC: Jens Axboe Acked-by: Tejun Heo --- fs/bio.c | 4 +++- include/linux/bio.h | 5 ----- include/linux/blk_types.h | 1 + 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/bio.c b/fs/bio.c index 65e6eac..5e91e36 100644 --- a/fs/bio.c +++ b/fs/bio.c @@ -250,7 +250,7 @@ static void bio_free(struct bio *bio) __bio_free(bio); if (bs) { - if (bio_has_allocated_vec(bio)) + if (bio_flagged(bio, BIO_OWNS_VEC)) bvec_free_bs(bs, bio->bi_io_vec, BIO_POOL_IDX(bio)); /* @@ -449,6 +449,8 @@ struct bio *bio_alloc_bioset(gfp_t gfp_mask, int nr_iovecs, struct bio_set *bs) if (unlikely(!bvl)) goto err_free; + + bio->bi_flags |= 1 << BIO_OWNS_VEC; } else if (nr_iovecs) { bvl = bio->bi_inline_vecs; } diff --git a/include/linux/bio.h b/include/linux/bio.h index bd45154..edd66f3 100644 --- a/include/linux/bio.h +++ b/include/linux/bio.h @@ -85,11 +85,6 @@ static inline void *bio_data(struct bio *bio) return NULL; } -static inline int bio_has_allocated_vec(struct bio *bio) -{ - return bio->bi_io_vec && bio->bi_io_vec != bio->bi_inline_vecs; -} - /* * will die */ diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 3eefbb2..e9375cf 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -117,6 +117,7 @@ struct bio { * BIO_POOL_IDX() */ #define BIO_RESET_BITS 12 +#define BIO_OWNS_VEC 12 /* bio_free() should free bvec */ #define bio_flagged(bio, flag) ((bio)->bi_flags & (1 << (flag)))