From patchwork Tue Jan 8 13:54:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 1946011 Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by patchwork2.kernel.org (Postfix) with ESMTP id 34FBADF23A for ; Tue, 8 Jan 2013 13:57:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r08DtrO8019879; Tue, 8 Jan 2013 08:55:53 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r08DsYgI004709 for ; Tue, 8 Jan 2013 08:54:35 -0500 Received: from mx1.redhat.com (ext-mx15.extmail.prod.ext.phx2.redhat.com [10.5.110.20]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r08DsYBR005114 for ; Tue, 8 Jan 2013 08:54:34 -0500 Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r08DsXpf018844 for ; Tue, 8 Jan 2013 08:54:34 -0500 Received: from relay2.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 22145A522E; Tue, 8 Jan 2013 14:54:30 +0100 (CET) From: Hannes Reinecke To: Christophe Varoqui Date: Tue, 8 Jan 2013 14:54:17 +0100 Message-Id: <1357653259-62650-40-git-send-email-hare@suse.de> In-Reply-To: <1357653259-62650-1-git-send-email-hare@suse.de> References: <1357653259-62650-1-git-send-email-hare@suse.de> X-RedHat-Spam-Score: -7.299 (BAYES_00, DCC_REPUT_00_12, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.20 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com Subject: [dm-devel] [PATCH 40/42] multipathd: sighandlers might use uninitialized gvecs X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com gvecs are initialized after signal handlers, which in turn might access the vectors. So the signal handlers might access uninitialized variables. Signed-off-by: Hannes Reinecke --- multipathd/main.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/multipathd/main.c b/multipathd/main.c index 3a6e88f..f491a24 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1617,14 +1617,14 @@ child (void * param) } - signal_init(); - setscheduler(); - set_oom_adj(); vecs = gvecs = init_vecs(); - if (!vecs) exit(1); + signal_init(); + setscheduler(); + set_oom_adj(); + conf->daemon = 1; udev_set_sync_support(0); /*