diff mbox

[17/24] dm cache: use a boolean when setting cache->quiescing

Message ID 1382639437-27007-18-git-send-email-snitzer@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Mike Snitzer
Headers show

Commit Message

Mike Snitzer Oct. 24, 2013, 6:30 p.m. UTC 
From: Heinz Mauelshagen <heinzm@redhat.com>

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
 drivers/md/dm-cache-target.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alasdair G Kergon Nov. 6, 2013, 3:02 p.m. UTC | #1 
On Thu, Oct 24, 2013 at 02:30:30PM -0400, Mike Snitzer wrote:
> From: Heinz Mauelshagen <heinzm@redhat.com>
> 
> Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>

Please could we drop this one?

It looks pointless to me, with this one following:
  dm cache: improve effciency of quiescing flag management

Alasdair

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Mike Snitzer Nov. 6, 2013, 3:25 p.m. UTC | #2 
On Wed, Nov 06 2013 at 10:02am -0500,
Alasdair G Kergon <agk@redhat.com> wrote:

> On Thu, Oct 24, 2013 at 02:30:30PM -0400, Mike Snitzer wrote:
> > From: Heinz Mauelshagen <heinzm@redhat.com>
> > 
> > Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> 
> Please could we drop this one?
> 
> It looks pointless to me, with this one following:
>   dm cache: improve effciency of quiescing flag management

It was just a change for consistency that happened during the natural
flow of development.  Really didn't see a problem with preserving the
evolution of the code...

But sure, I can drop it.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index afeda1b..f999ddd 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -1448,7 +1448,7 @@  static void start_quiescing(struct cache *cache)
 	unsigned long flags;
 
 	spin_lock_irqsave(&cache->lock, flags);
-	cache->quiescing = 1;
+	cache->quiescing = true;
 	spin_unlock_irqrestore(&cache->lock, flags);
 }
 
@@ -1457,7 +1457,7 @@  static void stop_quiescing(struct cache *cache)
 	unsigned long flags;
 
 	spin_lock_irqsave(&cache->lock, flags);
-	cache->quiescing = 0;
+	cache->quiescing = false;
 	spin_unlock_irqrestore(&cache->lock, flags);
 }