| Message ID | 1382639437-27007-2-git-send-email-snitzer@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
> --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -371,27 +371,12 @@ config DM_MULTIPATH_ST > -config DM_DELAY > - tristate "I/O delaying target" > +config DM_DELAY > + tristate "I/O delaying target (EXPERIMENTAL)" Why has EXPERIMENTAL reappeared??? See d57916a00fd749ccd354a7f754c2aba98f86d064 Please regenerate these patches against an up-to-date upstream base! Thanks, Alasdair -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Thu, Oct 24, 2013 at 02:30:14PM -0400, Mike Snitzer wrote: > Both the flakey and delay targets are generally used for testing. ^^^^^^^^^ Indeed - not exclusively. > --- a/drivers/md/Kconfig > +config DM_TEST_TARGETS > + Targets that are only useful for testing. Could we delete the word 'only'? Or replace it with something like 'primarily'? (I don't like this classification for DM_DELAY: I think it can have uses in non-testing scenarios.) Alasdair -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Thu, Oct 24 2013 at 7:17pm -0400, Alasdair G Kergon <agk@redhat.com> wrote: > > --- a/drivers/md/Kconfig > > +++ b/drivers/md/Kconfig > > @@ -371,27 +371,12 @@ config DM_MULTIPATH_ST > > > -config DM_DELAY > > - tristate "I/O delaying target" > > > +config DM_DELAY > > + tristate "I/O delaying target (EXPERIMENTAL)" > > Why has EXPERIMENTAL reappeared??? > See d57916a00fd749ccd354a7f754c2aba98f86d064 > > Please regenerate these patches against an up-to-date upstream base! The base for these patches is v3.12-rc5, certainly recent enough. What you took issue with here has nothing to do with an older base being used for the patches. It has everything to do with Joe having made this change in his thin-dev branch quite a while ago -- when I rebased I didn't change the text the patch moved. Will remove the EXPERIMENTALs. As for delay being useful for non-test use-cases, that may be but classifying it as a target that is used for testing is fair (hence "Useful for testing." in the DM_DELAY help text). That said, if you'd really prefer DM_DELAY not be nested under DM_TEST_TARGETS I can revert it. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Fri, Oct 25, 2013 at 03:25:56PM -0400, Mike Snitzer wrote: > As for delay being useful for non-test use-cases, that may be but > classifying it as a target that is used for testing is fair (hence > "Useful for testing." in the DM_DELAY help text). That said, if you'd > really prefer DM_DELAY not be nested under DM_TEST_TARGETS I can revert > it. I'm not objecting to its inclusion with the TEST TARGETS, as that remains the primary use of it, but with the statement that the target is then meant only for testing. Alasdair -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig index 30b426e..816e023 100644 --- a/drivers/md/Kconfig +++ b/drivers/md/Kconfig @@ -371,27 +371,12 @@ config DM_MULTIPATH_ST If unsure, say N. -config DM_DELAY - tristate "I/O delaying target" - depends on BLK_DEV_DM - ---help--- - A target that delays reads and/or writes and can send - them to different devices. Useful for testing. - - If unsure, say N. - config DM_UEVENT bool "DM uevents" depends on BLK_DEV_DM ---help--- Generate udev events for DM events. -config DM_FLAKEY - tristate "Flakey target" - depends on BLK_DEV_DM - ---help--- - A target that intermittently fails I/O for debugging purposes. - config DM_VERITY tristate "Verity target support" depends on BLK_DEV_DM @@ -426,4 +411,25 @@ config DM_SWITCH If unsure, say N. +config DM_TEST_TARGETS + bool "DM test targets" + depends on BLK_DEV_DM + ---help--- + Targets that are only useful for testing. + +config DM_FLAKEY + tristate "Flakey target (EXPERIMENTAL)" + depends on DM_TEST_TARGETS + ---help--- + A target that intermittently fails I/O for debugging purposes. + +config DM_DELAY + tristate "I/O delaying target (EXPERIMENTAL)" + depends on DM_TEST_TARGETS + ---help--- + A target that delays reads and/or writes and can send + them to different devices. Useful for testing. + + If unsure, say N. + endif # MD