From patchwork Wed Dec 11 06:43:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Marzinski X-Patchwork-Id: 3322571 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2B7ED9F37C for ; Wed, 11 Dec 2013 06:47:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 34D8E20749 for ; Wed, 11 Dec 2013 06:47:05 +0000 (UTC) Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by mail.kernel.org (Postfix) with ESMTP id 254AB20396 for ; Wed, 11 Dec 2013 06:47:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBB6hw6u017720; Wed, 11 Dec 2013 01:43:58 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBB6hbOg021195 for ; Wed, 11 Dec 2013 01:43:37 -0500 Received: from dhcp80-209.msp.redhat.com (octiron.msp.redhat.com [10.15.80.209]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBB6hb5I028019 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 11 Dec 2013 01:43:37 -0500 Received: from dhcp80-209.msp.redhat.com (localhost [127.0.0.1]) by dhcp80-209.msp.redhat.com (8.14.7/8.14.7) with ESMTP id rBB6has4001380; Wed, 11 Dec 2013 00:43:36 -0600 Received: (from bmarzins@localhost) by dhcp80-209.msp.redhat.com (8.14.7/8.14.7/Submit) id rBB6hZNm001379; Wed, 11 Dec 2013 00:43:35 -0600 From: Benjamin Marzinski To: device-mapper development Date: Wed, 11 Dec 2013 00:43:05 -0600 Message-Id: <1386744190-1295-12-git-send-email-bmarzins@redhat.com> In-Reply-To: <1386744190-1295-1-git-send-email-bmarzins@redhat.com> References: <1386744190-1295-1-git-send-email-bmarzins@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-loop: dm-devel@redhat.com Cc: Christophe Varoqui Subject: [dm-devel] [PATCH 11/16] libmultipath: show default configurations X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP "multipathd show config" should show the current configuration, even if the current values match the default values. Omitting the values when they match the compiled in defaults just makes it harder for users to see how multipath configured. Signed-off-by: Benjamin Marzinski --- libmultipath/dict.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libmultipath/dict.c b/libmultipath/dict.c index 0bf9587..9db4725 100644 --- a/libmultipath/dict.c +++ b/libmultipath/dict.c @@ -2459,16 +2459,12 @@ snprint_def_verbosity (char * buff, int len, void * data) static int snprint_def_max_polling_interval (char * buff, int len, void * data) { - if (conf->max_checkint == MAX_CHECKINT(conf->checkint)) - return 0; return snprintf(buff, len, "%i", conf->max_checkint); } static int snprint_reassign_maps (char * buff, int len, void * data) { - if (conf->reassign_maps == DEFAULT_REASSIGN_MAPS) - return 0; return snprintf(buff, len, "\"%s\"", conf->reassign_maps?"yes":"no"); }