From patchwork Tue Jan 13 03:30:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 5617561 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E88679F3A0 for ; Tue, 13 Jan 2015 03:35:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D0EF320504 for ; Tue, 13 Jan 2015 03:35:46 +0000 (UTC) Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com [209.132.183.39]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC487203C4 for ; Tue, 13 Jan 2015 03:35:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0D3UXgH023049; Mon, 12 Jan 2015 22:30:34 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t0D3UVoK030275 for ; Mon, 12 Jan 2015 22:30:31 -0500 Received: from mx1.redhat.com (ext-mx14.extmail.prod.ext.phx2.redhat.com [10.5.110.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0D3UVre002521; Mon, 12 Jan 2015 22:30:31 -0500 Received: from mail-ig0-f172.google.com (mail-ig0-f172.google.com [209.85.213.172]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0D3UTPc032473 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL); Mon, 12 Jan 2015 22:30:29 -0500 Received: by mail-ig0-f172.google.com with SMTP id l13so2004104iga.5; Mon, 12 Jan 2015 19:30:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=GHzQw5uX88YYljJkDpeo7TIK3z41O89LtdBHffhDsPE=; b=sGSxgLhsc5WXMd8z9VZGSRU8YoFlOAg0GEBI8RkkmwUHcXzoBg0nLRMmsSd3fD/8zz x88e/8OvUOS7eMK9DkTE1h64fV2hRAcNumL8wxmD9UPR2hImLRXi6GIPXogA4sOW3nvk /oPKFvfqb6BF4nGCtT0fAFg+O8MtCvBEdMf3/alBiN/4VQRynAi5B9Uy0RocTsLoNyrC arSEcEudkzv+RDkciHslN8ObOn5pcD9RVubpTIUBptw1e48qtZOyDle2qaBnPS42QT+W XU0UJmv33PDjmyZb10ywEThPmNczAiGkAO/o0B9oirlRvHUgpUQQ7cJAkLxqcpaXx/yV BckA== X-Received: by 10.43.144.9 with SMTP id jo9mr4686243icc.74.1421119828665; Mon, 12 Jan 2015 19:30:28 -0800 (PST) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.231.92.7]) by mx.google.com with ESMTPSA id ij7sm5427137igb.11.2015.01.12.19.30.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Jan 2015 19:30:27 -0800 (PST) From: Nicholas Krause To: agk@redhat.com Date: Mon, 12 Jan 2015 22:30:23 -0500 Message-Id: <1421119823-5864-1-git-send-email-xerofoify@gmail.com> X-RedHat-Spam-Score: -2.7 (BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS) 209.85.213.172 mail-ig0-f172.google.com 209.85.213.172 mail-ig0-f172.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.19 X-loop: dm-devel@redhat.com Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, snitzer@redhat.com Subject: [dm-devel] [PATCH] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Removes the no longer needed fix me comment questioning if we need to remove the structure pointer,rh as defined as a structure of type dsm_region_hash from the definition of the structure, dm_region. Furthermore this pointer is needed in order for various functions to run and build successfully in the file, dm-region-hash.c. Signed-off-by: Nicholas Krause --- drivers/md/dm-region-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-region-hash.c b/drivers/md/dm-region-hash.c index b929fd5..823d56f 100644 --- a/drivers/md/dm-region-hash.c +++ b/drivers/md/dm-region-hash.c @@ -99,7 +99,7 @@ struct dm_region_hash { }; struct dm_region { - struct dm_region_hash *rh; /* FIXME: can we get rid of this ? */ + struct dm_region_hash *rh; region_t key; int state;