From patchwork Sat Jan 31 05:36:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick X-Patchwork-Id: 5753951 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 33AE7BF440 for ; Sat, 31 Jan 2015 05:52:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72056201EF for ; Sat, 31 Jan 2015 05:52:01 +0000 (UTC) Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00A1E20109 for ; Sat, 31 Jan 2015 05:51:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t0V5lIGK003733; Sat, 31 Jan 2015 00:47:19 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t0V5anh8013213 for ; Sat, 31 Jan 2015 00:36:49 -0500 Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.16]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0V5anxX013315; Sat, 31 Jan 2015 00:36:49 -0500 Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com [209.85.223.181]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0V5amqN020874 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL); Sat, 31 Jan 2015 00:36:48 -0500 Received: by mail-ie0-f181.google.com with SMTP id rp18so7871545iec.12; Fri, 30 Jan 2015 21:36:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=KnCuVU6YfOpkwWpki3h1kA3LEcMSzrJTdFcjkGhvftg=; b=Sq8sL01LSD3ynL/HjxVxx1i/ynM0AYZ8O5rdjrbySDyLw1/niQ5RuJChwaC0vu8r+D +EUOml4m1TrAKK5yvs6izezhXlZEum7qXZMm3AkTe9jv2pxX8ngQ2QMAdcQ4HqFEmohp ND0Tt3JtkrUAYgcK5AJhI14b6cnWUYWATLUKcvKy76B/0ha47+huSP0Wm2QGK/MdD0hW hj4+WL3gRAbYz4N91wruDx1jO71dzxGtRZg1E8Du9XwnzZS3E6pShsEWfMlPTedafyz9 OD5LstpGKvyTubKkQTb/8qcVxM78K1XxGTvYPP2+WuIkI1WLJ6vB1hpcBsYJCGd+nCCG GPlQ== X-Received: by 10.50.97.41 with SMTP id dx9mr732692igb.1.1422682607713; Fri, 30 Jan 2015 21:36:47 -0800 (PST) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.231.92.7]) by mx.google.com with ESMTPSA id f1sm2327588igt.14.2015.01.30.21.36.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Jan 2015 21:36:46 -0800 (PST) From: Nicholas Krause To: agk@redhat.com Date: Sat, 31 Jan 2015 00:36:42 -0500 Message-Id: <1422682602-5856-1-git-send-email-xerofoify@gmail.com> X-RedHat-Spam-Score: -2.7 (BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS) 209.85.223.181 mail-ie0-f181.google.com 209.85.223.181 mail-ie0-f181.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.16 X-loop: dm-devel@redhat.com Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, snitzer@redhat.com Subject: [dm-devel] [PATCH] md:Remove unneeded fixme comment for the function, pool_ctr X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Removes the no longer needed fix me comment for removing the validation check for the number of agruments passed by the caller to outside the mutex_lock in the function,pool_ctr. This comment is no longer needed as we will clearly jump to the out_lock block of this function if the validation fails and therefore this is no real concern for holding the mutex lock longer then required if the validation check for number of agruments from the caller of fails. Signed-off-by: Nicholas Krause --- drivers/md/dm-thin.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 07705ee..7d22334 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -2849,9 +2849,6 @@ static int pool_ctr(struct dm_target *ti, unsigned argc, char **argv) struct dm_dev *metadata_dev; fmode_t metadata_mode; - /* - * FIXME Remove validation from scope of lock. - */ mutex_lock(&dm_thin_pool_table.mutex); if (argc < 4) {