From patchwork Sat Apr 18 22:07:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 6237801 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 52F539F1C4 for ; Sat, 18 Apr 2015 22:12:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 73AD5203A5 for ; Sat, 18 Apr 2015 22:12:38 +0000 (UTC) Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88B46203A4 for ; Sat, 18 Apr 2015 22:12:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3IM7UX3053849; Sat, 18 Apr 2015 18:07:31 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t3IM7SLA007448 for ; Sat, 18 Apr 2015 18:07:28 -0400 Received: from mx1.redhat.com (ext-mx15.extmail.prod.ext.phx2.redhat.com [10.5.110.20]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3IM7S5U008629 for ; Sat, 18 Apr 2015 18:07:28 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [195.130.132.53]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3IM7Pt4008820 for ; Sat, 18 Apr 2015 18:07:26 -0400 Received: from ayla.of.borg ([84.193.93.87]) by andre.telenet-ops.be with bizsmtp id Ha7P1q00V1t5w8s01a7PwZ; Sun, 19 Apr 2015 00:07:24 +0200 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from ) id 1YjatX-0003F5-E3; Sun, 19 Apr 2015 00:07:23 +0200 Received: from geert by ramsan with local (Exim 4.82) (envelope-from ) id 1Yjatg-0002DN-Nq; Sun, 19 Apr 2015 00:07:32 +0200 From: Geert Uytterhoeven To: Josef Bacik , Alasdair Kergon , Mike Snitzer Date: Sun, 19 Apr 2015 00:07:30 +0200 Message-Id: <1429394850-8480-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 X-RedHat-Spam-Score: -2.309 (BAYES_00, DCC_REPUT_00_12, RCVD_IN_DNSWL_NONE, URIBL_BLOCKED) 195.130.132.53 andre.telenet-ops.be 195.130.132.53 andre.telenet-ops.be X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Scanned-By: MIMEDefang 2.68 on 10.5.110.20 X-loop: dm-devel@redhat.com Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com, Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: [dm-devel] [PATCH] dm log: Use ULL suffix for 64-bit constants X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 32-bit: drivers/md/dm-log-writes.c: In function ‘log_super’: drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type drivers/md/dm-log-writes.c:323: warning: integer constant is too large for ‘long’ type Add a ULL suffix to WRITE_LOG_MAGIC to fix this. Also add a ULL suffix to WRITE_LOG_VERSION as it's stored in a __le64 field. Signed-off-by: Geert Uytterhoeven --- drivers/md/dm-log-writes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index 93e08446a87d06ff..ad1b049ae2ab80a9 100644 --- a/drivers/md/dm-log-writes.c +++ b/drivers/md/dm-log-writes.c @@ -55,8 +55,8 @@ #define LOG_DISCARD_FLAG (1 << 2) #define LOG_MARK_FLAG (1 << 3) -#define WRITE_LOG_VERSION 1 -#define WRITE_LOG_MAGIC 0x6a736677736872 +#define WRITE_LOG_VERSION 1ULL +#define WRITE_LOG_MAGIC 0x6a736677736872ULL /* * The disk format for this is braindead simple.