From patchwork Tue Aug 18 17:32:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Lin X-Patchwork-Id: 7032741 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AD9C8C05AC for ; Tue, 18 Aug 2015 17:37:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFF3F20595 for ; Tue, 18 Aug 2015 17:37:47 +0000 (UTC) Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0AA52054C for ; Tue, 18 Aug 2015 17:37:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t7IHXIp2008664; Tue, 18 Aug 2015 13:33:19 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id t7IHXIBR025646 for ; Tue, 18 Aug 2015 13:33:18 -0400 Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7IHXIbh004241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 18 Aug 2015 13:33:18 -0400 Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by mx1.redhat.com (Postfix) with ESMTP id 108D1A3030; Tue, 18 Aug 2015 17:33:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81D28203B8; Tue, 18 Aug 2015 17:33:15 +0000 (UTC) Received: from [192.168.88.6] (c-50-185-88-18.hsd1.ca.comcast.net [50.185.88.18]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3396C203DA; Tue, 18 Aug 2015 17:33:14 +0000 (UTC) Message-ID: <1439919178.28022.3.camel@ssi> From: Ming Lin To: Mike Snitzer Date: Tue, 18 Aug 2015 10:32:58 -0700 In-Reply-To: <20150818144505.GA15832@redhat.com> References: <20150801163356.GA21478@redhat.com> <1439099990.7880.0.camel@hasee> <20150809064128.GB2436@infradead.org> <1439103347.7880.3.camel@hasee> <20150809070128.GA25739@infradead.org> <1439104707.7880.8.camel@hasee> <20150810150216.GA22719@redhat.com> <20150818144505.GA15832@redhat.com> Mime-Version: 1.0 X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP X-RedHat-Spam-Score: -1.881 (BAYES_50, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD) 198.145.29.136 mail.kernel.org 198.145.29.136 mail.kernel.org X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Scanned-By: MIMEDefang 2.76 on 10.5.110.27 X-loop: dm-devel@redhat.com Cc: "Martin K. Petersen" , Joe Thornber , device-mapper@redhat.com, Christoph Hellwig , development , Kent@redhat.com, Overstreet Subject: Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2015-08-18 at 10:45 -0400, Mike Snitzer wrote: > On Tue, Aug 18 2015 at 3:04am -0400, > Ming Lin wrote: > > > On Mon, Aug 17, 2015 at 10:09 PM, Ming Lin wrote: > > > On Mon, Aug 10, 2015 at 8:02 AM, Mike Snitzer wrote: > > >> p.s. I'll be working with Joe Thornber on optimizing DM (particularly > > >> dm-thinp and dm-cache) once this patchset is included upstream. You'll > > >> see I've already added a couple WIP dm-thinp patches ontop. > > > > > > Hi Mike, > > > > > > Just to avoid duplicated work. > > > Are you going to work on the dm-thinp/dm-cache discard rewritten? > > > > Seems dm-stripe discard also needs rewrite. > > Can you elaborate on what you feel needs re-writing in these targets? dm-stripe also require discard size to be a multiple of chunk size. See output of below debug patch for 4G discard. root@bee:~# blkdiscard -o 0 -l 4294967296 /dev/striped_vol_group/striped_logical_volume root@bee:~# dmesg |grep DEBUG [ 13.110224] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes [ 13.113723] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes [ 13.117098] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes [ 13.120424] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes [ 13.123800] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes [ 13.127027] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes [ 13.130161] DEBUG: discard ignored: stripe chunk size 128K bytes, bio size 512 bytes > > This is the basic initial cleanup I had in mind for dm-thinp: > http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/commit/?h=dm-4.4&id=cb0aca0a6bfad6b7f7146dde776f374082a73db6 > > A much more involved refactoring of the dm-cache and dm-thinp targets to > eliminate the need for splitting will involve bio-prison range locking > and a new metadata format for both targets to express ranges as opposed > to blocks. This line of work is on Joe's radar but it is much further > out given the associated on-disk metadata format change. > > That aside, I do need to look at DM core to see how we can do things > differently so that block core's bio_split() et al is doing the > splitting rather than DM core having a role. > > I'd prefer to be the one working these DM changes. But if you have > ideas of how things should be cleaned up I'd be happy to consider them. > > Thanks, > Mike --- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel diff --git a/block/blk-lib.c b/block/blk-lib.c index bd40292..1cab2ba 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -82,7 +82,7 @@ int blkdev_issue_discard(struct block_device *bdev, sector_t sector, break; } - req_sects = min_t(sector_t, nr_sects, MAX_BIO_SECTORS); + req_sects = min_t(sector_t, nr_sects, UINT_MAX>>9); end_sect = sector + req_sects; bio->bi_iter.bi_sector = sector; diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c index 484029d..a288bc2 100644 --- a/drivers/md/dm-stripe.c +++ b/drivers/md/dm-stripe.c @@ -273,6 +273,8 @@ static int stripe_map_range(struct stripe_c *sc, struct bio *bio, return DM_MAPIO_REMAPPED; } else { /* The range doesn't map to the target stripe */ + printk("DEBUG: discard ignored: stripe chunk size %dK bytes, bio size %d bytes\n", + sc->chunk_size>>1, bio->bi_iter.bi_size); bio_endio(bio); return DM_MAPIO_SUBMITTED; }