diff mbox

[09/18] Make multipath deactivate devices before iscsi shutdown

Message ID 1444333491-16265-10-git-send-email-bmarzins@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: Benjamin Marzinski
Headers show

Commit Message

Benjamin Marzinski Oct. 8, 2015, 7:44 p.m. UTC
The multipath devices need to be deactivated before iscsi is shutdown,
otherwise the multipath devices will generate a lot of error messages
when it loses its iscsi path devices.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/multipathd.service | 1 +
 1 file changed, 1 insertion(+)

Comments

Hannes Reinecke Oct. 12, 2015, 7:05 a.m. UTC | #1
On 10/08/2015 09:44 PM, Benjamin Marzinski wrote:
> The multipath devices need to be deactivated before iscsi is shutdown,
> otherwise the multipath devices will generate a lot of error messages
> when it loses its iscsi path devices.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  multipathd/multipathd.service | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
> index b5b755b..fc2e009 100644
> --- a/multipathd/multipathd.service
> +++ b/multipathd/multipathd.service
> @@ -1,5 +1,6 @@
>  [Unit]
>  Description=Device-Mapper Multipath Device Controller
> +Requires=blk-availability.service
>  Before=iscsi.service iscsid.service lvm2-activation-early.service
>  Before=local-fs-pre.target
>  After=multipathd.socket
> 

This will limit multipath to run on root-on-iSCSI scenarios. You
cannot run multipath on non-iSCSI and have a non-root share on iSCSI
after this change.
Is that intended?

Cheers,

Hannes
Benjamin Marzinski Oct. 21, 2015, 10:29 p.m. UTC | #2
On Mon, Oct 12, 2015 at 09:05:07AM +0200, Hannes Reinecke wrote:
> On 10/08/2015 09:44 PM, Benjamin Marzinski wrote:
> > The multipath devices need to be deactivated before iscsi is shutdown,
> > otherwise the multipath devices will generate a lot of error messages
> > when it loses its iscsi path devices.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> > ---
> >  multipathd/multipathd.service | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
> > index b5b755b..fc2e009 100644
> > --- a/multipathd/multipathd.service
> > +++ b/multipathd/multipathd.service
> > @@ -1,5 +1,6 @@
> >  [Unit]
> >  Description=Device-Mapper Multipath Device Controller
> > +Requires=blk-availability.service
> >  Before=iscsi.service iscsid.service lvm2-activation-early.service
> >  Before=local-fs-pre.target
> >  After=multipathd.socket
> > 
> 
> This will limit multipath to run on root-on-iSCSI scenarios. You
> cannot run multipath on non-iSCSI and have a non-root share on iSCSI
> after this change.
> Is that intended?

Huh? This doesn't stop multipath from being set up on non-root iscsi
devices. It just means that before systemd shuts down iscsi in the
shutdown initramfs, it will attempt to disassemble the multipath device,
if possible.  I'm not sure what your objection here is. Am I missing
something?

-Ben

> 
> Cheers,
> 
> Hannes
> -- 
> Dr. Hannes Reinecke		               zSeries & Storage
> hare@suse.de			               +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index b5b755b..fc2e009 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -1,5 +1,6 @@ 
 [Unit]
 Description=Device-Mapper Multipath Device Controller
+Requires=blk-availability.service
 Before=iscsi.service iscsid.service lvm2-activation-early.service
 Before=local-fs-pre.target
 After=multipathd.socket