| Message ID | 1444333491-16265-4-git-send-email-bmarzins@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Benjamin Marzinski |
| Headers | show |
On 10/08/2015 09:44 PM, Benjamin Marzinski wrote: > /var/run is usually a symlink to /run. If /var is on a separate > filesytem, when multipathd starts up, it might end up writing to > /var/run before the /var filesytem is mounted and thus not have > its pidfile accessible at /var/run afterwards. /run is a tmpfs and > should always be available before multipathd is started, so > multipath should just write there directly, instead of through the > symlink. > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > --- ??? What now? First we've been told by the systemd folks that using / directly is evil, and everything needs to be moved to /var or /usr. Now we should have to move it back? Is there a reference for this? Cheers, Hannes
diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h index 8902f40..79d6b91 100644 --- a/libmultipath/defaults.h +++ b/libmultipath/defaults.h @@ -26,7 +26,7 @@ #define MAX_CHECKINT(a) (a << 2) #define MAX_DEV_LOSS_TMO 0x7FFFFFFF -#define DEFAULT_PIDFILE "/var/run/multipathd.pid" +#define DEFAULT_PIDFILE "/run/multipathd.pid" #define DEFAULT_SOCKET "/org/kernel/linux/storage/multipathd" #define DEFAULT_CONFIGFILE "/etc/multipath.conf" #define DEFAULT_BINDINGS_FILE "/etc/multipath/bindings" diff --git a/multipathd/multipathd.init.suse b/multipathd/multipathd.init.suse index d1319b1..ed699fa 100644 --- a/multipathd/multipathd.init.suse +++ b/multipathd/multipathd.init.suse @@ -17,7 +17,7 @@ PATH=/bin:/usr/bin:/sbin:/usr/sbin DAEMON=/sbin/multipathd -PIDFILE=/var/run/multipathd.pid +PIDFILE=/run/multipathd.pid MPATH_INIT_TIMEOUT=10 ARGS=""
/var/run is usually a symlink to /run. If /var is on a separate filesytem, when multipathd starts up, it might end up writing to /var/run before the /var filesytem is mounted and thus not have its pidfile accessible at /var/run afterwards. /run is a tmpfs and should always be available before multipathd is started, so multipath should just write there directly, instead of through the symlink. Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> --- libmultipath/defaults.h | 2 +- multipathd/multipathd.init.suse | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)