From patchwork Tue Mar 29 03:13:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Marzinski X-Patchwork-Id: 8681761 Return-Path: X-Original-To: patchwork-dm-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EAD87C0553 for ; Tue, 29 Mar 2016 03:18:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2788020145 for ; Tue, 29 Mar 2016 03:18:43 +0000 (UTC) Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D36420142 for ; Tue, 29 Mar 2016 03:18:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u2T3GEJw032490; Mon, 28 Mar 2016 23:16:14 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u2T3Dhie014441 for ; Mon, 28 Mar 2016 23:13:43 -0400 Received: from redhat.com (octiron.msp.redhat.com [10.15.80.209]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id u2T3Dfba017522; Mon, 28 Mar 2016 23:13:41 -0400 Received: by redhat.com (sSMTP sendmail emulation); Mon, 28 Mar 2016 22:13:41 -0500 From: "Benjamin Marzinski" To: device-mapper development Date: Mon, 28 Mar 2016 22:13:13 -0500 Message-Id: <1459221194-23222-17-git-send-email-bmarzins@redhat.com> In-Reply-To: <1459221194-23222-1-git-send-email-bmarzins@redhat.com> References: <1459221194-23222-1-git-send-email-bmarzins@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-loop: dm-devel@redhat.com Cc: Christophe Varoqui Subject: [dm-devel] [PATCH 16/17] multipathd.service: remove blk-availability Requires X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP multipathd.service can start up and run just fine without blk-availability.service. It is only necessary to coordinate shutdown order in certain multipath setups (over iscsi for instance). Thus, instead of "Requires", multipathd.service should use "Wants" Signed-off-by: Benjamin Marzinski --- multipathd/multipathd.service | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service index fc2e009..d5f8606 100644 --- a/multipathd/multipathd.service +++ b/multipathd/multipathd.service @@ -1,11 +1,10 @@ [Unit] Description=Device-Mapper Multipath Device Controller -Requires=blk-availability.service Before=iscsi.service iscsid.service lvm2-activation-early.service Before=local-fs-pre.target After=multipathd.socket DefaultDependencies=no -Wants=local-fs-pre.target multipathd.socket +Wants=local-fs-pre.target multipathd.socket blk-availability.service Conflicts=shutdown.target [Service]