| Message ID | 1461755458-29225-7-git-send-email-hare@suse.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > libmultipath/hwtable.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) You missed to also change multipath.conf.defaults. > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 28ee595..4549268 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -65,13 +65,13 @@ static struct hwentry default_hw[] = { > .vendor = "3PARdata", > .product = "VV", > .features = DEFAULT_FEATURES, > - .hwhandler = DEFAULT_HWHANDLER, > - .pgpolicy = MULTIBUS, > - .pgfailback = FAILBACK_UNDEF, > + .hwhandler = "1 alua", > + .pgpolicy = GROUP_BY_PRIO, > + .pgfailback = -FAILBACK_IMMEDIATE, > .rr_weight = RR_WEIGHT_NONE, > - .no_path_retry = NO_PATH_RETRY_UNDEF, > - .checker_name = DEFAULT_CHECKER, > - .prio_name = DEFAULT_PRIO, > + .no_path_retry = 18, > + .checker_name = TUR, > + .prio_name = PRIO_ALUA, > .prio_args = NULL, > }, > { Can you please elaborate on this? I think the correct setting depends on the configured "host persona". Currently the expected value would be "Generic / 1". The patch changes it to "Generic-ALUA / 2". Does the above change still work if the "host persona" is not modified and still set to "Generic / 1"? Sebastian -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On 04/29/2016 12:25 AM, Sebastian Herbszt wrote: > Hannes Reinecke wrote: >> Signed-off-by: Hannes Reinecke <hare@suse.de> >> --- >> libmultipath/hwtable.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > > You missed to also change multipath.conf.defaults. > >> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c >> index 28ee595..4549268 100644 >> --- a/libmultipath/hwtable.c >> +++ b/libmultipath/hwtable.c >> @@ -65,13 +65,13 @@ static struct hwentry default_hw[] = { >> .vendor = "3PARdata", >> .product = "VV", >> .features = DEFAULT_FEATURES, >> - .hwhandler = DEFAULT_HWHANDLER, >> - .pgpolicy = MULTIBUS, >> - .pgfailback = FAILBACK_UNDEF, >> + .hwhandler = "1 alua", >> + .pgpolicy = GROUP_BY_PRIO, >> + .pgfailback = -FAILBACK_IMMEDIATE, >> .rr_weight = RR_WEIGHT_NONE, >> - .no_path_retry = NO_PATH_RETRY_UNDEF, >> - .checker_name = DEFAULT_CHECKER, >> - .prio_name = DEFAULT_PRIO, >> + .no_path_retry = 18, >> + .checker_name = TUR, >> + .prio_name = PRIO_ALUA, >> .prio_args = NULL, >> }, >> { > > Can you please elaborate on this? > I think the correct setting depends on the configured > "host persona". Currently the expected value would be > "Generic / 1". The patch changes it to "Generic-ALUA / 2". > Does the above change still work if the "host persona" is > not modified and still set to "Generic / 1"? > I have never ever _seen_ an 3Par array, so I wasn't aware that you could switch host 'persona'. So I have to rely on our partners (ie HPE) for correct configuration here. But given that fact we should better switch back to use the default hw_handler and use the 'retain_attached_hw_handler' option. Cheers, Hannes
Hannes Reinecke wrote: > On 04/29/2016 12:25 AM, Sebastian Herbszt wrote: > > Hannes Reinecke wrote: > >> Signed-off-by: Hannes Reinecke <hare@suse.de> > >> --- > >> libmultipath/hwtable.c | 12 ++++++------ > >> 1 file changed, 6 insertions(+), 6 deletions(-) > > > > You missed to also change multipath.conf.defaults. > > > >> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > >> index 28ee595..4549268 100644 > >> --- a/libmultipath/hwtable.c > >> +++ b/libmultipath/hwtable.c > >> @@ -65,13 +65,13 @@ static struct hwentry default_hw[] = { > >> .vendor = "3PARdata", > >> .product = "VV", > >> .features = DEFAULT_FEATURES, > >> - .hwhandler = DEFAULT_HWHANDLER, > >> - .pgpolicy = MULTIBUS, > >> - .pgfailback = FAILBACK_UNDEF, > >> + .hwhandler = "1 alua", > >> + .pgpolicy = GROUP_BY_PRIO, > >> + .pgfailback = -FAILBACK_IMMEDIATE, > >> .rr_weight = RR_WEIGHT_NONE, > >> - .no_path_retry = NO_PATH_RETRY_UNDEF, > >> - .checker_name = DEFAULT_CHECKER, > >> - .prio_name = DEFAULT_PRIO, > >> + .no_path_retry = 18, > >> + .checker_name = TUR, > >> + .prio_name = PRIO_ALUA, > >> .prio_args = NULL, > >> }, > >> { > > > > Can you please elaborate on this? > > I think the correct setting depends on the configured > > "host persona". Currently the expected value would be > > "Generic / 1". The patch changes it to "Generic-ALUA / 2". > > Does the above change still work if the "host persona" is > > not modified and still set to "Generic / 1"? > > > I have never ever _seen_ an 3Par array, so I wasn't aware that you > could switch host 'persona'. So I have to rely on our partners (ie > HPE) for correct configuration here. HPE published at least two guides: "HPE 3PAR SUSE Linux Enterprise Implementation Guide" [1] pp. 36-38 "HPE 3PAR Red Hat Enterprise Linux and Oracle Linux Implementation Guide" [2] pp. 104-110 [1] http://h20565.www2.hpe.com/hpsc/doc/public/display?sp4ts.oid=5383451&docId=emr_na-c02663748&docLocale=en_US [2] http://h20628.www2.hp.com/km-ext/kmcsdirect/emr_na-c04448818-9.pdf Sebastian -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 28ee595..4549268 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -65,13 +65,13 @@ static struct hwentry default_hw[] = { .vendor = "3PARdata", .product = "VV", .features = DEFAULT_FEATURES, - .hwhandler = DEFAULT_HWHANDLER, - .pgpolicy = MULTIBUS, - .pgfailback = FAILBACK_UNDEF, + .hwhandler = "1 alua", + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, .rr_weight = RR_WEIGHT_NONE, - .no_path_retry = NO_PATH_RETRY_UNDEF, - .checker_name = DEFAULT_CHECKER, - .prio_name = DEFAULT_PRIO, + .no_path_retry = 18, + .checker_name = TUR, + .prio_name = PRIO_ALUA, .prio_args = NULL, }, {
Signed-off-by: Hannes Reinecke <hare@suse.de> --- libmultipath/hwtable.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)