From patchwork Fri Jun 3 07:14:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 9151973 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0099F6074E for ; Fri, 3 Jun 2016 07:18:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6B7326C9B for ; Fri, 3 Jun 2016 07:18:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB0F4282EE; Fri, 3 Jun 2016 07:18:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5CE3126C9B for ; Fri, 3 Jun 2016 07:18:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u537Eb0n012061; Fri, 3 Jun 2016 03:14:38 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u537EalR006800 for ; Fri, 3 Jun 2016 03:14:36 -0400 Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u537EaZG014755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 3 Jun 2016 03:14:36 -0400 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 914AB64D05 for ; Fri, 3 Jun 2016 07:14:35 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 450DFAAAD; Fri, 3 Jun 2016 07:14:34 +0000 (UTC) From: Hannes Reinecke To: Christophe Varoqui Date: Fri, 3 Jun 2016 09:14:32 +0200 Message-Id: <1464938072-2885-1-git-send-email-hare@suse.de> X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 03 Jun 2016 07:14:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 03 Jun 2016 07:14:35 +0000 (UTC) for IP:'195.135.220.15' DOMAIN:'mx2.suse.de' HELO:'mx2.suse.de' FROM:'hare@suse.de' RCPT:'' X-RedHat-Spam-Score: -3.327 (BAYES_50, DCC_REPUT_00_12, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, SPF_PASS) 195.135.220.15 mx2.suse.de 195.135.220.15 mx2.suse.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-loop: dm-devel@redhat.com Cc: dm-devel@redhat.com Subject: [dm-devel] [PATCH] multipathd: update defaults X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP For years I've been telling our customers to use the 'tur' checker as the current default 'directio' will cause spurious path failures under high load. And for several versions (years, even) the linux kernel has the ability to correctly detect the device handler, so we should be making 'retain_hw_handler' the default. And if we do this we also want to enable 'detect_prio', to ensure we pick the correct prioritizer. So this patch updates the default setting to always enable 'retain_hw_handler' and 'detect_prio' and switch to 'tur' as the default path checker. Signed-off-by: Hannes Reinecke --- libmultipath/checkers.h | 2 +- libmultipath/defaults.h | 4 ++-- multipath/multipath.conf.5 | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libmultipath/checkers.h b/libmultipath/checkers.h index a935b3f..374c826 100644 --- a/libmultipath/checkers.h +++ b/libmultipath/checkers.h @@ -85,7 +85,7 @@ enum path_check_state { #define READSECTOR0 "readsector0" #define CCISS_TUR "cciss_tur" -#define DEFAULT_CHECKER DIRECTIO +#define DEFAULT_CHECKER TUR #define ASYNC_TIMEOUT_SEC 30 diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h index 96f5a2c..4948271 100644 --- a/libmultipath/defaults.h +++ b/libmultipath/defaults.h @@ -16,8 +16,8 @@ #define DEFAULT_FIND_MULTIPATHS 0 #define DEFAULT_FAST_IO_FAIL 5 #define DEFAULT_DEV_LOSS_TMO 600 -#define DEFAULT_RETAIN_HWHANDLER RETAIN_HWHANDLER_OFF -#define DEFAULT_DETECT_PRIO DETECT_PRIO_OFF +#define DEFAULT_RETAIN_HWHANDLER RETAIN_HWHANDLER_ON +#define DEFAULT_DETECT_PRIO DETECT_PRIO_ON #define DEFAULT_DEFERRED_REMOVE DEFERRED_REMOVE_OFF #define DEFAULT_DELAY_CHECKS DELAY_CHECKS_OFF #define DEFAULT_UEVENT_STACKSIZE 256 diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index aaaa01b..20a2304 100644 --- a/multipath/multipath.conf.5 +++ b/multipath/multipath.conf.5 @@ -295,7 +295,7 @@ Check the path state for LSI/Engenio/NetApp E-Series RDAC storage controller. .B directio Read the first sector with direct I/O. .TP -Default value is \fIdirectio\fR. +Default value is \fItur\fR. .RE .TP .B failback @@ -463,7 +463,7 @@ are supported, or the prioritizer if not. If set to .I no , the prioritizer will be selected as usual. Default is -.I no +.I yes .TP .B force_sync If set to