From patchwork Sat Jul 23 00:29:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xose Vazquez Perez X-Patchwork-Id: 9244461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DCB2860459 for ; Sat, 23 Jul 2016 00:34:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD3AD281AA for ; Sat, 23 Jul 2016 00:34:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1198281D2; Sat, 23 Jul 2016 00:34:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 45102281AA for ; Sat, 23 Jul 2016 00:34:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6N0VCMb016199; Fri, 22 Jul 2016 20:31:12 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u6N0UmQJ005931 for ; Fri, 22 Jul 2016 20:30:48 -0400 Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6N0Ummi016451 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 22 Jul 2016 20:30:48 -0400 Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3051264D11 for ; Sat, 23 Jul 2016 00:30:47 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id q128so8096727wma.1 for ; Fri, 22 Jul 2016 17:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QSMaWSuegnGNRaSlMax/Q+Ez5ObeOHirKAjVYJwre0Q=; b=AYlMKB2NIybNfsfTt62UNQOhGyjA95sx4SlpjDufmCnYiDm8KzRZmGxI16kAGu9O4T q6Uz/cF4kUjCcQWlHw4gFY8+v0L+sRxiOCUiSnSLEj+7DkIUQzF6U/y2kWcGTwDuS2L+ cO5QGXZkpbLY+K/1zbpjT+0WcPrNXPBIkkYgVkhpaNU1yP5yjTaegj2NljwqFrOCDo6r zBPg4eaVtR8id1qIJPEgEQ67uRRZD1pzWTiVl1rm9iIL66vhlgiYkaHWXpRLxLB0mT5Q M7FGmkxO6oQ+bNTEHWWuoxmuetxqSrmyfZ0n+iLjEJzUA8ZNXkokbCc41uBnUrkj3jVy mBVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QSMaWSuegnGNRaSlMax/Q+Ez5ObeOHirKAjVYJwre0Q=; b=EmfTdzE0UE8LCuG1E/HKXLitTKJI+P6RJ26Mo3uAHykmiFsIgfDk5JaAcbZnEXKSZ8 ZK8plPE5noOf7ZxgXTDGbzMTF/xjsOJXsVYkmiGwDNTmy8daARVW7Uz/i3xLMXnbm8JM /xF7OGjcEbUxHNqUdE7rix6c6r1JrA+2sPMmaI1GYJzFOxTcVhMSXExtOLbYJNZ19vQn 4zJKN54RkdsfvkDDqCFtcNBh88gJCSkA9xKGatVs7B6o7xYnCvCF7ncZSTKEFDtXWLs+ NZu9p1qhvi5xABHGA4b6ghcRlF3LdVJep3noWCdhhRwqsPdU04xnsCNZGA10irURV7EA YNmQ== X-Gm-Message-State: AEkoouu2OUFNmO4nV2ifls6i0n0ywuvTRzkqjAOoQzPpommfeSfSFBzR55r+l882AiIZZw== X-Received: by 10.28.111.4 with SMTP id k4mr8331617wmc.94.1469233845965; Fri, 22 Jul 2016 17:30:45 -0700 (PDT) Received: from localhost (98.171.78.188.dynamic.jazztel.es. [188.78.171.98]) by smtp.gmail.com with ESMTPSA id r67sm14887879wmb.14.2016.07.22.17.30.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 17:30:44 -0700 (PDT) From: Xose Vazquez Perez To: Date: Sat, 23 Jul 2016 02:29:09 +0200 Message-Id: <1469233752-11708-2-git-send-email-xose.vazquez@gmail.com> In-Reply-To: <1469233752-11708-1-git-send-email-xose.vazquez@gmail.com> References: <1469233752-11708-1-git-send-email-xose.vazquez@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 23 Jul 2016 00:30:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sat, 23 Jul 2016 00:30:47 +0000 (UTC) for IP:'74.125.82.66' DOMAIN:'mail-wm0-f66.google.com' HELO:'mail-wm0-f66.google.com' FROM:'xose.vazquez@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.12 (BAYES_50, DCC_REPUT_13_19, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.82.66 mail-wm0-f66.google.com 74.125.82.66 mail-wm0-f66.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-loop: dm-devel@redhat.com Cc: device-mapper development , Xose Vazquez Perez Subject: [dm-devel] [PATCH 2/5] multipath-tools: Clarify template rules of hwtable X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 8eec209..6f9adc9 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -762,7 +762,8 @@ static struct hwentry default_hw[] = { * Copy this TEMPLATE to add new hardware. * * Keep only mandatory and modified attributes. - * Standard attributes must be removed. + * Attributes with default values must be removed. + * .vendor and .product are mandatory, all other are optional. * * COMPANY_NAME * @@ -770,8 +771,8 @@ static struct hwentry default_hw[] = { * Mail : XXX */ { - .vendor = "VENDOR", (Mandatory) - .product = "PRODUCT", (Mandatory) + .vendor = "VENDOR", + .product = "PRODUCT", .revision = "REVISION", .bl_product = "BL_PRODUCT", .pgpolicy = GROUP_BY_PRIO,