From patchwork Thu Aug 11 18:32:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xose Vazquez Perez X-Patchwork-Id: 9275781 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7DAA76022E for ; Thu, 11 Aug 2016 18:37:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70ACF28768 for ; Thu, 11 Aug 2016 18:37:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65ACA28778; Thu, 11 Aug 2016 18:37:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D967728768 for ; Thu, 11 Aug 2016 18:37:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7BIXnAD031805; Thu, 11 Aug 2016 14:33:49 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u7BIXHTK020376 for ; Thu, 11 Aug 2016 14:33:17 -0400 Received: from mx1.redhat.com (ext-mx02.extmail.prod.ext.phx2.redhat.com [10.5.110.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7BIXHPc022342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 11 Aug 2016 14:33:17 -0400 Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 03AB37DD39 for ; Thu, 11 Aug 2016 18:33:16 +0000 (UTC) Received: by mail-wm0-f68.google.com with SMTP id o80so811579wme.0 for ; Thu, 11 Aug 2016 11:33:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2YRJ/Suv+n4WJRxNEpciXo51N21ZBHfhe8vUIwFTDyA=; b=n+ki8SzWvIaQULhMhzZkmKA15Xo6Ay/6R1vjZRB0ZxFuMKJUmOcJzD+CWxV077+G9h b3wRwU+fYPyQANEshgNXz7uOyzWuFCua+tYABMrXn0fHZtDut17C1oocPfaciMijFZ7t iHPVpU5C8ot/ABu5qz7LKLbLXK7YLmSob3g2rqZdE1mA4ASvrQnKeMXNS98e8yjfXYQK RvsOvbDBEwKYZdxWhN7da34/Hhwy9d4gjdNBniFeakQ2iDVGN/3TsYOarHMEUfyf9aJ3 zp5QuYZvzWQiUvKbvoCSZjtg8y6AsycLBDVz598xgydRM2/LqpPXEGq/8oBcUrytCHn2 4A2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2YRJ/Suv+n4WJRxNEpciXo51N21ZBHfhe8vUIwFTDyA=; b=J/Gz2oYhEDnztfFxSSTUSPnA9nJT9LvW8+YjYyzfXbIktBenXv1VWaD635xVxiOhlR 9jvDC5w+c5lSVDV/awot86md518aAMdUsVgxsVOYxmgLiaoxbDIspmUb2PeM712tGYvX KG1womy3BnFj2MfIwj9Y4YdljDc+AV4WF9ToIpYq7hvNVkVsAgBUHSIOB1sGyWbASxaf 7LF/R77MPIq1PL/m8QkO08VeMSMt8quUl5GBAUTRNxTzUff5zxncJsr56/mITVO0RHfc BJjpcQGpbg0HeXgujD68UKP0nRR0XofZW2NwAeb3Man1cOAOyl2MqKgKr5SAjITolcx4 MNdg== X-Gm-Message-State: AEkoouv2xJ6DC8j5lNiZJF2nEEHPjTQsnvZNHISPpG2bM7aq7aKcQDQS4eUHe1/ajw4mVA== X-Received: by 10.28.54.229 with SMTP id y98mr10229441wmh.96.1470940394672; Thu, 11 Aug 2016 11:33:14 -0700 (PDT) Received: from localhost ([31.221.137.200]) by smtp.gmail.com with ESMTPSA id u72sm1306296wmf.5.2016.08.11.11.33.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Aug 2016 11:33:14 -0700 (PDT) From: Xose Vazquez Perez To: Date: Thu, 11 Aug 2016 20:32:22 +0200 Message-Id: <1470940345-4441-6-git-send-email-xose.vazquez@gmail.com> In-Reply-To: <1470940345-4441-1-git-send-email-xose.vazquez@gmail.com> References: <1470940345-4441-1-git-send-email-xose.vazquez@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 11 Aug 2016 18:33:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 11 Aug 2016 18:33:16 +0000 (UTC) for IP:'74.125.82.68' DOMAIN:'mail-wm0-f68.google.com' HELO:'mail-wm0-f68.google.com' FROM:'xose.vazquez@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.02 (BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.82.68 mail-wm0-f68.google.com 74.125.82.68 mail-wm0-f68.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.26 X-loop: dm-devel@redhat.com Cc: device-mapper development , Xose Vazquez Perez Subject: [dm-devel] [PATCH 06/11] multipath-tools: request to update man pages if the code is changed X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP Please, document the changes. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/checkers/Makefile | 1 + libmultipath/defaults.h | 4 ++++ libmultipath/dict.c | 3 +++ libmultipath/prioritizers/Makefile | 1 + 4 files changed, 9 insertions(+) diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/Makefile index e46192c..11ab76f 100644 --- a/libmultipath/checkers/Makefile +++ b/libmultipath/checkers/Makefile @@ -5,6 +5,7 @@ include ../../Makefile.inc CFLAGS += -I.. +# If you add or remove a checker also update multipath/multipath.conf.5 LIBS= \ libcheckcciss_tur.so \ libcheckreadsector0.so \ diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h index dd6a24b..3af85eb 100644 --- a/libmultipath/defaults.h +++ b/libmultipath/defaults.h @@ -1,3 +1,7 @@ +/* + * If you add or modify a value also update multipath/multipath.conf.5 + * and the TEMPLATE in libmultipath/hwtable.c + */ #define DEFAULT_UID_ATTRIBUTE "ID_SERIAL" #define DEFAULT_UDEVDIR "/dev" #define DEFAULT_MULTIPATHDIR "/" LIB_STRING "/multipath" diff --git a/libmultipath/dict.c b/libmultipath/dict.c index 1933b6d..e8c6804 100644 --- a/libmultipath/dict.c +++ b/libmultipath/dict.c @@ -1329,6 +1329,9 @@ snprint_deprecated (struct config *conf, char * buff, int len, void * data) #define __deprecated +/* + * If you add or remove a keywork also update multipath/multipath.conf.5 + */ void init_keywords(vector keywords) { diff --git a/libmultipath/prioritizers/Makefile b/libmultipath/prioritizers/Makefile index eff5fc1..36b42e4 100644 --- a/libmultipath/prioritizers/Makefile +++ b/libmultipath/prioritizers/Makefile @@ -5,6 +5,7 @@ include ../../Makefile.inc CFLAGS += -I.. +# If you add or remove a prioritizer also update multipath/multipath.conf.5 LIBS = \ libprioalua.so \ libprioconst.so \