From patchwork Tue Aug 16 12:38:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Xose Vazquez Perez X-Patchwork-Id: 9283777 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C67060839 for ; Tue, 16 Aug 2016 12:43:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F05C28A1A for ; Tue, 16 Aug 2016 12:43:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 537E228BAB; Tue, 16 Aug 2016 12:43:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 803F028A1A for ; Tue, 16 Aug 2016 12:43:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u7GCdc4j031954; Tue, 16 Aug 2016 08:39:39 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u7GCdSva022283 for ; Tue, 16 Aug 2016 08:39:28 -0400 Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7GCdSPn012297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 16 Aug 2016 08:39:28 -0400 Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF8D34E337; Tue, 16 Aug 2016 12:39:26 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id i138so16145404wmf.3; Tue, 16 Aug 2016 05:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zI9pr6OKyZ+xRk4thCM+dRS7oJQlDKrOFp39T8NebsM=; b=nuPJDu6bvmJQ6ZkYGUvn3Y2PedGzJDmqrdhtGiXszUtldm87abAPgdMTgZeaRcSzzG X9TW+aMvEDyHdwziBgNhcYvx60RTxoXQ4g/d1wsYleHZ6gFm7yLT0ZG5ILe1K3KtlUoA bKbMBrv0eXOyQaCtb0nfh+iDMbLQoLECo5xuzVQNZjsJtObIvIas9etDx46BzqFfn7tM s78WLkIZGvBep4NMe0VLg0xT4osW2kRJAxraVeU6njawyOlyUW8QFNZPKaDgFS81x5lN Nsbz5DITyLeCKhkK0NYoVCIKzlEvg+5JiF9T8myVshGRR4p3eeapeDqHgI4wVe6vt8SJ WFtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zI9pr6OKyZ+xRk4thCM+dRS7oJQlDKrOFp39T8NebsM=; b=LJzCCuSUxru72nkx3HcAyGc00t0IHLW1uYeHn0PAhVXVK1Dqhxh2wzXadZ/lh7zrPY J5r+dSQe5AaPbw7OnlkKkB+r06Nw4xqhRANLdAIWPKtkEFAL1mng3JVJm6qHzq0t2F7L IRd5G/ETaH1y0e5MWd0HPQLQdpcrB2w08eyU1bo4EQ772EmSm05xRp+K764A9jF2NVFM AxPKyj8PvX5x1vN3CLMqMpyVl5qgXFZovI1aVzMsnUuKOMXr6ff0dBh7eEaF7BC2DG+w InobktQ8ic1WXXq4eztkB5HuhUrtdrYnzcFtmltWytNJXwgxoufmYWOh26UJasaTAAoP Et5A== X-Gm-Message-State: AEkoouszB/hMA3IENw6+iaJjMTwARg7olWS8ii9rr6LGpfDa94C3s/ZFC+A4SlO7KOWiPQ== X-Received: by 10.28.141.6 with SMTP id p6mr6734318wmd.110.1471351165372; Tue, 16 Aug 2016 05:39:25 -0700 (PDT) Received: from localhost ([31.221.161.126]) by smtp.gmail.com with ESMTPSA id d64sm21561318wmc.22.2016.08.16.05.39.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2016 05:39:24 -0700 (PDT) From: Xose Vazquez Perez To: Date: Tue, 16 Aug 2016 14:38:52 +0200 Message-Id: <1471351133-7892-4-git-send-email-xose.vazquez@gmail.com> In-Reply-To: <1471351133-7892-1-git-send-email-xose.vazquez@gmail.com> References: <1471351133-7892-1-git-send-email-xose.vazquez@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 16 Aug 2016 12:39:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 16 Aug 2016 12:39:27 +0000 (UTC) for IP:'74.125.82.66' DOMAIN:'mail-wm0-f66.google.com' HELO:'mail-wm0-f66.google.com' FROM:'xose.vazquez@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.02 (BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.82.66 mail-wm0-f66.google.com 74.125.82.66 mail-wm0-f66.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.38 X-loop: dm-devel@redhat.com Cc: Kiyoshi Ueda , Xose Vazquez Perez , device-mapper development , Mike Christie , =?UTF-8?q?Jun=E2=80=99ichi=20Nomura?= Subject: [dm-devel] [PATCH 4/5] multipath-tools: delete .minio from hwtable X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP It's useless, default path_selector is service-time. And document some aspects of round-robin. Cc: Kiyoshi Ueda Cc: Jun’ichi Nomura Cc: Mike Christie Cc: Hannes Reinecke Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 14 -------------- multipath/multipath.conf.5 | 20 ++++++++++++-------- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index b74616b..11cf498 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -79,7 +79,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = FAILBACK_UNDEF, .no_path_retry = 12, - .minio = 100, .checker_name = HP_SW, .prio_name = PRIO_HP_SW, }, @@ -90,7 +89,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 12, - .minio = 100, .prio_name = PRIO_ALUA, }, { @@ -100,7 +98,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 12, - .minio = 100, .prio_name = PRIO_ALUA, }, { @@ -110,7 +107,6 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, .pgfailback = FAILBACK_UNDEF, .no_path_retry = 18, - .minio = 100, }, { /* MSA2000 family with new firmware */ @@ -119,7 +115,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 18, - .minio = 100, .prio_name = PRIO_ALUA, }, { @@ -129,7 +124,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 18, - .minio = 100, .prio_name = PRIO_ALUA, }, { @@ -140,7 +134,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 12, - .minio = 100, .prio_name = PRIO_ALUA, }, { @@ -158,7 +151,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 18, - .minio = 100, .prio_name = PRIO_ALUA, }, /* @@ -520,7 +512,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = NO_PATH_RETRY_QUEUE, - .minio = 100, .prio_name = PRIO_ALUA, }, { @@ -530,7 +521,6 @@ static struct hwentry default_hw[] = { .features = "1 queue_if_no_path", .pgpolicy = MULTIBUS, .pgfailback = FAILBACK_UNDEF, - .minio = 15, }, /* * IBM Power Virtual SCSI Devices @@ -577,7 +567,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .flush_on_last_del = FLUSH_ENABLED, - .minio = 128, .dev_loss = MAX_DEV_LOSS_TMO, .prio_name = PRIO_ONTAP, }, @@ -612,7 +601,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_SERIAL, .pgfailback = FAILBACK_UNDEF, .no_path_retry = 30, - .minio = 128, }, /* * SGI @@ -776,7 +764,6 @@ static struct hwentry default_hw[] = { .features = "1 queue_if_no_path", .pgpolicy = MULTIBUS, .pgfailback = FAILBACK_UNDEF, - .minio = 100, }, /* * Intel @@ -800,7 +787,6 @@ static struct hwentry default_hw[] = { .pgpolicy = GROUP_BY_PRIO, .pgfailback = -FAILBACK_IMMEDIATE, .no_path_retry = 12, - .minio = 100, .prio_name = PRIO_ALUA, }, /* diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index 55fde22..fd4b1f2 100644 --- a/multipath/multipath.conf.5 +++ b/multipath/multipath.conf.5 @@ -7,7 +7,7 @@ .\" .\" ---------------------------------------------------------------------------- . -.TH MULTIPATH.CONF 5 2016-08-07 "Linux" +.TH MULTIPATH.CONF 5 2016-08-09 "Linux" . . .\" ---------------------------------------------------------------------------- @@ -163,7 +163,8 @@ kernel multipath target. There are three selector algorithms: .TP 12 .I "round-robin 0" Loop through every path in the path group, sending the same amount of IO to -each. +each. Some aspects of behavior can be controlled with the attributes: +\fIrr_min_io\fR, \fIrr_min_io_rq\fR and \fIrr_weight\fR. .TP .I "queue-length 0" Send the next bunch of IO down the path with the least amount of outstanding IO. @@ -433,8 +434,9 @@ Default value is: \fBmanual\fR . .TP .B rr_min_io -The number of IO to route to a path before switching to the next in -the same path group. This is only for BIO based multipath. +Number of IO requests to route to a path before switching to the next in the +same path group. This is only for \fIBlock I/O\fR(BIO) based multipath and +only apply to \fIround-robin\fR path_selector. .RS .TP Default value is: \fB1000\fR @@ -443,8 +445,9 @@ Default value is: \fB1000\fR . .TP .B rr_min_io_rq -The number of IO requests to route to a path before switching to the -next in the same path group. This is only for request based multipath. +Number of IO requests to route to a path before switching to the next in the +same path group. This is only for \fIRequest\fR based multipath and +only apply to \fIround-robin\fR path_selector. .RS .TP Default value is: \fB1\fR @@ -467,11 +470,12 @@ Default value is: \fBmax\fR . .TP .B rr_weight -If set to \fIpriorities\fR the multipath configurator will assign -path weights as "path prio * rr_min_io". Possible values are +If set to \fIpriorities\fR the multipath configurator will assign path weights +as "path prio * rr_min_io". Possible values are .I priorities or .I uniform . +Only apply to \fIround-robin\fR path_selector. .RS .TP Default value is: \fBuniform\fR