From patchwork Tue Oct 11 21:36:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Christie X-Patchwork-Id: 9371729 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 314DA6048F for ; Tue, 11 Oct 2016 21:39:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 234DC28DFB for ; Tue, 11 Oct 2016 21:39:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1818729080; Tue, 11 Oct 2016 21:39:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CA17E28DFB for ; Tue, 11 Oct 2016 21:39:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u9BLba7W015581; Tue, 11 Oct 2016 17:37:36 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u9BLawtx003062 for ; Tue, 11 Oct 2016 17:36:58 -0400 Received: from rh2.redhat.com (vpn-54-83.rdu2.redhat.com [10.10.54.83]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9BLauo3031548; Tue, 11 Oct 2016 17:36:58 -0400 From: Mike Christie To: dm-devel@redhat.com, christophe.varoqui@opensvc.com Date: Tue, 11 Oct 2016 16:36:52 -0500 Message-Id: <1476221815-17900-3-git-send-email-mchristi@redhat.com> In-Reply-To: <1476221815-17900-1-git-send-email-mchristi@redhat.com> References: <1476221815-17900-1-git-send-email-mchristi@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-loop: dm-devel@redhat.com Cc: Mike Christie Subject: [dm-devel] [PATCH 2/5] rbd: check for nonshared clients X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP The rbd checker only supports nonshared clients so add a check during init time. Signed-off-by: Mike Christie --- libmultipath/checkers/rbd.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libmultipath/checkers/rbd.c b/libmultipath/checkers/rbd.c index 8f88154..f0497db 100644 --- a/libmultipath/checkers/rbd.c +++ b/libmultipath/checkers/rbd.c @@ -124,6 +124,11 @@ int libcheck_init(struct checker * c) if (!config_info) goto free_addr; + if (!strstr(config_info, "noshare")) { + condlog(3, "Only nonshared clients supported."); + goto free_addr; + } + ct->config_info = strdup(config_info); if (!ct->config_info) goto free_addr;