diff mbox

libmultipath/checkers/rbd: fix free in libcheck_init

Message ID 1478246069-3448-1-git-send-email-peng.liang5@zte.com.cn (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show

Commit Message

peng.liang5@zte.com.cn Nov. 4, 2016, 7:54 a.m. UTC 
From: PengLiang <peng.liang5@zte.com.cn>

There is an incorrect free maybe causing memory leak.

Signed-off-by: PengLiang <peng.liang5@zte.com.cn>
---
 libmultipath/checkers/rbd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Benjamin Marzinski Nov. 4, 2016, 5:50 p.m. UTC | #1 
On Fri, Nov 04, 2016 at 03:54:29PM +0800, peng.liang5@zte.com.cn wrote:
> From: PengLiang <peng.liang5@zte.com.cn>

ACK

-Ben

> 
> There is an incorrect free maybe causing memory leak.
> 
> Signed-off-by: PengLiang <peng.liang5@zte.com.cn>
> ---
>  libmultipath/checkers/rbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/checkers/rbd.c b/libmultipath/checkers/rbd.c
> index 481d860..9ea0572 100644
> --- a/libmultipath/checkers/rbd.c
> +++ b/libmultipath/checkers/rbd.c
> @@ -174,7 +174,7 @@ int libcheck_init(struct checker * c)
>  
>  	ct->image = strdup(image);
>  	if (!ct->image)
> -		goto free_info;
> +		goto free_username;
>  
>  	pool = udev_device_get_sysattr_value(bus_dev, "pool");
>  	if (!pool)
> -- 
> 2.8.1.windows.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/libmultipath/checkers/rbd.c b/libmultipath/checkers/rbd.c
index 481d860..9ea0572 100644
--- a/libmultipath/checkers/rbd.c
+++ b/libmultipath/checkers/rbd.c
@@ -174,7 +174,7 @@  int libcheck_init(struct checker * c)
 
 	ct->image = strdup(image);
 	if (!ct->image)
-		goto free_info;
+		goto free_username;
 
 	pool = udev_device_get_sysattr_value(bus_dev, "pool");
 	if (!pool)