diff mbox

libmultipath: remove unnecessary condition in checker_repair

Message ID 1478509055-7648-1-git-send-email-peng.liang5@zte.com.cn (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show

Commit Message

peng.liang5@zte.com.cn Nov. 7, 2016, 8:57 a.m. UTC 
From: PengLiang <peng.liang5@zte.com.cn>

The checker's validity is an unnecessary checking. It will be checked in checker_selected.

Signed-off-by: PengLiang <peng.liang5@zte.com.cn>
---
 libmultipath/checkers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christophe Varoqui Nov. 20, 2016, 1:37 p.m. UTC | #1 
Merged,
thanks.

On Mon, Nov 7, 2016 at 9:57 AM, <peng.liang5@zte.com.cn> wrote:

> From: PengLiang <peng.liang5@zte.com.cn>
>
> The checker's validity is an unnecessary checking. It will be checked in
> checker_selected.
>
> Signed-off-by: PengLiang <peng.liang5@zte.com.cn>
> ---
>  libmultipath/checkers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/checkers.c b/libmultipath/checkers.c
> index fd999b0..05e024f 100644
> --- a/libmultipath/checkers.c
> +++ b/libmultipath/checkers.c
> @@ -213,7 +213,7 @@ void checker_put (struct checker * dst)
>
>  void checker_repair (struct checker * c)
>  {
> -       if (!c || !checker_selected(c))
> +       if (!checker_selected(c))
>                 return;
>
>         c->message[0] = '\0';
> --
> 2.8.1.windows.1
>
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/libmultipath/checkers.c b/libmultipath/checkers.c
index fd999b0..05e024f 100644
--- a/libmultipath/checkers.c
+++ b/libmultipath/checkers.c
@@ -213,7 +213,7 @@  void checker_put (struct checker * dst)
 
 void checker_repair (struct checker * c)
 {
-	if (!c || !checker_selected(c))
+	if (!checker_selected(c))
 		return;
 
 	c->message[0] = '\0';