| Message ID | 1480055764-11124-1-git-send-email-peng.liang5@zte.com.cn (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
Applied, thanks. On Fri, Nov 25, 2016 at 7:36 AM, <peng.liang5@zte.com.cn> wrote: > From: PengLiang <peng.liang5@zte.com.cn> > > If no_path_retry set to queue, we should make sure dev_loss_tmo update to > MAX_DEV_LOSS_TMO. > But, it will be limit to 600 if fast_io_fail_tmo set to off or 0 meanwhile. > > Signed-off-by: PengLiang <peng.liang5@zte.com.cn> > --- > libmultipath/discovery.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c > index aaa915c..05b0842 100644 > --- a/libmultipath/discovery.c > +++ b/libmultipath/discovery.c > @@ -608,7 +608,8 @@ sysfs_set_rport_tmo(struct multipath *mpp, struct path > *pp) > goto out; > } > } > - } else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO) { > + } else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO && > + mpp->no_path_retry != NO_PATH_RETRY_QUEUE) { > condlog(3, "%s: limiting dev_loss_tmo to %d, since " > "fast_io_fail is not set", > rport_id, DEFAULT_DEV_LOSS_TMO); > -- > 2.8.1.windows.1 > > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Fri, Nov 25, 2016 at 02:36:04PM +0800, peng.liang5@zte.com.cn wrote: > From: PengLiang <peng.liang5@zte.com.cn> > > If no_path_retry set to queue, we should make sure dev_loss_tmo update to MAX_DEV_LOSS_TMO. > But, it will be limit to 600 if fast_io_fail_tmo set to off or 0 meanwhile. Doesn't the system still limit dev_loss_tmo to 600 if fast_io_fail_tmo isn't set. Multipath was using this limit, since the underlying system uses it. -Ben > > Signed-off-by: PengLiang <peng.liang5@zte.com.cn> > --- > libmultipath/discovery.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c > index aaa915c..05b0842 100644 > --- a/libmultipath/discovery.c > +++ b/libmultipath/discovery.c > @@ -608,7 +608,8 @@ sysfs_set_rport_tmo(struct multipath *mpp, struct path *pp) > goto out; > } > } > - } else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO) { > + } else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO && > + mpp->no_path_retry != NO_PATH_RETRY_QUEUE) { > condlog(3, "%s: limiting dev_loss_tmo to %d, since " > "fast_io_fail is not set", > rport_id, DEFAULT_DEV_LOSS_TMO); > -- > 2.8.1.windows.1 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c index aaa915c..05b0842 100644 --- a/libmultipath/discovery.c +++ b/libmultipath/discovery.c @@ -608,7 +608,8 @@ sysfs_set_rport_tmo(struct multipath *mpp, struct path *pp) goto out; } } - } else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO) { + } else if (mpp->dev_loss > DEFAULT_DEV_LOSS_TMO && + mpp->no_path_retry != NO_PATH_RETRY_QUEUE) { condlog(3, "%s: limiting dev_loss_tmo to %d, since " "fast_io_fail is not set", rport_id, DEFAULT_DEV_LOSS_TMO);