From patchwork Mon Aug 15 15:28:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9281431 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9673B607FD for ; Mon, 15 Aug 2016 15:32:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 872A228D29 for ; Mon, 15 Aug 2016 15:32:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B86128D32; Mon, 15 Aug 2016 15:32:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx3-phx2.redhat.com (mx3-phx2.redhat.com [209.132.183.24]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BFD4328D29 for ; Mon, 15 Aug 2016 15:32:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u7FFSaHh020660; Mon, 15 Aug 2016 11:28:37 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u7FFSZk4014699 for ; Mon, 15 Aug 2016 11:28:35 -0400 Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7FFSZ4s018837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 15 Aug 2016 11:28:35 -0400 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0043.outbound.protection.outlook.com [104.47.38.43]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FE2261E54 for ; Mon, 15 Aug 2016 15:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7nEcvFlJzFkPLKY4N1U/XRcvQVrBTK4kG9pDPUulE/A=; b=dXZPShoSCrcFTd3piWmKMBD5uHGjXXMs6oIrh3rq5aGcszzsS9mSqAVxHm7+ekRcHWxI4+454D2/lkkspwkUnXjkXB1YM4K3cB5EkoI/Vl+nFmQwx6wx/y9jG3fZspYjdux080p63CjkPlol9MYxE2uiiMm8GBCwnxIz30G7BDQ= Received: from BLUPR0201CA0028.namprd02.prod.outlook.com (10.163.116.38) by BY2PR0201MB0806.namprd02.prod.outlook.com (10.160.125.147) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.549.15; Mon, 15 Aug 2016 15:28:30 +0000 Received: from BL2FFO11FD013.protection.gbl (2a01:111:f400:7c09::145) by BLUPR0201CA0028.outlook.office365.com (2a01:111:e400:52e7::38) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.21 via Frontend Transport; Mon, 15 Aug 2016 15:28:29 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; opensvc.com; dkim=none (message not signed) header.d=none;opensvc.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BL2FFO11FD013.mail.protection.outlook.com (10.173.160.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.567.7 via Frontend Transport; Mon, 15 Aug 2016 15:28:30 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 61.36.26959.DADD1B75; Mon, 15 Aug 2016 08:20:14 -0700 (PDT) Received: from milsmgip11.sandisk.com (10.177.8.100) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.301.0; Mon, 15 Aug 2016 08:28:30 -0700 X-AuditID: 0ac94369-babff7000001694f-e5-57b1ddade2b5 Received: from exp-402881.sandisk.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id AF.B9.02783.D9FD1B75; Mon, 15 Aug 2016 08:28:29 -0700 (PDT) To: Christophe Varoqui References: <31d43b64-36c8-1a24-a849-230b5cf6323c@sandisk.com> From: Bart Van Assche Message-ID: <14804b8b-51a7-e860-91d7-9b594aeed63c@sandisk.com> Date: Mon, 15 Aug 2016 08:28:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <31d43b64-36c8-1a24-a849-230b5cf6323c@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsXCddJ5ke66uxvDDa72slms+ziXzWLvu9ms Dkwea26fZvV4v+8qWwBTFJdNSmpOZllqkb5dAlfG258LGAvOCFc83zSZtYHxOX8XIyeHhICJ xOWm/UwgtpDAUiaJ3R+Cuhi5gOwdjBJPWm8ywhTtfLyTFSKxlFFi4cI9rCAJYQFrianTdzKD 2CIC5hLzzy1j6WLkACqyk3i/IBskzCxgLPF1x2+wOWwCRhLf3s9kAbF5gUp2d/eBLWYRUJU4 enQSWFxUIExi2t237BA1ghInZz4Bi3MK2EucbP3MAjHTQOLIojmsELa8xPa3c5gh7uxjlfjU EQTxjLrEySXzmSYwCs9CMmoWkvZZSNoXMDKvYhTLzcwpzk1PLTA01StOzEvJLM7WS87P3cQI CfDMHYx3n3gfYhTgYFTi4U2o3BAuxJpYVlyZe4hRgoNZSYTX5tbGcCHelMTKqtSi/Pii0pzU 4kOM0hwsSuK8bve+hAkJpCeWpGanphakFsFkmTg4pRoYQ0RiK8LyCsQebJzHYMNxiClgk2Rx 7vHJGfXSH6uU/jBvt8s8o5X6uza5S6z1nIu08J7HzarKaQEJbxqMP3p7zVnwQzLsjO4DhzVH SzmaOnjffmH7tXFFidYslpLDU52vvsrzTdrstCgx575Piv60Cbccs5e8Nbwds3+lZ7Sh3nOm xz4Wb3qUWIozEg21mIuKEwEueCdVbAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAJMWRmVeSWpSXmKPExsXCtZEjRXfu/Y3hBmsuqVms+ziXzWLvu9ms Dkwea26fZvV4v+8qWwBTFJdNSmpOZllqkb5dAlfG258LGAvOCFc83zSZtYHxOX8XIyeHhICJ xM7HO1m7GLk4hAQWM0r8ePGAESQhLGAtMXX6TmYQW0TAXGL+uWUsXYwcQEV2Eu8XZIOEmQWM JRavn88GYrMJGEl8ez+TBcTmBSrZ3d3HBGKzCKhKHD06CSwuKhAmMe3uW3aIGkGJkzOfgMU5 BewlTrZ+ZoGYqSex4/ovVghbXmL72znMExj5ZiFpmYWkbBaSsgWMzKsYxXIzc4pz0zMLDA31 ihPzUjKLs/WS83M3MYLDjDNyB+PTieaHGJk4OKUaGGVMkpxXC/f9+v4jvyWv+/1rzqjap+mO a40Oh2T82jynen/6G7bijxXfbmmsbSnKdNt7s8mxictxinsUn4q2+yW/H9VTnjtkWDifUjj3 2kPk6j3uS6t9OlkSHt2KPzlvbZLLd7b3izr7Q/+fnnpkS83qWNWXmjvd0l6dZG6pYtjdvLx6 bcXJZ0osxRmJhlrMRcWJALokMV7jAQAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(230700001)(305945005)(7696003)(356003)(65806001)(4326007)(92566002)(47776003)(36756003)(189998001)(83506001)(2906002)(19580405001)(8676002)(81166006)(7846002)(586003)(8936002)(54356999)(81156014)(64126003)(2270400002)(50466002)(110136002)(69596002)(50986999)(4001350100001)(19580395003)(77096005)(31686004)(106466001)(87936001)(2950100001)(76176999)(31696002)(97736004)(65956001)(68736007)(229853001)(53416004)(86362001)(626004)(33646002)(23746002)(65826006); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0201MB0806; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD013; 1:TssjBnxfqi/y5XL7CmT2gM5qCjSx5sRBm2dwbOeFLiWKltrG9/QfvVbvGbaMNWsBsT+J2o7XRrFncukx3cqMM5yqY13GKLUZiLTq65xZqFjaKEpxV67RkA3K8cxmKVdNLfcKh/A6TnxqXsrjnygR7k+P2JRCFtW2KdaobG+c790Jh5mQT9kpbKJ9JSYQBE2Cv6VDh6OwJaLuOsDpoAPcFvrMWk6v51fpq4GTSz3fbNFFGIBQwdveegp1/abmYHPTnyBUx6NfoieX4QPV/QC3ndmsA0ZHl4E5b/7eYYp816bsCao5pdB2tcrvGvmzQDhAhj5f8/Aasti/u5igNp8OGqowdQwMSvF84VwVyzW/t26NubmQ8XZfeSTn50P9zZPoyb+kUA9i0ljxy4BLaAXC35TIq9aOX516IU6hneftCkpivIMh6w/byumJysgAqhQpK8rja6Y5iluhYHH5Dc++YiGVNom4tMcCiZpOy15C6M0= X-MS-Office365-Filtering-Correlation-Id: ee0a9fb5-55d2-4726-8e5e-08d3c520cfba X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB0806; 2:8WhPqRyFUfSsDBWm+xfqR2tr6LzF6zGkBAwp0eBo5I7b3pxsEtQMhGoaF97I+uZxaodffv+ssTEuO+RF8Fzz1yeCdjJYyjn1OMUDWDdXhsDFi5T9Asdch6n+wdJqlLlUdWdKTGP8Q9FCEeHF37lonj5+2zpl+YrBgsns1e8KV8Onq+kxWz1weoUFQ587V7j3; 3:qdQSkneErDacjU3JVybYGThL790QRPqc7yaYCvdZ6sem4YPeLSxt6WuiTwplnCQ1Z337zC1fk1+Sp90gpw7m8fyS/Bp1KcJBOwFvWjOfJPlkilc6t6g8/bJHTxFoTNltqlH9sR/s8qtuvlqsxSwM8Ntrd5T3cwFmpuN81OgHzhpPCe3y6yddqt7gKu2tUd8ekgD0YFovMsZD7yrgflI4uxOt12UaDaj2R9IlvYbm/9vwe+eYYuvWGYnU239b8Lhl5LaOOj95GBym0M5b6b6YqA== X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:BY2PR0201MB0806; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB0806; 25:pl3KeSsDe8+hcNxr5YnZ//s+Da42aJ+MBGvtMWY64TIM2kngg/Aptk9SUg1AGzjj/TCrFMs4bIgra2MtF7IckwVp1cvjoe8yYYNV2mhAsmVLgDCcj2792zYi9pDADX3xv6f4fcYiUEjVrYHyjajXm5Y58wAcTQxLXolnVAmW7nQe8/q7vek7RfW22qfQU8H+9nLi2ELyyBoHO50sfEbBk0CKtNjPUAXAcinpXYlpqfz+jTTRvXDjB/nEpMUP65t96593YXJxzW+zeztuugvz8g+Pt/50uO97TiBUugLaVu0XRYPvuW7KbN3bTR0C2fzsKBeLrPWhWp9u18g3IGm8ByAY57bipcpqBMbH4gZ5PjSP14/5tc9TPj9CZBc4U20nQSy8sgYQkjBcUWOTSYuUTFqZ0CzfSsgV/c3Q5CcucYezmCov62aOp0PEktD9ogq4ll02MJZQnn0z0zQNCXoEYFXDJkTUUrbYRtYQ8AKGPsIc28IHnRJcNLzdPiVGHcL7D4K6r0uGygYudJGIh9UOa6en01zqcayu0JXFeS9iVRhKtI4ritP3XjmqTUYm5f7CMMdT/V3N9ejy/J+TJkxJIvSaX6wNJ3cUEGqdYW6fKWSLpqKETz1EuyDwW9+rinf4Om16H9lKRd1WYeqYnB4WzeZkLA4NE2lsOvx+F1WrDX+vD7OtsQt5HTfVyqsQ1XlWfZLW3qEpwOxVndauctIegGS0TJ11SkZPcCTyJpdb6TqaNjFqsduUJn+qDXDekWzF1zk/EonpyIJfrXi813kn/g== X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB0806; 31:WJ/q6TjbaxQ0QD8t+Wh4c1JYmzuMn0plvlDqhVw5JAlrS4GAItZl4Pyw1aTDrwh8eFU2c0Fvinwu3+OmZg7gCDd1xGBgYZ3/DxtbQyEBriRTt061nhhiVfmEH1h9QsazjPHabW+DMb2t510pMiwlrrP6KXcJHG55SAu1OTCzsr5dWC7ALy1bzXY8ZlqKZPB/joU6nJtTYdAIIVejQoAL4NjaoxLja2BB46xUkNJ/Rkw=; 20:6hvpuR428OHyh/6G8o3Q78/S24iB1v5OfMAeUhBtjd9wDfd+/s7c4UzFiKNqDE9tzQOmukiSmxErFrnH7NWr/jy+rRY2T7cTTgSfSwoMvH4Q6qlq+GEFbvym9+DWObbe3G29Mh/hGoJtAciWWcSRNwENAHmsXk0HhhWF/6172GKBhkjIT395KUFx/QowACFaPxtOxwCoL59q4mHXb0Wa88sJtUsNX95RSGvsdqRwe4brX4JtvPa5/Sy+KGor+kH864tRjSjH5kF7lmCFxA96Sftvr11CYf65mlDOb8mm8h/0RmQpPiqrq0cWynHWlr6YVSjgtveOHwTqQhiIvlvGGosG34RpPfAtTcKCB/Ym8pmH0UZKPzvEtXqaDBSFtJBzWflEVLgixn+BD3+5rCaetoXe/VglbsN4ahXpk9qsyjebGVOI1W3rTOLhvNIWEtGySsvQoKzxG1z3j4d8CChrEjguQanctMpqO0SnIw75qjIvwBXS+tzX2h4LYN2TurH3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(13016025)(13018025)(3002001)(10201501046)(6055026); SRVR:BY2PR0201MB0806; BCL:0; PCL:0; RULEID:; SRVR:BY2PR0201MB0806; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB0806; 4:ZikTq7uRFgh2BJUbBq0O8Vq0nM3wqlwhya5bQzFwdO8an4rz95qHgN7GZJ65AQZK7KQI6YZnGNuqpLHCLwtQ2wrD5M0T5RdO6B65RGpGR9yg83CGkARilGxD8u8CaifePEEScHuIX7DgKlyL+5Id1CL0D3OKqCmz7trNUv9y2A7ua/7XW2+WRb+SgzQWss7pH56F1uVQY02F1brAMrWkO2QgXiA8CtL/GFj/PJqGqrB4uj7jFIWSN8hJ00/SOqlOvxhGC6pw4CbJ/KeBWwz3kNfS0F+5ovSGwizTCOgJowp/CxTfO77Nph8AZq1PH+ilzLHCXbVF+exAr0tAWPVp8gpmBZtBwfie6b78vy0tdyIghuxQVuLhqI8rAZUn91bQH1nPCXWsQ8HKZ/oE3mUMNUsAqvGagnE1Ok4Z/+cSPlhjFbTaIw3gabGgcEtVLI7EMF7Zz/wXObjSQdbSN+Kr1oyc207ZpzU3+tee/lnUP5I= X-Forefront-PRVS: 0035B15214 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY2PR0201MB0806; 23:jSPND8QCY+ut0+7Fp0t7iJdBx0nFOLkfzpx?= =?Windows-1252?Q?vgEParqIzv3/tzfC1g7OayP+HDUiTyQDzNmDlKrTYFuUxqWjrX29lquB?= =?Windows-1252?Q?KQM/8K4wW63/j+sGCfa/MkMcyUqxow91XuJ/JoArT9XQh/GGVvccITV+?= =?Windows-1252?Q?5L0vMtHU0o5Dg+y1oNSbQQZBDdWejmg/6z2G+r7/3w0HldzckpGP7dCD?= =?Windows-1252?Q?bPk/60Z4CuGruezDI/fldTrUFftrV1dkHYhHi01+31GReB6Ip9eEOuxN?= =?Windows-1252?Q?Gv6i6jAAdMyPE1KaoqLdLAM+7O8T43lceDxXkmaeUccYtSxpg7crsYJw?= =?Windows-1252?Q?Bj1jEvoIhpQHfFniqySHLxXadnwLX/jvFD5QBPH/t0ldWT8PmPmPS+Bz?= =?Windows-1252?Q?10vsPw83re9kFGthKJB6qpez5lgKDQES/Y9qoavKMNcABZatPRa0CaPd?= =?Windows-1252?Q?EuMKRwZxwTA0HZrnT70cxtTt/KMlqHYyeFpC+aRdMQ7vJlWEcQqEnwV4?= =?Windows-1252?Q?wNdgmWoR/RFQ8bjRbdlz2Zax8SepzG0fvoXFnB7C9UH6K58VViOX5m9i?= =?Windows-1252?Q?YNw1lyiIj0s2NKkAerRgGpdoi7yG1bq2lWJ9Ae/2fpefIpUsKBi4fUgW?= =?Windows-1252?Q?a6nsDRrPJ2i3Ucx2N83No574ew9jpLU25bLnk8QGIUC7NpcQo7yQpTNl?= =?Windows-1252?Q?x4MbfYkbBFejz+3J19HbAf8oUK5blarSoZX1h+H3yHZEeiA89ClXH3Bi?= =?Windows-1252?Q?wT+YYfWAV3mIouZQ/jRmCEIQLu5RzOH2gHWGndWHYn688GPcvD3F2OnY?= =?Windows-1252?Q?mOuF+LpF8CWGf62f2EP+BovEQ6rZ7iUWfKAErVq+c57mOVE6X/ftg3Ga?= =?Windows-1252?Q?qWmNCr9OYhqfHQq6iztjS2QgpUkjkwmBrfjJyuyOPo9skoH4sci7w+Ge?= =?Windows-1252?Q?JDZTIo9ekGo9gpf5uODnqLBU7/iF3K1ABtdzllhSjd8jPngvrK7twfsh?= =?Windows-1252?Q?bYcZRClHCYRD3krnscm0hWoC7gUtJjkWSEslZV25kpCD7gaRie5TboOx?= =?Windows-1252?Q?xSBnperCgTIEVZtkjZ7ARH9CWQ9bD6lj2qilDLgWtGztO00/aHk0hcIJ?= =?Windows-1252?Q?+I9WqNqR599njLZKUABAIzri77tP84mnl/OqWELBR9cwusPQnoSKriaA?= =?Windows-1252?Q?6cmvysgNdLTvQvG+edjBaoE2KZTCoBjSBwGj+77S0TILMhBhsvPPubnA?= =?Windows-1252?Q?i3YwUcVWn+ZGj+SYAbpSSVCQ8HER3+DO6qjG8U3ER6tTiokBkLKL4JGN?= =?Windows-1252?Q?Umz2p?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB0806; 6:Rsl4a9FKgJFZVjcYkvRkJ2r5kDKFdfNYG5cxhclopW/2XHQJkmr+EhhEz5uagjnZr81krJUg4xO5anon5c6m4lNRoPAh0HNvHgVjr+4jELqVG1ns5D9wBdfHKqxif+f4NLjEDUsNybzTjZ31RJHctCf3/uijGrfwjzuCss8PwdHelpcaWJ61Yg1ZqPcWBYLx7Rx+CL+HjWXePPvJlBZaZqdH+2eUDgsM4SRyb0IdpAOmxuoQ9iuCZ304ppOjeEqM+edPlKdaZIjwoxZrgATMqUNmdP+h1ySDdptY9w4Rc4txFj2zm2D1rs6VQh0+gGsuRHgJzBH04n5dF53Wo+aauQ==; 5:PHgL4stPqJ3j7Pm+yqyG5Y72UU0j2TCBuSMiaGuRPkgYKw7/OE8bSpF8/PPEhb9Kbq0Mb4mBCzaR0jYpm5G90tlRRInf/W0TwvAJRfZ1fJIgyvd+0izpMHPmfecltoozh0tKHuZZLWn2XkkG1eMAsQ==; 24:yj6JekoeNcRctjLFA+z0tU2RudvMcHUvcdmLk5ziaiFdSAoIlUi3WtN5f6DLyDgmJ9fmyLtcldnT1ZEgrnIO+KwNmXs9IeEd3z/A5o2MGCk=; 7:msS3gS2T1l0n+0qfCpCDxY6HNxTPOGKaTjJri3mhmC4IlQm4WufU4p8+uHAB52gZ518u2H/P0d0cnZUU3LEu9lZboPoUwhzJasuCg3KOWGxilwErZpcKJ+wzJR+ulNQms6mvJvRwRNK9VtFEb5l/JtHzErFxfbSFkkYruVxpHDCR7fVrgpP6txw1HkWmHqHYFVgOorZP+DL748HBUD7h13qRsiz5tcaUFAKXC0Hn9mALr6yEsOohdOdjJvpHkyw6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR0201MB0806; 20:hLiwssKincDxvOq5qqRWRNE+HB0cgBLpgmmXUh3TMhU6fBOdCopA9nJtPiKk/1SfbWcx3yKh2byXBMZKa9AJpyO3YPLX3d+PdgYCVPp+kWfPeiPhvR78J0yLbaK1pj80OLh7WYOT3vWsSbbeT5lUFXZItP8EPcQA4OgnewJyeSl46KcV1Ip6nfSwBBmzenk5gWYBRZIYCVM/Y8Ahar5scFpfqIXeyWJdLGRY3d3ExZ2hzSilJycH7GFcOm2m6h7i X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2016 15:28:30.1299 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB0806 X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 15 Aug 2016 15:28:34 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 15 Aug 2016 15:28:34 +0000 (UTC) for IP:'104.47.38.43' DOMAIN:'mail-bl2nam02on0043.outbound.protection.outlook.com' HELO:'NAM02-BL2-obe.outbound.protection.outlook.com' FROM:'Bart.VanAssche@sandisk.com' RCPT:'' X-RedHat-Spam-Score: 0.668 (BAYES_50, DCC_REPUT_13_19, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS) 104.47.38.43 mail-bl2nam02on0043.outbound.protection.outlook.com 104.47.38.43 mail-bl2nam02on0043.outbound.protection.outlook.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-loop: dm-devel@redhat.com Cc: device-mapper development Subject: [dm-devel] [PATCH 6/6] multipathd: Remove a busy-waiting loop X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP Use pthread_join() to wait until worker threads have finished instead of using a counter to keep track of how many threads are trying to grab a mutex. Remove mutex_lock.depth since this member variable is no longer needed. This patch fixes two race conditions: * Incrementing "depth" in lock() without holding a mutex. * Destroying a mutex from the main thread without waiting for the worker threads to finish using that mutex. Signed-off-by: Bart Van Assche Acked-by: dragan.stancevic@canonical.com --- libmultipath/lock.h | 15 +-------------- multipathd/main.c | 13 ++++++------- 2 files changed, 7 insertions(+), 21 deletions(-) diff --git a/libmultipath/lock.h b/libmultipath/lock.h index 9808480..a170efe 100644 --- a/libmultipath/lock.h +++ b/libmultipath/lock.h @@ -3,35 +3,22 @@ #include -/* - * Wrapper for the mutex. Includes a ref-count to keep - * track of how many there are out-standing threads blocking - * on a mutex. */ struct mutex_lock { pthread_mutex_t mutex; - int depth; }; static inline void lock(struct mutex_lock *a) { - a->depth++; pthread_mutex_lock(&a->mutex); } static inline int timedlock(struct mutex_lock *a, struct timespec *tmo) { - int r; - - a->depth++; - r = pthread_mutex_timedlock(&a->mutex, tmo); - if (r) - a->depth--; - return r; + return pthread_mutex_timedlock(&a->mutex, tmo); } static inline void unlock(struct mutex_lock *a) { - a->depth--; pthread_mutex_unlock(&a->mutex); } diff --git a/multipathd/main.c b/multipathd/main.c index fff482c..c288195 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -2046,7 +2046,6 @@ init_vecs (void) return NULL; pthread_mutex_init(&vecs->lock.mutex, NULL); - vecs->lock.depth = 0; return vecs; } @@ -2394,16 +2393,16 @@ child (void * param) pthread_cancel(uxlsnr_thr); pthread_cancel(uevq_thr); + pthread_join(check_thr, NULL); + pthread_join(uevent_thr, NULL); + pthread_join(uxlsnr_thr, NULL); + pthread_join(uevq_thr, NULL); + lock(&vecs->lock); free_pathvec(vecs->pathvec, FREE_PATHS); vecs->pathvec = NULL; unlock(&vecs->lock); - /* Now all the waitevent threads will start rushing in. */ - while (vecs->lock.depth > 0) { - sleep (1); /* This is weak. */ - condlog(3, "Have %d wait event checkers threads to de-alloc," - " waiting...", vecs->lock.depth); - } + pthread_mutex_destroy(&vecs->lock.mutex); FREE(vecs); vecs = NULL;