| Message ID | 1491545798-22183-10-git-send-email-bmarzins@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
> -----Original Message----- > From: Benjamin Marzinski [mailto:bmarzins@redhat.com] > Sent: Friday, April 07, 2017 2:17 PM > To: device-mapper development > Cc: Christophe Varoqui; shichangkuo 09727 (Cloud) > Subject: [PATCH 9/9] multipath: fix segfault with disable_changed_wwids > > When a path wwid changes, uev_update_path was dereferencing pp->mpp > without checking if it was NULL. > > Cc: Shichangkuo <shi.changkuo@h3c.com> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > --- > multipathd/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/multipathd/main.c b/multipathd/main.c index 995e580..0c61caa > 100644 > --- a/multipathd/main.c > +++ b/multipathd/main.c > @@ -1002,7 +1002,8 @@ uev_update_path (struct uevent *uev, struct > vectors * vecs) > if (!pp->wwid_changed) { > pp->wwid_changed = 1; > pp->tick = 1; > - dm_fail_path(pp->mpp->alias, pp->dev_t); > + if (pp->mpp) > + dm_fail_path(pp->mpp->alias, pp->dev_t); > } > goto out; > } else > -- > 1.8.3.1 Thanks a lot for your work. It looks good to me, and I will have a test on this patch. Thanks, again. Changkuo ------------------------------------------------------------------------------------------------------------------------------------- 本邮件及其附件含有杭州华三通信技术有限公司的保密信息，仅限于发送给上面地址中列出 的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、 或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本 邮件！ This e-mail and its attachments contain confidential information from H3C, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it! -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/multipathd/main.c b/multipathd/main.c index 995e580..0c61caa 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1002,7 +1002,8 @@ uev_update_path (struct uevent *uev, struct vectors * vecs) if (!pp->wwid_changed) { pp->wwid_changed = 1; pp->tick = 1; - dm_fail_path(pp->mpp->alias, pp->dev_t); + if (pp->mpp) + dm_fail_path(pp->mpp->alias, pp->dev_t); } goto out; } else
When a path wwid changes, uev_update_path was dereferencing pp->mpp without checking if it was NULL. Cc: Shichangkuo <shi.changkuo@h3c.com> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> --- multipathd/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)