| Message ID | 1492035310-27525-2-git-send-email-bmarzins@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Benjamin, On Wed, Apr 12, 2017 at 05:15:09PM -0500, Benjamin Marzinski wrote: > All of the Dell MD3xxx configs are identical, so we can't just use can? ^ > one config for them. > > Cc: Xose Vazquez Perez <xose.vazquez@gmail.com> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > ---
On Wed, 2017-04-12 at 17:15 -0500, Benjamin Marzinski wrote: > All of the Dell MD3xxx configs are identical, so we can't just use > one config for them. > > Cc: Xose Vazquez Perez <xose.vazquez@gmail.com> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > --- Reviewed-by: Martin Wilck <mwilck@suse.com>
On Thu, Apr 13, 2017 at 10:44:43AM +0200, Johannes Thumshirn wrote: > Hi Benjamin, > > On Wed, Apr 12, 2017 at 05:15:09PM -0500, Benjamin Marzinski wrote: > > All of the Dell MD3xxx configs are identical, so we can't just use > can? ^ Oops. Yes. That's what I meant. I can fix the message if people are happy with the idea. -Ben > > one config for them. > > > > Cc: Xose Vazquez Perez <xose.vazquez@gmail.com> > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > > --- > > -- > Johannes Thumshirn Storage > jthumshirn@suse.de +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On 04/13/2017 12:15 AM, Benjamin Marzinski wrote: > All of the Dell MD3xxx configs are identical, so we can't just use > one config for them. If you do that to simplify the config file or minimize the number of RDAC entries. More of them, from (NETAPP|LSI|ENGENIO) IBM SGI STK SUN, can be consolidated: grep -B7 -A2 "PRIO_RDAC" libmultipath/hwtable.c BTW, I did send time ago a kernel patch related to RDAC arrays and it's still waiting for ACK: https://marc.info/?l=linux-scsi&m=147585935707470 > Cc: Xose Vazquez Perez <xose.vazquez@gmail.com> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > --- > libmultipath/hwtable.c | 26 +------------------------- > 1 file changed, 1 insertion(+), 25 deletions(-) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index c944015..54309ef 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -227,31 +227,7 @@ static struct hwentry default_hw[] = { > /* MD Series */ > { > .vendor = "DELL", > - .product = "MD3000", > - .bl_product = "Universal Xport", > - .pgpolicy = GROUP_BY_PRIO, > - .checker_name = RDAC, > - .features = "2 pg_init_retries 50", > - .hwhandler = "1 rdac", > - .prio_name = PRIO_RDAC, > - .pgfailback = -FAILBACK_IMMEDIATE, > - .no_path_retry = 30, > - }, > - { > - .vendor = "DELL", > - .product = "(MD32xx|MD36xx)", > - .bl_product = "Universal Xport", > - .pgpolicy = GROUP_BY_PRIO, > - .checker_name = RDAC, > - .features = "2 pg_init_retries 50", > - .hwhandler = "1 rdac", > - .prio_name = PRIO_RDAC, > - .pgfailback = -FAILBACK_IMMEDIATE, > - .no_path_retry = 30, > - }, > - { > - .vendor = "DELL", > - .product = "(MD34xx|MD38xx)", > + .product = "^MD3", > .bl_product = "Universal Xport", > .pgpolicy = GROUP_BY_PRIO, > .checker_name = RDAC, > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index c944015..54309ef 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -227,31 +227,7 @@ static struct hwentry default_hw[] = { /* MD Series */ { .vendor = "DELL", - .product = "MD3000", - .bl_product = "Universal Xport", - .pgpolicy = GROUP_BY_PRIO, - .checker_name = RDAC, - .features = "2 pg_init_retries 50", - .hwhandler = "1 rdac", - .prio_name = PRIO_RDAC, - .pgfailback = -FAILBACK_IMMEDIATE, - .no_path_retry = 30, - }, - { - .vendor = "DELL", - .product = "(MD32xx|MD36xx)", - .bl_product = "Universal Xport", - .pgpolicy = GROUP_BY_PRIO, - .checker_name = RDAC, - .features = "2 pg_init_retries 50", - .hwhandler = "1 rdac", - .prio_name = PRIO_RDAC, - .pgfailback = -FAILBACK_IMMEDIATE, - .no_path_retry = 30, - }, - { - .vendor = "DELL", - .product = "(MD34xx|MD38xx)", + .product = "^MD3", .bl_product = "Universal Xport", .pgpolicy = GROUP_BY_PRIO, .checker_name = RDAC,
All of the Dell MD3xxx configs are identical, so we can't just use one config for them. Cc: Xose Vazquez Perez <xose.vazquez@gmail.com> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> --- libmultipath/hwtable.c | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-)