| Message ID | 1513188487-31852-2-git-send-email-bmarzins@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
On Wed, 2017-12-13 at 12:08 -0600, Benjamin Marzinski wrote: > With the fix to the features handling code, the multipath device > should > already be reloaded with the correct value for queue_if_no_path, so > there's no need to go reset it immediately afterwards. > > Cc: Martin Wilck <mwilck@suse.com> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > --- > libmultipath/configure.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/libmultipath/configure.c b/libmultipath/configure.c > index bfa5048..6f28f45 100644 > --- a/libmultipath/configure.c > +++ b/libmultipath/configure.c > @@ -1351,12 +1351,6 @@ int reload_map(struct vectors *vecs, struct > multipath *mpp, int refresh, > "for reload map", mpp->alias, r); > return 1; > } > - if (mpp->no_path_retry != NO_PATH_RETRY_UNDEF) { > - if (mpp->no_path_retry == NO_PATH_RETRY_FAIL) > - dm_queue_if_no_path(mpp->alias, 0); > - else > - dm_queue_if_no_path(mpp->alias, 1); > - } > > return 0; > } ACK
Applied. Thanks On Mon, Dec 18, 2017 at 2:49 PM, Martin Wilck <mwilck@suse.com> wrote: > On Wed, 2017-12-13 at 12:08 -0600, Benjamin Marzinski wrote: > > With the fix to the features handling code, the multipath device > > should > > already be reloaded with the correct value for queue_if_no_path, so > > there's no need to go reset it immediately afterwards. > > > > Cc: Martin Wilck <mwilck@suse.com> > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> > > --- > > libmultipath/configure.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/libmultipath/configure.c b/libmultipath/configure.c > > index bfa5048..6f28f45 100644 > > --- a/libmultipath/configure.c > > +++ b/libmultipath/configure.c > > @@ -1351,12 +1351,6 @@ int reload_map(struct vectors *vecs, struct > > multipath *mpp, int refresh, > > "for reload map", mpp->alias, r); > > return 1; > > } > > - if (mpp->no_path_retry != NO_PATH_RETRY_UNDEF) { > > - if (mpp->no_path_retry == NO_PATH_RETRY_FAIL) > > - dm_queue_if_no_path(mpp->alias, 0); > > - else > > - dm_queue_if_no_path(mpp->alias, 1); > > - } > > > > return 0; > > } > ACK > > -- > Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107 > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/configure.c b/libmultipath/configure.c index bfa5048..6f28f45 100644 --- a/libmultipath/configure.c +++ b/libmultipath/configure.c @@ -1351,12 +1351,6 @@ int reload_map(struct vectors *vecs, struct multipath *mpp, int refresh, "for reload map", mpp->alias, r); return 1; } - if (mpp->no_path_retry != NO_PATH_RETRY_UNDEF) { - if (mpp->no_path_retry == NO_PATH_RETRY_FAIL) - dm_queue_if_no_path(mpp->alias, 0); - else - dm_queue_if_no_path(mpp->alias, 1); - } return 0; }
With the fix to the features handling code, the multipath device should already be reloaded with the correct value for queue_if_no_path, so there's no need to go reset it immediately afterwards. Cc: Martin Wilck <mwilck@suse.com> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> --- libmultipath/configure.c | 6 ------ 1 file changed, 6 deletions(-)