From patchwork Wed Jan 17 19:45:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10170631 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 93314603B5 for ; Wed, 17 Jan 2018 19:47:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74D241FFE4 for ; Wed, 17 Jan 2018 19:47:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6812F205AD; Wed, 17 Jan 2018 19:47:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C18C51FFE4 for ; Wed, 17 Jan 2018 19:47:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20AB98B109; Wed, 17 Jan 2018 19:46:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55C3A5D964; Wed, 17 Jan 2018 19:46:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AC92618033D8; Wed, 17 Jan 2018 19:46:46 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w0HJkgRi028720 for ; Wed, 17 Jan 2018 14:46:42 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8F0D04A5; Wed, 17 Jan 2018 19:46:42 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 745FD4AD; Wed, 17 Jan 2018 19:46:32 +0000 (UTC) Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) (using TLSv1.2 with cipher RC4-SHA (112/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BBC6C07012C; Wed, 17 Jan 2018 19:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1516218371; x=1547754371; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=swxnHT/e0siNNXWTUVTKh7lb9nRhCfS7v0Nx2vsLbyU=; b=T4tOhpjrz4N+ZDD+TpRhkWxM5fy79TkfECmXo918ULjwd3YvIn+qFm46 E7dMfuV5LeJvQ4NZmku1TCq9dC477sXQJBtqE149GA0b9VNiWsXWJBUk3 GkZP06cSFr5jDRy4dKP5Tt36LLoAp8ny0oQrmQzC1w0ohqy1XhImS+I2k BpYpr3IbYo7hvAU5pWUiG+lFiyT3riAI3OHNw0wm0pJbgdJhASpFX+/ND wQiLlDqTwkGtos4ADXdkdvnibRqmv3pAMnnWkYb0NxL7wUpXhWN6bIQxh CkslkqAOQ9Sf6JqeROwj6Lr6vLhaZz5rqDNDrVqSuA89+J0qVkH6nOmmu Q==; X-IronPort-AV: E=Sophos;i="5.46,374,1511798400"; d="scan'208";a="69370055" Received: from mail-sn1nam01lp0115.outbound.protection.outlook.com (HELO NAM01-SN1-obe.outbound.protection.outlook.com) ([207.46.163.115]) by ob1.hgst.iphmx.com with ESMTP; 18 Jan 2018 03:45:08 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=swxnHT/e0siNNXWTUVTKh7lb9nRhCfS7v0Nx2vsLbyU=; b=EVS5ua2L5T2o0YkxlQzdlp9ot9kim8uCfWbf4yF2FCjHYVDSFXquqNQpRWyEhWnk7qk9fP2W27TocjFKzJ5rvJG1vTuQeoNcoPM9xqz6mae+HsTGfbMY2P6aZuhgNmXX9WDcyWL0mUxxAq2sdbBBrBHYg4iodxCVYvR6+JWjWNo= Received: from CY1PR0401MB1536.namprd04.prod.outlook.com (10.163.19.154) by CY1PR0401MB1534.namprd04.prod.outlook.com (10.163.19.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Wed, 17 Jan 2018 19:45:05 +0000 Received: from CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) by CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) with mapi id 15.20.0407.012; Wed, 17 Jan 2018 19:45:05 +0000 From: Bart Van Assche To: "snitzer@redhat.com" Thread-Topic: dm-rq queue stalls Thread-Index: my/gnCXPvzGLetNU30e2qZiF3mhizsdeXwsA Date: Wed, 17 Jan 2018 19:45:05 +0000 Message-ID: <1516218304.2820.51.camel@wdc.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR0401MB1534; 7:A7zkBzubNDSecOt9woPCM/SrzYKrdqFYsfKqzV+z4HIdXRPAGZfXvVSaOnUTRGcMx4+EV8pWAjc5Sn4O5Rl6yGOosaVjNd1TKLfr1BtVvwLnQtazet4jYALIfgJue/QCn3jPzYPDW2bxgRtJ1yraI/kLRdUip7HjRGqr0WMoNtTDrtbiXg5ookH/hfG0YJUjmBotqEXryN6ERMFFU+2msfOTaV3qg8WRKTCxQcWJq2i0PSyrbXRg6QZzulMHeoBZ; 20:B18l+yjQB9tzT/INaKGxU3KtyKBjERBhzuzWhHCwxiMvhPf/PN44Z/KleV47HHQnK2XvYoulmz1Si2605N2G5hiHCyiblCiEejM4npvncjyO7EsMD70zPniayTPIzUnZJw/Z5Mka0VxOkx9rJp/RfdhKszNR6x36uR3rrI5b4+8= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 46796561-85b5-4e9e-9d6b-08d55de2ceff x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:CY1PR0401MB1534; x-ms-traffictypediagnostic: CY1PR0401MB1534: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231023)(944501161)(3002001)(6055026)(6041268)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY1PR0401MB1534; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR0401MB1534; x-forefront-prvs: 0555EC8317 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(366004)(39380400002)(376002)(346002)(396003)(24454002)(199004)(189003)(377424004)(86362001)(76176011)(575784001)(36756003)(59450400001)(6512007)(3660700001)(105586002)(6436002)(14454004)(316002)(72206003)(229853002)(26005)(54906003)(102836004)(6306002)(6486002)(966005)(2906002)(6506007)(478600001)(5640700003)(2900100001)(3280700002)(6116002)(2351001)(2501003)(99286004)(305945005)(97736004)(53936002)(5660300001)(2950100002)(3846002)(8676002)(81166006)(7736002)(1730700003)(103116003)(66066001)(6246003)(68736007)(8936002)(3480700004)(6916009)(106356001)(25786009)(4326008)(81156014)(77096007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0401MB1534; H:CY1PR0401MB1536.namprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-microsoft-antispam-message-info: omP8u2XdXCPGV3P+R7AF6e1e8b+o4cWJv4WR1W5xQPLNYSFRNKMKMJHWYu1cZmg+wdjC7fk3gogSgI399dwxZg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <41BC7437D25B564B9F9F00869FA4A6F6@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46796561-85b5-4e9e-9d6b-08d55de2ceff X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2018 19:45:05.8393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1534 X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 207 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 17 Jan 2018 19:46:10 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 17 Jan 2018 19:46:10 +0000 (UTC) for IP:'216.71.153.144' DOMAIN:'esa5.hgst.iphmx.com' HELO:'esa5.hgst.iphmx.com' FROM:'Bart.VanAssche@wdc.com' RCPT:'' X-RedHat-Spam-Score: -0.8 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW) 216.71.153.144 esa5.hgst.iphmx.com 216.71.153.144 esa5.hgst.iphmx.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MIME-Autoconverted: from base64 to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id w0HJkgRi028720 X-loop: dm-devel@redhat.com Cc: "axboe@kernel.dk" , "dm-devel@redhat.com" , "loberman@redhat.com" , "ming.lei@redhat.com" Subject: Re: [dm-devel] dm-rq queue stalls X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 17 Jan 2018 19:47:18 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2018-01-17 at 14:36 -0500, Mike Snitzer wrote: > That tree doesn't have the revert you think it does (because it doesn't have _any_ of the dm-4.16 changes). > > So there is some other reason for your hang. Hello Mike, Please have another look, namely at the following commit: https://github.com/bvanassche/linux/commit/cd0b6b9f8779a0b692b1ef1d1f5ba6cb2fd981c5 That contents of that commit is as follows: Subject: [PATCH] Revert "dm rq: Avoid that request processing stalls sporadically" This reverts commit 6077c2d706097c00d8f2fed57d3f3c45cd228ee8. --- drivers/md/dm-rq.c | 1 - 1 file changed, 1 deletion(-) Thanks, Bart. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c index 85d80b8ccc33..a9e0f6ec62b6 100644 --- a/drivers/md/dm-rq.c +++ b/drivers/md/dm-rq.c @@ -773,7 +773,6 @@ static blk_status_t dm_mq_queue_rq(struct blk_mq_hw_ctx *hctx, /* Undo dm_start_request() before requeuing */ rq_end_stats(md, rq); rq_completed(md, rq_data_dir(rq), false); - blk_mq_delay_run_hw_queue(hctx, 100/*ms*/); return BLK_STS_RESOURCE; }