From patchwork Tue Feb 13 03:42:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Marzinski X-Patchwork-Id: 10215091 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E6945601C2 for ; Tue, 13 Feb 2018 03:46:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D284F28E28 for ; Tue, 13 Feb 2018 03:46:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C6F8A28E2D; Tue, 13 Feb 2018 03:46:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8543628E28 for ; Tue, 13 Feb 2018 03:46:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C8E682A; Tue, 13 Feb 2018 03:46:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D6655D9CA; Tue, 13 Feb 2018 03:46:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 25DB54A46C; Tue, 13 Feb 2018 03:46:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w1D3gPg9014679 for ; Mon, 12 Feb 2018 22:42:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id 4D1DCAEE0F; Tue, 13 Feb 2018 03:42:25 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from redhat.com (octiron.msp.redhat.com [10.15.80.209]) by smtp.corp.redhat.com (Postfix) with SMTP id 28192FD932; Tue, 13 Feb 2018 03:42:24 +0000 (UTC) Received: by redhat.com (sSMTP sendmail emulation); Mon, 12 Feb 2018 21:42:23 -0600 From: "Benjamin Marzinski" To: device-mapper development Date: Mon, 12 Feb 2018 21:42:11 -0600 Message-Id: <1518493334-18170-5-git-send-email-bmarzins@redhat.com> In-Reply-To: <1518493334-18170-1-git-send-email-bmarzins@redhat.com> References: <1518493334-18170-1-git-send-email-bmarzins@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Subject: [dm-devel] [PATCH v3 4/7] multipathd: remove unused configure parameter X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 13 Feb 2018 03:46:35 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP configure() is always called with start_waiters=1, so there is no point in having the parameter. Remove it. Reviewed-by: Martin Wilck Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/multipathd/main.c b/multipathd/main.c index dbf9890..51e0f5e 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1955,7 +1955,7 @@ checkerloop (void *ap) } int -configure (struct vectors * vecs, int start_waiters) +configure (struct vectors * vecs) { struct multipath * mpp; struct path * pp; @@ -2054,11 +2054,9 @@ configure (struct vectors * vecs, int start_waiters) i--; continue; } - if (start_waiters) { - if (start_waiter_thread(mpp, vecs)) { - remove_map(mpp, vecs, 1); - i--; - } + if (start_waiter_thread(mpp, vecs)) { + remove_map(mpp, vecs, 1); + i--; } } return 0; @@ -2125,7 +2123,7 @@ reconfigure (struct vectors * vecs) rcu_assign_pointer(multipath_conf, conf); call_rcu(&old->rcu, rcu_free_config); - configure(vecs, 1); + configure(vecs); return 0;