diff mbox series

[4/4] multipathd: don't trigger uevent for partitions on wwid change

Message ID 1616719966-10221-5-git-send-email-bmarzins@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series Fixups to my wwid recheck patch | expand

Commit Message

Benjamin Marzinski March 26, 2021, 12:52 a.m. UTC
If the wwid changed, the device is no longer the same, so sending add
events to the devices partitions doesn't make any sense.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin Wilck March 26, 2021, 5:16 p.m. UTC | #1
On Thu, 2021-03-25 at 19:52 -0500, Benjamin Marzinski wrote:
> If the wwid changed, the device is no longer the same, so sending add
> events to the devices partitions doesn't make any sense.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

> ---
>  multipathd/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index bc747d0e..3579bad7 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -845,7 +845,6 @@ handle_path_wwid_change(struct path *pp, struct
> vectors *vecs)
>         }
>         rescan_path(udd);
>         sysfs_attr_set_value(udd, "uevent", "add", strlen("add"));
> -       trigger_partitions_udev_change(udd, "add", strlen("add"));
>         udev_device_unref(udd);
>  }
>
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index bc747d0e..3579bad7 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -845,7 +845,6 @@  handle_path_wwid_change(struct path *pp, struct vectors *vecs)
 	}
 	rescan_path(udd);
 	sysfs_attr_set_value(udd, "uevent", "add", strlen("add"));
-	trigger_partitions_udev_change(udd, "add", strlen("add"));
 	udev_device_unref(udd);
 }