diff mbox series

[2/5] multipathd: remove duplicate orphan_paths in flush_map

Message ID 1620775324-23984-3-git-send-email-bmarzins@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series Memory issues found by coverity | expand

Commit Message

Benjamin Marzinski May 11, 2021, 11:22 p.m. UTC
remove_map_and_stop_waiter() already calls orphan_paths() so flush_map()
doesn't need to call orphan_paths() before calling
remove_map_and_stop_waiter().

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin Wilck May 12, 2021, 9:16 a.m. UTC | #1
On Tue, 2021-05-11 at 18:22 -0500, Benjamin Marzinski wrote:
> remove_map_and_stop_waiter() already calls orphan_paths() so
> flush_map()
> doesn't need to call orphan_paths() before calling
> remove_map_and_stop_waiter().
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>

> ---
>  multipathd/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 449ce384..6090434c 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -660,7 +660,6 @@ flush_map(struct multipath * mpp, struct vectors *
> vecs, int nopaths)
>         else
>                 condlog(2, "%s: map flushed", mpp->alias);
>  
> -       orphan_paths(vecs->pathvec, mpp, "map flushed");
>         remove_map_and_stop_waiter(mpp, vecs);
>  
>         return 0;



--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index 449ce384..6090434c 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -660,7 +660,6 @@  flush_map(struct multipath * mpp, struct vectors * vecs, int nopaths)
 	else
 		condlog(2, "%s: map flushed", mpp->alias);
 
-	orphan_paths(vecs->pathvec, mpp, "map flushed");
 	remove_map_and_stop_waiter(mpp, vecs);
 
 	return 0;