diff mbox series

[7/7] multipathd: Remove dependency on systemd-udev-settle.service

Message ID 1634757322-6015-8-git-send-email-bmarzins@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipathd: remove udev settle dependency | expand

Commit Message

Benjamin Marzinski Oct. 20, 2021, 7:15 p.m. UTC
multipathd can now handle starting up with incompletely initialized
paths, so it no longer needs to wait for the device Coldplug to
complete. However multipathd may need to write to /etc (for the wwids
and bindings files), so in needs to wait for the root filesystem to
be remounted read/write before starting.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/multipathd.service | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Martin Wilck Nov. 4, 2021, 10:17 p.m. UTC | #1
On Wed, 2021-10-20 at 14:15 -0500, Benjamin Marzinski wrote:
> multipathd can now handle starting up with incompletely initialized
> paths, so it no longer needs to wait for the device Coldplug to
> complete. However multipathd may need to write to /etc (for the wwids
> and bindings files), so in needs to wait for the root filesystem to
> be remounted read/write before starting.

Side note: This reminds me of the fact that daemons writing to /etc are
deprecated these days. One day we should move the default location of
the bindings file to /var/lib/multipath or the like.

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>



--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index 0b2ac814..87cb5349 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -1,9 +1,8 @@ 
 [Unit]
 Description=Device-Mapper Multipath Device Controller
-Wants=systemd-udev-trigger.service systemd-udev-settle.service
 Before=iscsi.service iscsid.service lvm2-activation-early.service
 Before=local-fs-pre.target blk-availability.service shutdown.target
-After=multipathd.socket systemd-udev-trigger.service systemd-udev-settle.service
+After=multipathd.socket systemd-remount-fs.service
 DefaultDependencies=no
 Conflicts=shutdown.target
 ConditionKernelCommandLine=!nompath