| Message ID | 1657663371-11080-1-git-send-email-bmarzins@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | libmultipath: fix find_multipaths_timeout for unknown hardware | expand |
On Tue, 2022-07-12 at 17:02 -0500, Benjamin Marzinski wrote: > pp->hwe is now a vector that will always be allocated for all path > devices. Instead of checking if it is NULL, check if it is empty. > > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> Reviewed-by: Martin Wilck <mwilck@suse.com> > --- > libmultipath/propsel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c > index 50d0b5c8..f782f251 100644 > --- a/libmultipath/propsel.c > +++ b/libmultipath/propsel.c > @@ -1293,7 +1293,7 @@ out: > */ > if (pp->find_multipaths_timeout < 0) { > pp->find_multipaths_timeout = -pp- > >find_multipaths_timeout; > - if (!pp->hwe) { > + if (VECTOR_SIZE(pp->hwe) == 0) { > pp->find_multipaths_timeout = > DEFAULT_UNKNOWN_FIND_MULTIPATHS_TIMEO > UT; > origin = "(default for unknown hardware)"; -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c index 50d0b5c8..f782f251 100644 --- a/libmultipath/propsel.c +++ b/libmultipath/propsel.c @@ -1293,7 +1293,7 @@ out: */ if (pp->find_multipaths_timeout < 0) { pp->find_multipaths_timeout = -pp->find_multipaths_timeout; - if (!pp->hwe) { + if (VECTOR_SIZE(pp->hwe) == 0) { pp->find_multipaths_timeout = DEFAULT_UNKNOWN_FIND_MULTIPATHS_TIMEOUT; origin = "(default for unknown hardware)";
pp->hwe is now a vector that will always be allocated for all path devices. Instead of checking if it is NULL, check if it is empty. Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> --- libmultipath/propsel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)