Message ID | 20090625182302.GA23113@redhat.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers | show |
On Thursday 25 June 2009, Mike Snitzer wrote: > OK, I found a really stupid bug. I was passing the data start offset > (pe_start) through to blk_stack_limits() in terms of sectors rather > than bytes. The following should silence your warnings: Yes, all clear again. So not broken userspace after all ;-) Reported-by: Frans Pop <elendil@planet.nl> Tested-by: Frans Pop <elendil@planet.nl> Thanks, FJP > diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c > index 4899ebe..2cba557 100644 > --- a/drivers/md/dm-table.c > +++ b/drivers/md/dm-table.c > @@ -495,7 +495,7 @@ int dm_set_device_limits(struct dm_target *ti, > struct dm_dev *dev, return 0; > } > > - if (blk_stack_limits(limits, &q->limits, start) < 0) > + if (blk_stack_limits(limits, &q->limits, start << 9) < 0) > DMWARN("%s: target device %s is misaligned", > dm_device_name(ti->table->md), bdevname(bdev, b)); -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 4899ebe..2cba557 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -495,7 +495,7 @@ int dm_set_device_limits(struct dm_target *ti, struct dm_dev *dev, return 0; } - if (blk_stack_limits(limits, &q->limits, start) < 0) + if (blk_stack_limits(limits, &q->limits, start << 9) < 0) DMWARN("%s: target device %s is misaligned", dm_device_name(ti->table->md), bdevname(bdev, b));