From patchwork Fri Oct 2 11:59:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryo Tsuruta X-Patchwork-Id: 51340 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n92BxEAS004994 for ; Fri, 2 Oct 2009 11:59:14 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id 441A5619541; Fri, 2 Oct 2009 07:59:14 -0400 (EDT) Received: from int-mx04.intmail.prod.int.phx2.redhat.com (nat-pool.util.phx.redhat.com [10.8.5.200]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n92BxDMD029530 for ; Fri, 2 Oct 2009 07:59:13 -0400 Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.14]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n92BxCuH015599 for ; Fri, 2 Oct 2009 07:59:13 -0400 Received: from mail.valinux.co.jp (mail.valinux.co.jp [210.128.90.3]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n92Bx5lk016493 for ; Fri, 2 Oct 2009 07:59:05 -0400 Received: from localhost (kappa.local.valinux.co.jp [172.16.2.46]) by mail.valinux.co.jp (Postfix) with ESMTP id AC45249CEC; Fri, 2 Oct 2009 20:59:04 +0900 (JST) Date: Fri, 02 Oct 2009 20:59:04 +0900 (JST) Message-Id: <20091002.205904.39183199.ryov@valinux.co.jp> To: linux-kernel@vger.kernel.org, dm-devel@redhat.com, containers@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xensource.com From: Ryo Tsuruta In-Reply-To: <20091002.205843.183050041.ryov@valinux.co.jp> References: <20091002.205748.189700030.ryov@valinux.co.jp> <20091002.205817.112597159.ryov@valinux.co.jp> <20091002.205843.183050041.ryov@valinux.co.jp> Mime-Version: 1.0 X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-RedHat-Spam-Score: -0.637 (AWL) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-Scanned-By: MIMEDefang 2.67 on 10.5.110.14 X-loop: dm-devel@redhat.com Cc: Subject: [dm-devel] [PATCH 8/9] blkio-cgroup-v13: Add a cgroup support to dm-ioband X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Index: linux-2.6.32-rc1/include/linux/biotrack.h =================================================================== --- linux-2.6.32-rc1.orig/include/linux/biotrack.h +++ linux-2.6.32-rc1/include/linux/biotrack.h @@ -9,6 +9,7 @@ struct io_context; struct block_device; +struct ioband_cgroup_ops; struct blkio_cgroup { struct cgroup_subsys_state css; @@ -48,6 +49,12 @@ extern void blkio_cgroup_copy_owner(stru extern struct io_context *get_blkio_cgroup_iocontext(struct bio *bio); extern unsigned long get_blkio_cgroup_id(struct bio *bio); extern struct cgroup *get_cgroup_from_page(struct page *page); +extern int blkio_cgroup_register_ioband(const struct ioband_cgroup_ops *ops); + +static inline int blkio_cgroup_unregister_ioband(void) +{ + return blkio_cgroup_register_ioband(NULL); +} #else /* !CONFIG_CGROUP_BLKIO */ Index: linux-2.6.32-rc1/mm/biotrack.c =================================================================== --- linux-2.6.32-rc1.orig/mm/biotrack.c +++ linux-2.6.32-rc1/mm/biotrack.c @@ -20,6 +20,9 @@ #include #include #include +#include +#include +#include <../drivers/md/dm-ioband.h> /* * The block I/O tracking mechanism is implemented on the cgroup memory @@ -46,6 +49,8 @@ static struct io_context default_blkio_i static struct blkio_cgroup default_blkio_cgroup = { .io_context = &default_blkio_io_context, }; +static DEFINE_MUTEX(ioband_ops_lock); +static const struct ioband_cgroup_ops *ioband_ops; /** * blkio_cgroup_set_owner() - set the owner ID of a page. @@ -181,6 +186,14 @@ blkio_cgroup_create(struct cgroup_subsys static void blkio_cgroup_destroy(struct cgroup_subsys *ss, struct cgroup *cgrp) { struct blkio_cgroup *biog = cgroup_blkio(cgrp); + int id; + + mutex_lock(&ioband_ops_lock); + if (ioband_ops) { + id = css_id(&biog->css); + ioband_ops->remove_group(id); + } + mutex_unlock(&ioband_ops_lock); put_io_context(biog->io_context); free_css_id(&blkio_cgroup_subsys, &biog->css); @@ -261,6 +274,25 @@ struct cgroup *get_cgroup_from_page(stru } EXPORT_SYMBOL(get_cgroup_from_page); +/** + * blkio_cgroup_register_ioband() - register ioband + * @p: a pointer to struct ioband_cgroup_ops + * + * Calling with NULL means unregistration. + * Returns 0 on success. + */ +int blkio_cgroup_register_ioband(const struct ioband_cgroup_ops *p) +{ + if (blkio_cgroup_disabled()) + return -1; + + mutex_lock(&ioband_ops_lock); + ioband_ops = p; + mutex_unlock(&ioband_ops_lock); + return 0; +} +EXPORT_SYMBOL(blkio_cgroup_register_ioband); + /* Read the ID of the specified blkio cgroup. */ static u64 blkio_id_read(struct cgroup *cgrp, struct cftype *cft) { @@ -269,11 +301,131 @@ static u64 blkio_id_read(struct cgroup * return (u64)css_id(&biog->css); } +/* Show all ioband devices and their settings. */ +static int blkio_devs_read(struct cgroup *cgrp, struct cftype *cft, + struct seq_file *m) +{ + mutex_lock(&ioband_ops_lock); + if (ioband_ops) + ioband_ops->show_device(m); + mutex_unlock(&ioband_ops_lock); + return 0; +} + +/* Configure ioband devices specified by an ioband device ID */ +static int blkio_devs_write(struct cgroup *cgrp, struct cftype *cft, + const char *buffer) +{ + char **argv; + int argc, r = 0; + + if (cgrp != cgrp->top_cgroup) + return -EACCES; + + argv = argv_split(GFP_KERNEL, buffer, &argc); + if (!argv) + return -ENOMEM; + + mutex_lock(&ioband_ops_lock); + if (ioband_ops) + r = ioband_ops->config_device(argc, argv); + mutex_unlock(&ioband_ops_lock); + + argv_free(argv); + return r; +} + +/* Show the information of the specified blkio cgroup. */ +static int blkio_group_read(struct cgroup *cgrp, struct cftype *cft, + struct seq_file *m) +{ + struct blkio_cgroup *biog; + int id; + + mutex_lock(&ioband_ops_lock); + if (ioband_ops) { + biog = cgroup_blkio(cgrp); + id = css_id(&biog->css); + ioband_ops->show_group(m, cft->private, id); + } + mutex_unlock(&ioband_ops_lock); + return 0; +} + +/* Configure the specified blkio cgroup. */ +static int blkio_group_config_write(struct cgroup *cgrp, struct cftype *cft, + const char *buffer) +{ + struct blkio_cgroup *biog; + char **argv; + int argc, parent, id, r = 0; + + argv = argv_split(GFP_KERNEL, buffer, &argc); + if (!argv) + return -ENOMEM; + + mutex_lock(&ioband_ops_lock); + if (ioband_ops) { + if (cgrp == cgrp->top_cgroup) + parent = 0; + else { + biog = cgroup_blkio(cgrp->parent); + parent = css_id(&biog->css); + } + biog = cgroup_blkio(cgrp); + id = css_id(&biog->css); + r = ioband_ops->config_group(argc, argv, parent, id); + } + mutex_unlock(&ioband_ops_lock); + argv_free(argv); + return r; +} + +/* Reset the statictics counter of the specified blkio cgroup. */ +static int blkio_group_stats_write(struct cgroup *cgrp, struct cftype *cft, + const char *buffer) +{ + struct blkio_cgroup *biog; + char **argv; + int argc, id, r = 0; + + argv = argv_split(GFP_KERNEL, buffer, &argc); + if (!argv) + return -ENOMEM; + + mutex_lock(&ioband_ops_lock); + if (ioband_ops) { + biog = cgroup_blkio(cgrp); + id = css_id(&biog->css); + r = ioband_ops->reset_group_stats(argc, argv, id); + } + mutex_unlock(&ioband_ops_lock); + argv_free(argv); + return r; +} + static struct cftype blkio_files[] = { { .name = "id", .read_u64 = blkio_id_read, }, + { + .name = "devices", + .read_seq_string = blkio_devs_read, + .write_string = blkio_devs_write, + }, + { + .name = "settings", + .read_seq_string = blkio_group_read, + .write_string = blkio_group_config_write, + .private = IOG_INFO_CONFIG, + }, + { + .name = "stats", + .read_seq_string = blkio_group_read, + .write_string = blkio_group_stats_write, + .private = IOG_INFO_STATS, + }, }; static int blkio_cgroup_populate(struct cgroup_subsys *ss, struct cgroup *cgrp) Index: linux-2.6.32-rc1/drivers/md/dm-ioctl.c =================================================================== --- linux-2.6.32-rc1.orig/drivers/md/dm-ioctl.c +++ linux-2.6.32-rc1/drivers/md/dm-ioctl.c @@ -1601,3 +1601,4 @@ out: return r; } +EXPORT_SYMBOL(dm_copy_name_and_uuid); Index: linux-2.6.32-rc1/drivers/md/dm-ioband-policy.c =================================================================== --- linux-2.6.32-rc1.orig/drivers/md/dm-ioband-policy.c +++ linux-2.6.32-rc1/drivers/md/dm-ioband-policy.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "dm.h" #include "dm-ioband.h" @@ -360,7 +361,7 @@ static int policy_weight_param(struct io if (value) err = strict_strtol(value, 0, &val); - if (!strcmp(cmd, "weight")) { + if (!cmd || !strcmp(cmd, "weight")) { if (!value) r = set_weight(gp, DEFAULT_WEIGHT); else if (!err && 0 < val && val <= SHORT_MAX) @@ -425,6 +426,19 @@ static void policy_weight_show(struct io *szp = sz; } +static void policy_weight_show_device(struct seq_file *m, + struct ioband_device *dp) +{ + seq_printf(m, " token=%d carryover=%d", + dp->g_token_bucket, dp->g_carryover); +} + +static void policy_weight_show_group(struct seq_file *m, + struct ioband_group *gp) +{ + seq_printf(m, " weight=%d%%", gp->c_weight); +} + /* * * g_can_submit : To determine whether a given group has the right to @@ -453,6 +467,8 @@ static void policy_weight_show(struct io * Return 1 if a given group can't receive any more BIOs, * otherwise return 0. * g_show : Show the configuration. + * g_show_device : Show the configuration of the specified ioband device. + * g_show_group : Show the configuration of the spacified ioband group. */ static int policy_weight_init(struct ioband_device *dp, int argc, char **argv) { @@ -475,6 +491,8 @@ static int policy_weight_init(struct iob dp->g_set_param = policy_weight_param; dp->g_should_block = is_queue_full; dp->g_show = policy_weight_show; + dp->g_show_device = policy_weight_show_device; + dp->g_show_group = policy_weight_show_group; dp->g_epoch = 0; dp->g_weight_total = 0; Index: linux-2.6.32-rc1/drivers/md/dm-ioband-rangebw.c =================================================================== --- linux-2.6.32-rc1.orig/drivers/md/dm-ioband-rangebw.c +++ linux-2.6.32-rc1/drivers/md/dm-ioband-rangebw.c @@ -25,6 +25,7 @@ #include #include #include +#include #include "dm.h" #include "md.h" #include "dm-ioband.h" @@ -456,7 +457,7 @@ static int policy_range_bw_param(struct err++; } - if (!strcmp(cmd, "range-bw")) { + if (!cmd || !strcmp(cmd, "range-bw")) { if (!err && 0 <= min_val && min_val <= (INT_MAX / 2) && 0 <= max_val && max_val <= (INT_MAX / 2) && min_val <= max_val) @@ -544,6 +545,12 @@ static void policy_range_bw_show(struct *szp = sz; } +static void policy_range_bw_show_group(struct seq_file *m, + struct ioband_group *gp) +{ + seq_printf(m, " range-bw=%d:%d", gp->c_min_bw, gp->c_max_bw); +} + static int range_bw_prepare_token(struct ioband_group *gp, struct bio *bio, int flag) { @@ -630,6 +637,8 @@ static void range_bw_timeover(unsigned l * Return 1 if a given group can't receive any more BIOs, * otherwise return 0. * g_show : Show the configuration. + * g_show_device : Show the configuration of the specified ioband device. + * g_show_group : Show the configuration of the spacified ioband group. */ int policy_range_bw_init(struct ioband_device *dp, int argc, char **argv) @@ -653,6 +662,8 @@ int policy_range_bw_init(struct ioband_d dp->g_set_param = policy_range_bw_param; dp->g_should_block = range_bw_queue_full; dp->g_show = policy_range_bw_show; + dp->g_show_device = NULL; + dp->g_show_group = policy_range_bw_show_group; dp->g_min_bw_total = 0; dp->g_running_gp = NULL; Index: linux-2.6.32-rc1/drivers/md/dm-ioband-ctl.c =================================================================== --- linux-2.6.32-rc1.orig/drivers/md/dm-ioband-ctl.c +++ linux-2.6.32-rc1/drivers/md/dm-ioband-ctl.c @@ -15,6 +15,8 @@ #include #include #include +#include +#include #include "dm.h" #include "md.h" #include "dm-ioband.h" @@ -108,6 +110,7 @@ static struct ioband_device *alloc_ioban INIT_DELAYED_WORK(&new_dp->g_conductor, ioband_conduct); INIT_LIST_HEAD(&new_dp->g_groups); INIT_LIST_HEAD(&new_dp->g_list); + INIT_LIST_HEAD(&new_dp->g_heads); INIT_LIST_HEAD(&new_dp->g_root_groups); spin_lock_init(&new_dp->g_lock); bio_list_init(&new_dp->g_urgent_bios); @@ -249,6 +252,7 @@ static int ioband_group_init(struct ioba int r; INIT_LIST_HEAD(&gp->c_list); + INIT_LIST_HEAD(&gp->c_heads); INIT_LIST_HEAD(&gp->c_sibling); INIT_LIST_HEAD(&gp->c_children); gp->c_parent = parent; @@ -291,7 +295,8 @@ static int ioband_group_init(struct ioba ioband_group_add_node(&head->c_group_root, gp); gp->c_dev = head->c_dev; gp->c_target = head->c_target; - } + } else + list_add_tail(&gp->c_heads, &dp->g_heads); spin_unlock_irqrestore(&dp->g_lock, flags); return 0; @@ -306,6 +311,8 @@ static void ioband_group_release(struct list_del(&gp->c_sibling); if (head) rb_erase(&gp->c_group_node, &head->c_group_root); + else + list_del(&gp->c_heads); dp->g_group_dtr(gp); kfree(gp); } @@ -1351,6 +1358,235 @@ static struct target_type ioband_target .iterate_devices = ioband_iterate_devices, }; +#ifdef CONFIG_CGROUP_BLKIO +/* Copy mapped device name into supplied buffers */ +static void ioband_copy_name(struct ioband_group *gp, char *name) +{ + struct mapped_device *md; + + md = dm_table_get_md(gp->c_target->table); + dm_copy_name_and_uuid(md, name, NULL); + dm_put(md); +} + +/* Show all ioband devices and their settings */ +static void ioband_cgroup_show_device(struct seq_file *m) +{ + struct ioband_device *dp; + struct ioband_group *head; + char name[DM_NAME_LEN]; + + mutex_lock(&ioband_lock); + list_for_each_entry(dp, &ioband_device_list, g_list) { + seq_printf(m, "%s policy=%s io_throttle=%d io_limit=%d", + dp->g_name, dp->g_policy->p_name, + dp->g_io_throttle, dp->g_io_limit); + if (dp->g_show_device) + dp->g_show_device(m, dp); + seq_putc(m, '\n'); + + list_for_each_entry(head, &dp->g_heads, c_heads) { + if (strcmp(head->c_type->t_name, "cgroup")) + continue; + ioband_copy_name(head, name); + seq_printf(m, " %s\n", name); + } + } + mutex_unlock(&ioband_lock); +} + +/* Configure the ioband device specified by share name or device name */ +static int ioband_cgroup_config_device(int argc, char **argv) +{ + struct ioband_device *dp; + struct ioband_group *head; + char name[DM_NAME_LEN]; + int r; + + if (argc < 1) + return -EINVAL; + + mutex_lock(&ioband_lock); + list_for_each_entry(dp, &ioband_device_list, g_list) { + /* lookup by share name */ + if (!strcmp(dp->g_name, argv[0])) { + head = list_first_entry(&dp->g_heads, + struct ioband_group, c_heads); + goto found; + } + + /* lookup by device name */ + list_for_each_entry(head, &dp->g_heads, c_heads) { + ioband_copy_name(head, name); + if (!strcmp(name, argv[0])) + goto found; + } + } + mutex_unlock(&ioband_lock); + return -ENODEV; + +found: + if (!strcmp(head->c_type->t_name, "cgroup")) + r = __ioband_message(head->c_target, --argc, &argv[1]); + else + r = -ENODEV; + + mutex_unlock(&ioband_lock); + return r; +} + +/* Show the settings of the blkio cgroup specified by ID */ +static void ioband_cgroup_show_group(struct seq_file *m, int type, int id) +{ + struct ioband_device *dp; + struct ioband_group *head, *gp; + struct disk_stats *st; + char name[DM_NAME_LEN]; + unsigned long flags; + + mutex_lock(&ioband_lock); + list_for_each_entry(dp, &ioband_device_list, g_list) { + list_for_each_entry(head, &dp->g_heads, c_heads) { + if (strcmp(head->c_type->t_name, "cgroup")) + continue; + + gp = (id == 1) ? head : ioband_group_find(head, id); + if (!gp) + continue; + + ioband_copy_name(head, name); + seq_puts(m, name); + + switch (type) { + case IOG_INFO_CONFIG: + if (dp->g_show_group) + dp->g_show_group(m, gp); + break; + case IOG_INFO_STATS: + st = &gp->c_stats; + spin_lock_irqsave(&dp->g_lock, flags); + seq_printf(m, " %lu %lu %lu %lu" + " %lu %lu %lu %lu %d %lu %lu", + st->ios[0], st->merges[0], + st->sectors[0], st->ticks[0], + st->ios[1], st->merges[1], + st->sectors[1], st->ticks[1], + nr_blocked_group(gp), + st->io_ticks, st->time_in_queue); + spin_unlock_irqrestore(&dp->g_lock, flags); + break; + } + seq_putc(m, '\n'); + } + } + mutex_unlock(&ioband_lock); +} + +/* Configure the blkio cgroup specified by device name and group ID */ +static int ioband_cgroup_config_group(int argc, char **argv, + int parent, int id) +{ + struct ioband_device *dp; + struct ioband_group *head, *gp; + char name[DM_NAME_LEN]; + int r; + + if (argc != 1 && argc != 2) + return -EINVAL; + + mutex_lock(&ioband_lock); + list_for_each_entry(dp, &ioband_device_list, g_list) { + list_for_each_entry(head, &dp->g_heads, c_heads) { + if (strcmp(head->c_type->t_name, "cgroup")) + continue; + ioband_copy_name(head, name); + if (!strcmp(name, argv[0])) + goto found; + } + } + mutex_unlock(&ioband_lock); + return -ENODEV; + +found: + if (argc == 1) { + /* remove the group unless it is not a root cgroup */ + r = (id == 1) ? -EINVAL : ioband_group_detach(head, id); + } else { + /* create a group or modify the group settings */ + gp = (id == 1) ? head : ioband_group_find(head, id); + + if (!gp) + r = ioband_group_attach(head, parent, id, argv[1]); + else + r = gp->c_banddev->g_set_param(gp, NULL, argv[1]); + } + + mutex_unlock(&ioband_lock); + return r; +} + +/* + * Reset the statistics counter of the blkio cgroup specified by + * device name and group ID. + */ +static int ioband_cgroup_reset_group_stats(int argc, char **argv, int id) +{ + struct ioband_device *dp; + struct ioband_group *head, *gp; + char name[DM_NAME_LEN]; + + if (argc != 1) + return -EINVAL; + + mutex_lock(&ioband_lock); + list_for_each_entry(dp, &ioband_device_list, g_list) { + list_for_each_entry(head, &dp->g_heads, c_heads) { + if (strcmp(head->c_type->t_name, "cgroup")) + continue; + ioband_copy_name(head, name); + if (strcmp(name, argv[0])) + continue; + + gp = (id == 1) ? head : ioband_group_find(head, id); + if (gp) + memset(&gp->c_stats, 0, sizeof(gp->c_stats)); + + mutex_unlock(&ioband_lock); + return 0; + } + } + mutex_unlock(&ioband_lock); + return -ENODEV; +} + +/* Remove the blkio cgroup specified by ID */ +static void ioband_cgroup_remove_group(int id) +{ + struct ioband_device *dp; + struct ioband_group *head; + + mutex_lock(&ioband_lock); + list_for_each_entry(dp, &ioband_device_list, g_list) { + list_for_each_entry(head, &dp->g_heads, c_heads) { + if (strcmp(head->c_type->t_name, "cgroup")) + continue; + if (ioband_group_find(head, id)) + ioband_group_detach(head, id); + } + } + mutex_unlock(&ioband_lock); +} + +static const struct ioband_cgroup_ops ioband_ops = { + .show_device = ioband_cgroup_show_device, + .config_device = ioband_cgroup_config_device, + .show_group = ioband_cgroup_show_group, + .config_group = ioband_cgroup_config_group, + .reset_group_stats = ioband_cgroup_reset_group_stats, + .remove_group = ioband_cgroup_remove_group, +}; +#endif + static int __init dm_ioband_init(void) { int r; @@ -1358,11 +1594,18 @@ static int __init dm_ioband_init(void) r = dm_register_target(&ioband_target); if (r < 0) DMERR("register failed %d", r); +#ifdef CONFIG_CGROUP_BLKIO + else + r = blkio_cgroup_register_ioband(&ioband_ops); +#endif return r; } static void __exit dm_ioband_exit(void) { +#ifdef CONFIG_CGROUP_BLKIO + blkio_cgroup_unregister_ioband(); +#endif dm_unregister_target(&ioband_target); } Index: linux-2.6.32-rc1/drivers/md/dm-ioband.h =================================================================== --- linux-2.6.32-rc1.orig/drivers/md/dm-ioband.h +++ linux-2.6.32-rc1/drivers/md/dm-ioband.h @@ -44,6 +44,7 @@ struct ioband_device { int g_ref; struct list_head g_list; + struct list_head g_heads; struct list_head g_root_groups; int g_flags; char g_name[IOBAND_NAME_MAX + 1]; @@ -60,6 +61,8 @@ struct ioband_device { int (*g_set_param) (struct ioband_group *, const char *, const char *); int (*g_should_block) (struct ioband_group *, int); void (*g_show) (struct ioband_group *, int *, char *, unsigned); + void (*g_show_device) (struct seq_file *, struct ioband_device *); + void (*g_show_group) (struct seq_file *, struct ioband_group *); /* members for weight balancing policy */ int g_epoch; @@ -99,6 +102,7 @@ struct ioband_device { struct ioband_group { struct list_head c_list; + struct list_head c_heads; struct list_head c_sibling; struct list_head c_children; struct ioband_group *c_parent; @@ -150,6 +154,20 @@ struct ioband_group { }; +struct blkio_cgroup; + +struct ioband_cgroup_ops { + void (*show_device)(struct seq_file *); + int (*config_device)(int, char **); + void (*show_group)(struct seq_file *, int, int); + int (*config_group)(int, char **, int, int); + int (*reset_group_stats)(int, char **, int); + void (*remove_group)(int); +}; + +#define IOG_INFO_CONFIG 0 +#define IOG_INFO_STATS 1 + #define IOBAND_URGENT 1 #define DEV_BIO_BLOCKED_ASYNC 1 Index: linux-2.6.32-rc1/drivers/md/dm-ioband-type.c =================================================================== --- linux-2.6.32-rc1.orig/drivers/md/dm-ioband-type.c +++ linux-2.6.32-rc1/drivers/md/dm-ioband-type.c @@ -6,6 +6,7 @@ * This file is released under the GPL. */ #include +#include #include "dm.h" #include "dm-ioband.h" @@ -52,14 +53,7 @@ static int ioband_node(struct bio *bio) static int ioband_cgroup(struct bio *bio) { - /* - * This function should return the ID of the cgroup which - * issued "bio". The ID of the cgroup which the current - * process belongs to won't be suitable ID for this purpose, - * since some BIOs will be handled by kernel threads like aio - * or pdflush on behalf of the process requesting the BIOs. - */ - return 0; /* not implemented yet */ + return get_blkio_cgroup_id(bio); } const struct ioband_group_type dm_ioband_group_type[] = {