From patchwork Mon Dec 5 22:39:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xose Vazquez Perez X-Patchwork-Id: 9461693 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C81A60231 for ; Mon, 5 Dec 2016 22:40:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DDC727F95 for ; Mon, 5 Dec 2016 22:40:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 22AF727FB0; Mon, 5 Dec 2016 22:40:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7472E27F95 for ; Mon, 5 Dec 2016 22:40:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id uB5MdFiF013932; Mon, 5 Dec 2016 17:39:16 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id uB5MdECR012845 for ; Mon, 5 Dec 2016 17:39:14 -0500 Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB5MdDUP004300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 5 Dec 2016 17:39:13 -0500 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94B1E7F7AD for ; Mon, 5 Dec 2016 22:39:11 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id m203so18405852wma.3 for ; Mon, 05 Dec 2016 14:39:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=UNF63lNVUUiqdUpVi527Nq1IcQhDZxr/PZX8mvdnhQ0=; b=JX9rvba8qLhUAnEl/vT99g3bvHMrmFLZ/SxWYMdZmhTuwq705E3BSmJ1gSsf9ezGoj 7IQVe3Kuo45QS08UXca3SDsFhkp0OsCBihauzsAiaP0qg36P3/NZGEcmXzXTnYEGrQy2 aWdAO9Ev1HgCx1gNcraQhcVfbV+oo8q0g0LiqpnK2RAMhDzlYlNQtRq8zl6MlqO0QFZz 1qab+0PSl9KLKLEBXvb2ghYyquRQeBIjUP+f0pE6p4aG0OWKqV18tlNRvjrio9PP+YVt QEgYI4tuezSOMEcBvl/bHPmxfxAQNGtpYoER8EZkcXgDpwpV4+gWlGfY8+1+PmdyxtCh WsDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UNF63lNVUUiqdUpVi527Nq1IcQhDZxr/PZX8mvdnhQ0=; b=T3tFBLNilIQhWaYbg3xfaCHyWg6g4cwn+82rjQxEo2hbkKMP36pcHtpA3a+Iiop3IG KpSg3vAFC+OTU3r+RD2gl7RPgU0qE+5rAVC3DyvzV2aOPRLJyJn5axaS+E2REprh+Rr7 HDaRuWhn/TFWB4zzuzhJJfoMS6svTpJhuem6hxVLm9ueXY90nfq1D91LWt/fWsGb3JRA uUaJrdjFfXCgGWAciBFSPCxkxoNA8NYyQBPgZZ/W+hWDoQ8K3m698VtosBLNnPJaE8Sz YSNtWrsmN4YMcxSw2VWKNiyWNZs0KaFGg2fvg0slI2gCrKRlXmM2UhSfscG/Fnelhc/2 bw2A== X-Gm-Message-State: AKaTC01GGszgfJ5aCXdUpCp1P72I6qHsJmCYzmMwc/vphfF4rQKhg16behFvKdjkARaSuQ== X-Received: by 10.28.133.144 with SMTP id h138mr47669wmd.12.1480977550241; Mon, 05 Dec 2016 14:39:10 -0800 (PST) Received: from localhost (232.196.218.87.dynamic.jazztel.es. [87.218.196.232]) by smtp.gmail.com with ESMTPSA id ei2sm22521879wjd.47.2016.12.05.14.39.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Dec 2016 14:39:09 -0800 (PST) From: Xose Vazquez Perez To: Date: Mon, 5 Dec 2016 23:39:08 +0100 Message-Id: <20161205223908.5486-1-xose.vazquez@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 05 Dec 2016 22:39:11 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 05 Dec 2016 22:39:11 +0000 (UTC) for IP:'74.125.82.65' DOMAIN:'mail-wm0-f65.google.com' HELO:'mail-wm0-f65.google.com' FROM:'xose.vazquez@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.17 * (BAYES_50, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, SPF_PASS) 74.125.82.65 mail-wm0-f65.google.com 74.125.82.65 mail-wm0-f65.google.com X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-loop: dm-devel@redhat.com Cc: Bart Van Assche , device-mapper development , Xose Vazquez Perez Subject: [dm-devel] [PATCH] multipath-tools: remove CFLAGS from shared libs compilation options X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP Changed from: cc -shared -Wl,-soname=libmpathcmd.so.0 -O2 -g -pipe -Wall -Wextra -Wformat=2 -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -o libmpathcmd.so.0 mpath_cmd.o cc -shared -Wl,-soname=libmultipath.so.0 -O2 -g -pipe -Wall -Wextra -Wformat=2 -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmpathcmd -DUSE_SYSTEMD=231 -DLIBDM_API_FLUSH -D_GNU_SOURCE -DLIBDM_API_COOKIE -DLIBUDEV_API_RECVBUF -DLIBDM_API_DEFERRED -o libmultipath.so.0 memory.o parser.o vector.o devmapper.o callout.o hwtable.o blacklist.o util.o dmparser.o config.o structs.o discovery.o propsel.o dict.o pgpolicies.o debug.o defaults.o uevent.o time-util.o switchgroup.o uxsock.o print.o alias.o log_pthread.o log.o configure.o structs_vec.o sysfs.o prio.o checkers.o lock.o waiter.o file.o wwids.o prioritizers/alua_rtpg.o -lpthread -ldl -ldevmapper -ludev -L../libmpathcmd -lmpathcmd -lsystemd cc -shared -lpthread -ldevmapper -ldl -L../libmultipath -lmultipath -L../libmpathcmd -lmpathcmd -Wl,-soname=libmpathpersist.so.0 -O2 -g -pipe -Wall -Wextra -Wformat=2 -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fPIC -DLIB_STRING=\"lib64\" -DRUN_DIR=\"run\" -I../libmultipath -I../libmpathpersist -I../libmpathcmd -o libmpathpersist.so.0 mpath_persist.o mpath_updatepr.o mpath_pr_ioctl.o To: cc -shared -Wl,-soname=libmpathcmd.so.0 -o libmpathcmd.so.0 mpath_cmd.o cc -shared -Wl,-soname=libmultipath.so.0 -o libmultipath.so.0 memory.o parser.o vector.o devmapper.o callout.o hwtable.o blacklist.o util.o dmparser.o config.o structs.o discovery.o propsel.o dict.o pgpolicies.o debug.o defaults.o uevent.o time-util.o switchgroup.o uxsock.o print.o alias.o log_pthread.o log.o configure.o structs_vec.o sysfs.o prio.o checkers.o lock.o waiter.o file.o wwids.o prioritizers/alua_rtpg.o -lpthread -ldl -ldevmapper -ludev -L../libmpathcmd -lmpathcmd -lsystemd cc -shared -lpthread -ldevmapper -ldl -L../libmultipath -lmultipath -L../libmpathcmd -lmpathcmd -Wl,-soname=libmpathpersist.so.0 -o libmpathpersist.so.0 mpath_persist.o mpath_updatepr.o mpath_pr_ioctl.o Cc: Bart Van Assche Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmpathcmd/Makefile | 2 +- libmpathpersist/Makefile | 2 +- libmultipath/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile index 457c4ca..b8e29cb 100644 --- a/libmpathcmd/Makefile +++ b/libmpathcmd/Makefile @@ -9,7 +9,7 @@ OBJS = mpath_cmd.o all: $(LIBS) $(LIBS): $(OBJS) - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) $(LN) $@ $(DEVLIB) install: $(LIBS) diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile index 6e43427..6ef5bab 100644 --- a/libmpathpersist/Makefile +++ b/libmpathpersist/Makefile @@ -15,7 +15,7 @@ all: $(LIBS) $(LIBS): $(CC) -c $(CFLAGS) *.c - $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ -o $@ $(OBJS) $(LN) $(LIBS) $(DEVLIB) $(GZIP) mpath_persistent_reserve_in.3 > mpath_persistent_reserve_in.3.gz $(GZIP) mpath_persistent_reserve_out.3 > mpath_persistent_reserve_out.3.gz diff --git a/libmultipath/Makefile b/libmultipath/Makefile index a11e483..b5d54d8 100644 --- a/libmultipath/Makefile +++ b/libmultipath/Makefile @@ -47,7 +47,7 @@ OBJS = memory.o parser.o vector.o devmapper.o callout.o \ all: $(LIBS) $(LIBS): $(OBJS) - $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS) + $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ -o $@ $(OBJS) $(LIBDEPS) $(LN) $@ $(DEVLIB) install: