| Message ID | 20170421134212.2727744-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
On Fri, Apr 21, 2017 at 03:41:10PM +0200, Arnd Bergmann wrote: > mips-gcc-5.3 warns about correct code on linux-3.18 and earlier: > > In file included from ../include/linux/blkdev.h:4:0, > from ../drivers/md/dm-bufio.h:12, > from ../drivers/md/dm-bufio.c:9: > ../drivers/md/dm-bufio.c: In function 'alloc_buffer': > ../include/linux/sched.h:1975:56: warning: 'noio_flag' may be used uninitialized in this function [-Wmaybe-uninitialized] > current->flags = (current->flags & ~PF_MEMALLOC_NOIO) | flags; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ > ../drivers/md/dm-bufio.c:325:11: note: 'noio_flag' was declared here > > The warning disappeared on later kernels with this commit: be0c37c985ed > ("MIPS: Rearrange PTE bits into fixed positions.") I assume this only > happened because it changed some inlining decisions. > > On 3.18.y, we can shut up the warning by adding an extra initialization. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Now applied, thanks. greg k-h -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index ecbd3ffcf359..91fe43b98c96 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -349,6 +349,7 @@ static void *alloc_buffer_data(struct dm_bufio_client *c, gfp_t gfp_mask, * as if GFP_NOIO was specified. */ + noio_flag = 0; if (gfp_mask & __GFP_NORETRY) noio_flag = memalloc_noio_save();
mips-gcc-5.3 warns about correct code on linux-3.18 and earlier: In file included from ../include/linux/blkdev.h:4:0, from ../drivers/md/dm-bufio.h:12, from ../drivers/md/dm-bufio.c:9: ../drivers/md/dm-bufio.c: In function 'alloc_buffer': ../include/linux/sched.h:1975:56: warning: 'noio_flag' may be used uninitialized in this function [-Wmaybe-uninitialized] current->flags = (current->flags & ~PF_MEMALLOC_NOIO) | flags; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../drivers/md/dm-bufio.c:325:11: note: 'noio_flag' was declared here The warning disappeared on later kernels with this commit: be0c37c985ed ("MIPS: Rearrange PTE bits into fixed positions.") I assume this only happened because it changed some inlining decisions. On 3.18.y, we can shut up the warning by adding an extra initialization. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/md/dm-bufio.c | 1 + 1 file changed, 1 insertion(+)