From patchwork Tue Jan 23 17:07:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Wilck X-Patchwork-Id: 10180811 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30E03602B7 for ; Tue, 23 Jan 2018 17:18:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10B19284CE for ; Tue, 23 Jan 2018 17:18:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 03BEA28731; Tue, 23 Jan 2018 17:18:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7C60E284CE for ; Tue, 23 Jan 2018 17:18:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD7C37E446; Tue, 23 Jan 2018 17:18:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19D7117F4B; Tue, 23 Jan 2018 17:18:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7375E18033D9; Tue, 23 Jan 2018 17:18:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w0NH7trM010458 for ; Tue, 23 Jan 2018 12:07:55 -0500 Received: by smtp.corp.redhat.com (Postfix) id D933E63F94; Tue, 23 Jan 2018 17:07:55 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CFF66017B; Tue, 23 Jan 2018 17:07:52 +0000 (UTC) Received: from smtp.nue.novell.com (smtp.nue.novell.com [195.135.221.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 052058B10E; Tue, 23 Jan 2018 17:07:51 +0000 (UTC) Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 23 Jan 2018 18:07:49 +0100 Received: from apollon.suse.de.de (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Tue, 23 Jan 2018 17:07:38 +0000 From: Martin Wilck To: Christophe Varoqui , Xose Vazquez Perez , dm-devel@redhat.com Date: Tue, 23 Jan 2018 18:07:04 +0100 Message-Id: <20180123170704.15037-1-mwilck@suse.com> In-Reply-To: <20180113211938.31552-10-mwilck@suse.com> References: <20180113211938.31552-10-mwilck@suse.com> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 207 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 23 Jan 2018 17:07:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 23 Jan 2018 17:07:52 +0000 (UTC) for IP:'195.135.221.5' DOMAIN:'smtp.nue.novell.com' HELO:'smtp.nue.novell.com' FROM:'mwilck@suse.com' RCPT:'' X-RedHat-Spam-Score: -2.301 (RCVD_IN_DNSWL_MED, SPF_PASS) 195.135.221.5 smtp.nue.novell.com 195.135.221.5 smtp.nue.novell.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.28 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: dm-devel@redhat.com Cc: Martin Wilck Subject: [dm-devel] [FIX PATCH v2 09/20] libmultipath: hwtable: no_path_retry="queue" for NetApp NVMe X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 23 Jan 2018 17:18:30 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP Netapp requested this default setting for NetApp E-Series NVMe in addition to "multibus". Also, finalize the product ID regex after consulting with NetApp (the FW reporting just "ONTAP Controller" was beta only). This obsoletes my previous "FIX" patch 'FIX "libmultipath: hwtable: multibus for NetApp NVMe-FC' Fixes: "libmultipath: hwtable: multibus for NetApp NVMe-FC" Signed-off-by: Martin Wilck --- libmultipath/hwtable.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 1cde60a6a41d..0915ea4dfa56 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -681,16 +681,17 @@ static struct hwentry default_hw[] = { .no_path_retry = 24, }, /* - * NetApp NVMe-FC namespace devices: MULTIBUS preferred + * NetApp NVMe-FC namespace devices: MULTIBUS, queueing preferred * * The table is searched backwards, so place this after generic NVMe */ { .vendor = "NVME", - .product = "(NetApp |)ONTAP Controller)", + .product = "^NetApp ONTAP Controller", .uid_attribute = "ID_WWN", .checker_name = NONE, .pgpolicy = MULTIBUS, + .no_path_retry = NO_PATH_RETRY_QUEUE, .retain_hwhandler = RETAIN_HWHANDLER_OFF, }, /*