From patchwork Wed Mar 7 23:10:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xose Vazquez Perez X-Patchwork-Id: 10265555 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F39060211 for ; Wed, 7 Mar 2018 23:10:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DA63294BA for ; Wed, 7 Mar 2018 23:10:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3281B294D0; Wed, 7 Mar 2018 23:10:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8BFC0294BA for ; Wed, 7 Mar 2018 23:10:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5E6240F25; Wed, 7 Mar 2018 23:10:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE98B5D9C7; Wed, 7 Mar 2018 23:10:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 81F57181B9FE; Wed, 7 Mar 2018 23:10:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w27NA9KQ003457 for ; Wed, 7 Mar 2018 18:10:09 -0500 Received: by smtp.corp.redhat.com (Postfix) id D50B7601A3; Wed, 7 Mar 2018 23:10:09 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D06627DE52 for ; Wed, 7 Mar 2018 23:10:07 +0000 (UTC) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B29BC272B2 for ; Wed, 7 Mar 2018 23:10:05 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id i3so7703735wmi.4 for ; Wed, 07 Mar 2018 15:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IpSnPpxnlcup5KXXAyKoDKzI4uKFpGbUIZ6j8GGr2WM=; b=J46Oxo8kp7VfrqWB6rff6cBxijj6WNITGDjvF31akKdhFXh5/bKINWldFF3Do3ZNO3 bXWO/SCuX6UoBUdQ3fR9ajWDnSBT7xJZr5R3UTynLiaWicqGLBhctfYtG8VIKI+Kr1A8 Ia38Q2hMDFsJ5KYj5BsC6m1ABnUYgJq+7UVqy2yPtrMXNQlFUvLC/Lrn0BFPpffDqpUi X2GoysQMWW6Nl/qyiCytYtVyxlbRbQhIzJBYvdUQoFN1keAd432AMYpk4CQ6EfF8BWhh xbgo7ZpvskOHlU6pVQ/q/twXWRKnT1lTordeuFgNbSsOd/X6O7Sg2h62FndJMyXVjfkZ lA/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IpSnPpxnlcup5KXXAyKoDKzI4uKFpGbUIZ6j8GGr2WM=; b=NRG/+sVT6LpQ1ADf+OZcmrYOJj2r58Jpm20WEmfBRQ+seU7+r5LRFm8zK8QkRPKnbx QgatXnZu+n03ArQWGpaowCU760c9BWuv2LZAGg3cfkb6ccjhNH19ys50kzvgxdzwgL9G URiWCR1ApSOHtfbfMtdMVarDhUt8jRqNFmMpr/kKcq6SOyYNRSysjWvednwuJ6/k6yOL wQOu57qGuITfueVhPLERRd3vQxr1EhK9eLwzvKKWivuoFXr0Zv3AFtIaCICUIrkX2sr2 1k6Hkuf5pOueJunbB2Iz9vQ8KxkofWI1yCKPvngmgCZr3BEHaWNa7Vg6hRDa/TBxmdZc MZaw== X-Gm-Message-State: AElRT7FnUB9WV6v3WeWsRdvE4VOlWtk1vFtLiGJFDRn39tzZ4yeK8vYs h3NJz0dZa8JGteqjMPSvHOI2 X-Google-Smtp-Source: AG47ELsuDH0hi5GixrBuWHc6UMrRbRs+K2S6GZf8f1tyovclHLUglAKTp2tfIN0eT3diMidh6I0EPw== X-Received: by 10.28.236.154 with SMTP id h26mr6863725wmi.77.1520464203709; Wed, 07 Mar 2018 15:10:03 -0800 (PST) Received: from localhost (191.red-83-39-212.dynamicip.rima-tde.net. [83.39.212.191]) by smtp.gmail.com with ESMTPSA id s78sm40479341wrc.93.2018.03.07.15.10.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Mar 2018 15:10:03 -0800 (PST) From: Xose Vazquez Perez To: Date: Thu, 8 Mar 2018 00:10:00 +0100 Message-Id: <20180307231000.5255-2-xose.vazquez@gmail.com> In-Reply-To: <20180307231000.5255-1-xose.vazquez@gmail.com> References: <20180307231000.5255-1-xose.vazquez@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 07 Mar 2018 23:10:06 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 07 Mar 2018 23:10:06 +0000 (UTC) for IP:'74.125.82.66' DOMAIN:'mail-wm0-f66.google.com' HELO:'mail-wm0-f66.google.com' FROM:'xose.vazquez@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.13 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.82.66 mail-wm0-f66.google.com 74.125.82.66 mail-wm0-f66.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: dm-devel@redhat.com Cc: device-mapper development , Xose Vazquez Perez Subject: [dm-devel] [PATCH 2/2] multipath-tools: reformat and update comments in hwtable X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 07 Mar 2018 23:10:12 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 65b7835..fe71d14 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -72,13 +72,13 @@ .delay_wait_checks = DELAY_CHECKS_OFF, .skip_kpartx = SKIP_KPARTX_OFF, .max_sectors_kb = MAX_SECTORS_KB_UNDEF, - .ghost_delay = GHOST_DELAY_OFF + .ghost_delay = GHOST_DELAY_OFF, }, #endif static struct hwentry default_hw[] = { /* - * Generic NVMe devices + * Generic NVMe * * Due to the parsing logic in find_hwe(), generic entries * have to be put on top of this list, and more specific ones @@ -178,7 +178,7 @@ static struct hwentry default_hw[] = { .prio_name = PRIO_ALUA, }, { - /* MSA 1040, 2040 and 2050 families */ + /* MSA 1040, 1050, 2040 and 2050 families */ .vendor = "HP", .product = "MSA [12]0[45]0 SA[NS]", .pgpolicy = GROUP_BY_PRIO, @@ -264,7 +264,7 @@ static struct hwentry default_hw[] = { .no_path_retry = 30, }, { - /* DDN */ + /* (DDN) */ .vendor = "SGI", .product = "^DD[46]A-", .pgpolicy = GROUP_BY_PRIO, @@ -397,7 +397,7 @@ static struct hwentry default_hw[] = { * Mail : matthias.rudolph@hds.com */ { - /* USP-V, HUS VM, VSP, VSP G1000 and VSP GX00 families */ + /* USP-V, HUS VM, VSP, VSP G1X00 and VSP GX00 families */ .vendor = "(HITACHI|HP)", .product = "^OPEN-", .pgpolicy = MULTIBUS, @@ -646,7 +646,7 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, }, { - /* DDN */ + /* (DDN) DCS9900, SONAS 2851-DR1 */ .vendor = "IBM", .product = "^(DCS9900|2851)", .pgpolicy = GROUP_BY_PRIO, @@ -731,12 +731,12 @@ static struct hwentry default_hw[] = { .pgpolicy = MULTIBUS, .no_path_retry = 24, }, - /* - * NetApp NVMe-FC namespace devices: MULTIBUS, queueing preferred - * - * The table is searched backwards, so place this after generic NVMe - */ { + /* + * NVMe-FC namespace devices: MULTIBUS, queueing preferred + * + * The hwtable is searched backwards, so place this after "Generic NVMe" + */ .vendor = "NVME", .product = "^NetApp ONTAP Controller", .uid_attribute = "ID_WWN", @@ -1158,7 +1158,7 @@ static struct hwentry default_hw[] = { .no_path_retry = 30, }, /* - * Dot Hill Systems - Seagate Technology + * Seagate Technology (Dot Hill Systems) */ { /* SANnet family */