| Message ID | 20180705185622.5996-1-xose.vazquez@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
On Thu, 2018-07-05 at 20:56 +0200, Xose Vazquez Perez wrote: > In cf87a17ee840aafbbc6166f663963e5213573de7 Hannes says: > > The 'normal' SG_IO tur checker has some issues with cciss, so > we'd better use a dedicated path checker here. > > CC: Hannes Reinecke <hare@suse.de> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: DM-DEV ML <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > > cciss(block) driver was replaced by hpsa(scsi) in > 253d2464df446456c0bba5ed4137a7be0b278aa8 the last year. > > Should cciss be removed from multipath-tools? > > --- > libmultipath/hwtable.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index d3a8d9b..c460d29 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -199,11 +199,12 @@ static struct hwentry default_hw[] = { > .prio_name = PRIO_ALUA, > }, > { > - /* Smart Array */ > + /* Smart Array CCISS */ > .vendor = "HP", > .product = "LOGICAL VOLUME", > .pgpolicy = MULTIBUS, > .no_path_retry = 12, > + .checker_name = CCISS_TUR, > }, This won't work, because these volumes are detected as "HP" "LOGICAL VOLUME", no matter whether they're attached to the cciss or the hpsa driver. Martin
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index d3a8d9b..c460d29 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -199,11 +199,12 @@ static struct hwentry default_hw[] = { .prio_name = PRIO_ALUA, }, { - /* Smart Array */ + /* Smart Array CCISS */ .vendor = "HP", .product = "LOGICAL VOLUME", .pgpolicy = MULTIBUS, .no_path_retry = 12, + .checker_name = CCISS_TUR, }, { /* P2000 family */
In cf87a17ee840aafbbc6166f663963e5213573de7 Hannes says: The 'normal' SG_IO tur checker has some issues with cciss, so we'd better use a dedicated path checker here. CC: Hannes Reinecke <hare@suse.de> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: DM-DEV ML <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- cciss(block) driver was replaced by hpsa(scsi) in 253d2464df446456c0bba5ed4137a7be0b278aa8 the last year. Should cciss be removed from multipath-tools? --- libmultipath/hwtable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)