From patchwork Thu Jul 5 18:56:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xose Vazquez Perez X-Patchwork-Id: 10510195 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4313B6028F for ; Thu, 5 Jul 2018 18:56:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CBA320008 for ; Thu, 5 Jul 2018 18:56:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1DECF20683; Thu, 5 Jul 2018 18:56:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B3D4820008 for ; Thu, 5 Jul 2018 18:56:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ABFDD30820F4; Thu, 5 Jul 2018 18:56:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51A22308BDA3; Thu, 5 Jul 2018 18:56:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E8DE418037ED; Thu, 5 Jul 2018 18:56:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w65Iufpb028279 for ; Thu, 5 Jul 2018 14:56:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id A875A5B681; Thu, 5 Jul 2018 18:56:41 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CF385D761 for ; Thu, 5 Jul 2018 18:56:37 +0000 (UTC) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB00C3D96D for ; Thu, 5 Jul 2018 18:56:26 +0000 (UTC) Received: by mail-wm0-f41.google.com with SMTP id n17-v6so12331206wmh.2 for ; Thu, 05 Jul 2018 11:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nmZMTBvTZP4APGI6Tik3/vMAPDO7SNOGX7Ax0O0fHM8=; b=XAf9yPfVpLPGWSHEdvwMJzyUTP/Q1e9Gsh5TMM4zJiphH5dVaTqEd2uQHJ11vaBX9i b95UMwYedbC1hQDjNHaaySwuw9lDPVSJ1ULX2y6Pg/HXKaAutjXQup5IPqej3lcq5Fyk N3OwJOVRLav6Et9bhKtQuQLoggXbRFUl4cTBVQU8ouhRtqU0n7WhLQV6Rfb4/ZEs4q8g 5asgPc3bDQaegANnRjmIMzM60vjePDzJHXzdJW/8WWhknAPba+Q//AHyESLEqXaWQYcs yHAg0qRouk9YAnhZYDEmnoDBFrqbpGdhgexBMIxieUboB47SezdudXmktZzMnnVCz7EP 0XIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nmZMTBvTZP4APGI6Tik3/vMAPDO7SNOGX7Ax0O0fHM8=; b=p4S1agO1nTLHaX83/LKynGP+Ka6S4FrwMZbWM/FethJUr9cECF3+MJK8ycH7jvKL0R GtXqjM0TC9kl14bhAtY2dCLj9QoIcXyjpKfSrEVI9Be8xS4fystmXGWf33to1VU3gHCJ B0u4HjW4gaLe0HPyUlnya8fHbEtLNTw76bKctVRYR0moJosCefhxGCoXzKytByiUFlTg q0CDH3cqClomWzCMwPI257RGWpZ5eyLd+xjTGFO3TEaXTKAhmH/DyVenjdYe1UtY0/EC m4qOFwQu6SNkFr+an93mDCZHdUpkNei2ZEakgNCo4op1viiDPcsybUBJzi9CR6bsC++B tCvA== X-Gm-Message-State: APt69E2QpNrCL9runihuF/qLf7AUrwBBkZpQW2AiijrF6cZwXVVBhVo/ WTcZbG1G3zIbUdUMq+TslOwsSIQ= X-Google-Smtp-Source: AAOMgpc1nbLSxvsRF0Lb2cmyFODDUR0H0SPwZ1aXg4twjUynHsFmupZ1sj6NoayIOC2Oyy5MwKWEFg== X-Received: by 2002:a1c:b801:: with SMTP id i1-v6mr4602224wmf.30.1530816985226; Thu, 05 Jul 2018 11:56:25 -0700 (PDT) Received: from localhost ([90.174.3.49]) by smtp.gmail.com with ESMTPSA id o21-v6sm3093165wmg.28.2018.07.05.11.56.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jul 2018 11:56:24 -0700 (PDT) From: Xose Vazquez Perez To: Date: Thu, 5 Jul 2018 20:56:22 +0200 Message-Id: <20180705185622.5996-1-xose.vazquez@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 05 Jul 2018 18:56:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 05 Jul 2018 18:56:26 +0000 (UTC) for IP:'74.125.82.41' DOMAIN:'mail-wm0-f41.google.com' HELO:'mail-wm0-f41.google.com' FROM:'xose.vazquez@gmail.com' RCPT:'' X-RedHat-Spam-Score: 1.281 * (DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, NML_ADSP_CUSTOM_MED, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS, T_DKIM_INVALID) 74.125.82.41 mail-wm0-f41.google.com 74.125.82.41 mail-wm0-f41.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: dm-devel@redhat.com Cc: DM-DEV ML , Xose Vazquez Perez Subject: [dm-devel] [PATCH RFC] multipath-tools: add cciss_tur checker to CCISS arrays X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 05 Jul 2018 18:56:44 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP In cf87a17ee840aafbbc6166f663963e5213573de7 Hannes says: The 'normal' SG_IO tur checker has some issues with cciss, so we'd better use a dedicated path checker here. CC: Hannes Reinecke Cc: Christophe Varoqui Cc: DM-DEV ML Signed-off-by: Xose Vazquez Perez --- cciss(block) driver was replaced by hpsa(scsi) in 253d2464df446456c0bba5ed4137a7be0b278aa8 the last year. Should cciss be removed from multipath-tools? --- libmultipath/hwtable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index d3a8d9b..c460d29 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -199,11 +199,12 @@ static struct hwentry default_hw[] = { .prio_name = PRIO_ALUA, }, { - /* Smart Array */ + /* Smart Array CCISS */ .vendor = "HP", .product = "LOGICAL VOLUME", .pgpolicy = MULTIBUS, .no_path_retry = 12, + .checker_name = CCISS_TUR, }, { /* P2000 family */