From patchwork Wed Jul 11 20:36:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 10520451 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 22F8060626 for ; Wed, 11 Jul 2018 20:37:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 02D5629265 for ; Wed, 11 Jul 2018 20:37:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB355298E0; Wed, 11 Jul 2018 20:37:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 93668298F2 for ; Wed, 11 Jul 2018 20:37:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D392930832EE; Wed, 11 Jul 2018 20:37:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 94F2A308332F; Wed, 11 Jul 2018 20:37:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 30B1618037F6; Wed, 11 Jul 2018 20:37:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w6BKadoX014926 for ; Wed, 11 Jul 2018 16:36:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9592B1062244; Wed, 11 Jul 2018 20:36:39 +0000 (UTC) Delivered-To: dm-devel@redhat.com Received: from mx1.redhat.com (ext-mx16.extmail.prod.ext.phx2.redhat.com [10.5.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AB091001F3D for ; Wed, 11 Jul 2018 20:36:39 +0000 (UTC) Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D7ACD3082A31 for ; Wed, 11 Jul 2018 20:36:38 +0000 (UTC) Received: by mail-pf0-f193.google.com with SMTP id b17-v6so19139901pfi.0 for ; Wed, 11 Jul 2018 13:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z0UiKUkbaIJ74sZlGjVbsXVX3NSh4Durhbkhjh0YhvQ=; b=KOsg1KchypdBz+ZkFX+knHTEQifNztOQH/N2DO/TnuOQLO1D+ZBfB8A5AnsqXzdWpq 4KaQmCiAnRJhbHOzRIU8c67ZEA4fttVXwvD4rA4BfuwflWx4VZieO5OLoIdzP7eVmtHV etEy4qU2eIsQ1WIRLwEBWPTa01HaAhZ1C+Jf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z0UiKUkbaIJ74sZlGjVbsXVX3NSh4Durhbkhjh0YhvQ=; b=uLm2L9Z/Cf5MCZyeoxaok0VKrstjDd5tMdTYNwtuMJXoTPLVNwljK/h6UMMKSXJrJp WofEXqzNo9am/XgnvyP0YKblz2zzuWYgjBs6bUsZ3hOPyhrJhQJ+GHbg/WI/vjaS3rmd HVR5pTYkmwiJiARMqtqq+PJJC36w5TzEF/3UTMqFlhiNb8G3KalC4xIfb+xuqBNbW/e/ uF+LjixYVF4WAsEljHs5av9tKy2H3b72Cl+3/rU8VFUWZteSqhl9oK5mumkaKCuxyssE P/xe32zXbXurK8YVaaATysVPZcnkw/zuaG8gVyHo5m8ON5kP3Go4sGIyZN3t870MYNYT OpcA== X-Gm-Message-State: AOUpUlFSwRLb24zmQKuSj74EoGMKeJHUBzpb78soyI+2Pr7EC38E3Xco MxBXTtjBqTusfQHGfgcFf8zugw== X-Google-Smtp-Source: AAOMgpd57X0B++JahNWQOiTavlKY07Yiu3g+Z5C+koVVmGeqtWibcBg6uX3DUmJJT0LgwKpcpOJBHA== X-Received: by 2002:a63:1063:: with SMTP id 35-v6mr122477pgq.249.1531341398414; Wed, 11 Jul 2018 13:36:38 -0700 (PDT) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id n9-v6sm25574832pfg.21.2018.07.11.13.36.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Jul 2018 13:36:35 -0700 (PDT) From: Kees Cook To: Herbert Xu Date: Wed, 11 Jul 2018 13:36:18 -0700 Message-Id: <20180711203619.1020-14-keescook@chromium.org> In-Reply-To: <20180711203619.1020-1-keescook@chromium.org> References: <20180711203619.1020-1-keescook@chromium.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 11 Jul 2018 20:36:38 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 11 Jul 2018 20:36:38 +0000 (UTC) for IP:'209.85.192.193' DOMAIN:'mail-pf0-f193.google.com' HELO:'mail-pf0-f193.google.com' FROM:'keescook@chromium.org' RCPT:'' X-RedHat-Spam-Score: -0.112 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_PASS) 209.85.192.193 mail-pf0-f193.google.com 209.85.192.193 mail-pf0-f193.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.45 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: dm-devel@redhat.com Cc: Giovanni Cabiddu , Kees Cook , Arnd Bergmann , Eric Biggers , Mike Snitzer , "Gustavo A. R. Silva" , qat-linux@intel.com, linux-kernel@vger.kernel.org, Masahiro Yamada , dm-devel@redhat.com, linux-crypto@vger.kernel.org, Lars Persson , Tim Chen , "David S. Miller" , Alasdair Kergon , Rabin Vincent Subject: [dm-devel] [PATCH v4 13/14] rxrpc: Prepare to remove VLA usage for SKCIPHER_REQUEST_ON_STACK X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 11 Jul 2018 20:37:04 +0000 (UTC) X-Virus-Scanned: ClamAV using ClamSMTP Two uses of SKCIPHER_REQUEST_ON_STACK() will trigger FRAME_WARN warnings (when less than 2048) once the VLA is no longer hidden from the check: net/rxrpc/rxkad.c:398:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] net/rxrpc/rxkad.c:242:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=] This bumps the affected objects by 20% to silence the warnings while still providing coverage is anything grows even more. Signed-off-by: Kees Cook --- net/rxrpc/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/net/rxrpc/Makefile b/net/rxrpc/Makefile index 6ffb7e9887ce..53e1177129e6 100644 --- a/net/rxrpc/Makefile +++ b/net/rxrpc/Makefile @@ -32,4 +32,5 @@ rxrpc-y := \ rxrpc-$(CONFIG_PROC_FS) += proc.o rxrpc-$(CONFIG_RXKAD) += rxkad.o +CFLAGS_rxkad.o += $(FRAME_WARN_BUMP_FLAG) rxrpc-$(CONFIG_SYSCTL) += sysctl.o