| Message ID | 20181010195116.5588-1-xose.vazquez@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | multipath-tools: delete trailing whitespaces | expand |
On Wed, 2018-10-10 at 21:51 +0200, Xose Vazquez Perez wrote: > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: DM-DEV ML <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > libmultipath/checkers/tur.c | 2 +- > tests/dmevents.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Nack. This just pollutes git history and "git blame" output. Let's just try not to add more whitespace issues with new patches, and fix issues in exisiting code when we need to touch it anyway. Martin -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/checkers/tur.c b/libmultipath/checkers/tur.c index 86c0cdc..5aeec6f 100644 --- a/libmultipath/checkers/tur.c +++ b/libmultipath/checkers/tur.c @@ -334,7 +334,7 @@ int libcheck_check(struct checker * c) tur_timeout(&tsp); pthread_mutex_lock(&ct->lock); if (ct->state == PATH_PENDING) - r = pthread_cond_timedwait(&ct->active, &ct->lock, + r = pthread_cond_timedwait(&ct->active, &ct->lock, &tsp); if (!r) { tur_status = ct->state; diff --git a/tests/dmevents.c b/tests/dmevents.c index 3399c81..bee117a 100644 --- a/tests/dmevents.c +++ b/tests/dmevents.c @@ -465,7 +465,7 @@ static void test_watch_dmevents_good1(void **state) skip(); remove_all_dm_device_events(); - assert_int_equal(add_dm_device_event("foo", 1, 5), 0); + assert_int_equal(add_dm_device_event("foo", 1, 5), 0); will_return(__wrap_dm_geteventnr, 0); assert_int_equal(watch_dmevents("foo"), 0); dev_evt = find_dmevents("foo");
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: DM-DEV ML <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- libmultipath/checkers/tur.c | 2 +- tests/dmevents.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)