diff mbox series

[4/8] multipath.rules: add comment about DM_MULTIPATH_DEVICE_PATH=2

Message ID 20181010200506.15796-5-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series various multipath-tools patches | expand

Commit Message

Martin Wilck Oct. 10, 2018, 8:05 p.m. UTC
See dm-devel discussion "Changes in DM_MULTIPATH_DEVICE_PATH in
multipath-tools 0.7.7" (Sep. 2018) for rationale.

Cc: Adam Williamson <awilliam@redhat.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipath/multipath.rules | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Benjamin Marzinski Oct. 12, 2018, 9:49 p.m. UTC | #1
On Wed, Oct 10, 2018 at 10:05:02PM +0200, Martin Wilck wrote:
> See dm-devel discussion "Changes in DM_MULTIPATH_DEVICE_PATH in
> multipath-tools 0.7.7" (Sep. 2018) for rationale.
> 

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> Cc: Adam Williamson <awilliam@redhat.com>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  multipath/multipath.rules | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/multipath/multipath.rules b/multipath/multipath.rules
> index d658073f..9df11a95 100644
> --- a/multipath/multipath.rules
> +++ b/multipath/multipath.rules
> @@ -45,6 +45,10 @@ ENV{DM_MULTIPATH_DEVICE_PATH}!="2", \
>  # Code below here is only run in "smart" mode.
>  # multipath -u has indicated this is "maybe" multipath.
>  
> +# Note that DM_MULTIPATH_DEVICE_PATH has the value 2 at this point.
> +# This value will never propagate to other rules files, because
> +# it will be reset to 1 in the "pretend_multipath" section below.
> +
>  # This shouldn't happen, just in case.
>  ENV{FIND_MULTIPATHS_WAIT_UNTIL}!="?*", GOTO="end_mpath"
>  
> -- 
> 2.19.0

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/multipath/multipath.rules b/multipath/multipath.rules
index d658073f..9df11a95 100644
--- a/multipath/multipath.rules
+++ b/multipath/multipath.rules
@@ -45,6 +45,10 @@  ENV{DM_MULTIPATH_DEVICE_PATH}!="2", \
 # Code below here is only run in "smart" mode.
 # multipath -u has indicated this is "maybe" multipath.
 
+# Note that DM_MULTIPATH_DEVICE_PATH has the value 2 at this point.
+# This value will never propagate to other rules files, because
+# it will be reset to 1 in the "pretend_multipath" section below.
+
 # This shouldn't happen, just in case.
 ENV{FIND_MULTIPATHS_WAIT_UNTIL}!="?*", GOTO="end_mpath"