| Message ID | 20181023220552.1306-3-mwilck@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | multipathd: make uxlsnr errors really fatal | expand |
On Wed, Oct 24, 2018 at 12:05:47AM +0200, Martin Wilck wrote: > After "libmultipath: set pp->checkint in store_pathinfo()", > pp-checkint should always be properly initialized, so this code > is not needed any more. > Reviewed-by: Benjamin Marzinsk <bmarzins@redhat.com> > Cc: Bart Van Assche <Bart.VanAssche@sandisk.com> > Signed-off-by: Martin Wilck <mwilck@suse.com> > --- > multipathd/main.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/multipathd/main.c b/multipathd/main.c > index b8423d89..3464ebfa 100644 > --- a/multipathd/main.c > +++ b/multipathd/main.c > @@ -2131,19 +2131,6 @@ check_path (struct vectors * vecs, struct path * pp, int ticks) > return 1; > } > > -static void init_path_check_interval(struct vectors *vecs) > -{ > - struct config *conf; > - struct path *pp; > - unsigned int i; > - > - vector_foreach_slot (vecs->pathvec, pp, i) { > - conf = get_multipath_config(); > - pp->checkint = conf->checkint; > - put_multipath_config(conf); > - } > -} > - > static void * > checkerloop (void *ap) > { > @@ -2727,7 +2714,6 @@ child (void * param) > */ > post_config_state(DAEMON_CONFIGURE); > > - init_path_check_interval(vecs); > > if (poll_dmevents) { > if (init_dmevent_waiter(vecs)) { > -- > 2.19.1 -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/multipathd/main.c b/multipathd/main.c index b8423d89..3464ebfa 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -2131,19 +2131,6 @@ check_path (struct vectors * vecs, struct path * pp, int ticks) return 1; } -static void init_path_check_interval(struct vectors *vecs) -{ - struct config *conf; - struct path *pp; - unsigned int i; - - vector_foreach_slot (vecs->pathvec, pp, i) { - conf = get_multipath_config(); - pp->checkint = conf->checkint; - put_multipath_config(conf); - } -} - static void * checkerloop (void *ap) { @@ -2727,7 +2714,6 @@ child (void * param) */ post_config_state(DAEMON_CONFIGURE); - init_path_check_interval(vecs); if (poll_dmevents) { if (init_dmevent_waiter(vecs)) {
After "libmultipath: set pp->checkint in store_pathinfo()", pp-checkint should always be properly initialized, so this code is not needed any more. Cc: Bart Van Assche <Bart.VanAssche@sandisk.com> Signed-off-by: Martin Wilck <mwilck@suse.com> --- multipathd/main.c | 14 -------------- 1 file changed, 14 deletions(-)